feat(server): resolve app translations across remaining metadata resolvers (#22237)

## Summary

**PR 3/4** of the app-metadata-translations stack. Extends runtime
translation resolution to the remaining Twenty-rendered metadata types
so coverage is complete.

- New shared `MetadataTranslationResolverService.getApplicationCatalog({
applicationId, workspaceId, locale })` — the single seam for fetching an
app's per-locale catalog.
- Wired into the **page-layout tab**, **page-layout widget**,
**view-field-group**, **command-menu navigation item**, and **view
name** resolvers, each extended with an optional `applicationCatalog`
param (backward-compatible).

Together with PR 1/4 (object + field), this covers all seven
translatable metadata surfaces.

## Stack
Stacks on #22236 (PR 2/4). Base branch:
`claude/app-translation-2-sdk-manifest`.

## Verification note
`yarn install` could not complete in the remote dev environment, so
typecheck/lint/tests were not run locally — **CI is the source of
truth**.

https://claude.ai/code/session_01NiE7o3cd3zCLZarVkJa6UA

---
_Generated by [Claude
Code](https://claude.ai/code/session_01NiE7o3cd3zCLZarVkJa6UA)_

<!-- This is an auto-generated description by cubic. -->
<a
href="https://cubic.dev/pr/twentyhq/twenty/pull/22237?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>
<!-- End of auto-generated description by cubic. -->
This commit is contained in:
Félix Malfait
2026-06-29 22:49:36 +02:00
committed by GitHub
parent fb800e7a2d
commit b1a781fbd9
15 changed files with 164 additions and 110 deletions
@@ -52,6 +52,8 @@ export class CommandMenuItemResolver {
objectMetadataLoader: context.loaders.objectMetadataLoader,
standardApplicationIdLoader:
context.loaders.standardApplicationIdLoader,
applicationTranslationCatalogLoader:
context.loaders.applicationTranslationCatalogLoader,
workspaceId: workspace.id,
locale: context.req.locale,
})) ?? ''
@@ -69,6 +71,8 @@ export class CommandMenuItemResolver {
fieldName: 'shortLabel',
objectMetadataLoader: context.loaders.objectMetadataLoader,
standardApplicationIdLoader: context.loaders.standardApplicationIdLoader,
applicationTranslationCatalogLoader:
context.loaders.applicationTranslationCatalogLoader,
workspaceId: workspace.id,
locale: context.req.locale,
});
@@ -85,6 +89,8 @@ export class CommandMenuItemResolver {
fieldName: 'icon',
objectMetadataLoader: context.loaders.objectMetadataLoader,
standardApplicationIdLoader: context.loaders.standardApplicationIdLoader,
applicationTranslationCatalogLoader:
context.loaders.applicationTranslationCatalogLoader,
workspaceId: workspace.id,
locale: context.req.locale,
});
@@ -7,6 +7,7 @@ import { isDefined } from 'twenty-shared/utils';
import { ApplicationService } from 'src/engine/core-modules/application/application.service';
import { I18nService } from 'src/engine/core-modules/i18n/i18n.service';
import {
type ApplicationTranslationCatalogLoaderPayload,
type ObjectMetadataLoaderPayload,
type StandardApplicationIdLoaderPayload,
} from 'src/engine/dataloaders/dataloader.service';
@@ -449,6 +450,7 @@ export class CommandMenuItemService {
fieldName,
objectMetadataLoader,
standardApplicationIdLoader,
applicationTranslationCatalogLoader,
workspaceId,
locale,
}: {
@@ -462,6 +464,10 @@ export class CommandMenuItemService {
StandardApplicationIdLoaderPayload,
string
>;
applicationTranslationCatalogLoader: DataLoader<
ApplicationTranslationCatalogLoaderPayload,
Record<string, string> | undefined
>;
workspaceId: string;
locale: keyof typeof APP_LOCALES | undefined;
}): Promise<string | undefined> {
@@ -479,6 +485,16 @@ export class CommandMenuItemService {
? objectMetadata.applicationId === standardApplicationId
: false;
// The loader returns undefined for the standard app, so the standard-app
// short-circuit lives in the loader, not here.
const applicationCatalog = isDefined(objectMetadata)
? await applicationTranslationCatalogLoader.load({
applicationId: objectMetadata.applicationId,
workspaceId,
locale: locale ?? SOURCE_LOCALE,
})
: undefined;
return interpolateNavigationCommandMenuItemField({
commandMenuItem,
fieldName,
@@ -486,6 +502,7 @@ export class CommandMenuItemService {
isStandardApp,
locale,
i18nInstance: this.i18nService.getI18nInstance(locale ?? SOURCE_LOCALE),
applicationCatalog,
});
}
@@ -17,11 +17,13 @@ export const buildNavigationInterpolationContext = ({
isStandardApp,
locale,
i18nInstance,
applicationCatalog,
}: {
objectMetadata: NavigationInterpolationObjectMetadata;
isStandardApp: boolean;
locale: keyof typeof APP_LOCALES | undefined;
i18nInstance: I18n;
applicationCatalog?: Record<string, string>;
}): Record<string, unknown> => {
const overrideInput = {
labelPlural: objectMetadata.labelPlural,
@@ -37,6 +39,7 @@ export const buildNavigationInterpolationContext = ({
locale,
i18nInstance,
isStandardApp,
applicationCatalog,
);
const resolvedIcon = resolveObjectMetadataStandardOverride(
@@ -45,6 +48,7 @@ export const buildNavigationInterpolationContext = ({
locale,
i18nInstance,
isStandardApp,
applicationCatalog,
);
return {
@@ -19,6 +19,7 @@ export const interpolateNavigationCommandMenuItemField = ({
isStandardApp,
locale,
i18nInstance,
applicationCatalog,
}: {
commandMenuItem: CommandMenuItemDTO;
fieldName: 'label' | 'shortLabel' | 'icon';
@@ -26,6 +27,7 @@ export const interpolateNavigationCommandMenuItemField = ({
isStandardApp: boolean;
locale: keyof typeof APP_LOCALES | undefined;
i18nInstance: I18n;
applicationCatalog?: Record<string, string>;
}): string | undefined => {
const rawValue = commandMenuItem[fieldName];
@@ -49,6 +51,7 @@ export const interpolateNavigationCommandMenuItemField = ({
isStandardApp,
locale,
i18nInstance,
applicationCatalog,
});
return (