Fix relations creation with metadata v2 (#13967)

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/from-relation-create-field-input-to-flat-field-metadata.util.ts

@@ -33,7 +33,7 @@ const computeFieldMetadataRelationSettingsForRelationType = ({
     return {
       relationType: RelationType.MANY_TO_ONE,
       onDelete: RelationOnDeleteAction.SET_NULL,
-      joinColumnName: fieldMetadataName,
+      joinColumnName: `${fieldMetadataName}Id`,
     };
   }
 
@@ -131,9 +131,9 @@ export const fromRelationCreateFieldInputToFlatFieldMetadata = async ({
   const targetCreateFieldInput: CreateFieldInput = {
     icon: relationCreationPayload.targetFieldIcon ?? 'Icon123',
     label: relationCreationPayload.targetFieldLabel,
-    name: `${computeMetadataNameFromLabel(
+    name: computeMetadataNameFromLabel(
       relationCreationPayload.targetFieldLabel,
-    )}Id`,
+    ),
     objectMetadataId: targetParentFlatObjectMetadata.id,
     type: FieldMetadataType.RELATION,
     workspaceId,

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/is-composite-flat-field-metadata.util.ts

@@ -3,7 +3,7 @@ import {
   type CompositeFieldMetadataType,
 } from 'src/engine/metadata-modules/field-metadata/types/composite-field-metadata-type.type';
 import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { isFlatFieldMetadataEntityOfTypes } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-falt-field-metadata-of-types.util';
+import { isFlatFieldMetadataEntityOfTypes } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-flat-field-metadata-of-types.util';
 
 export const isCompositeFlatFieldMetadata = (
   flatFieldMetadata: FlatFieldMetadata,

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/is-enum-flat-field-metadata.util.ts

@@ -3,7 +3,7 @@ import {
   type EnumFieldMetadataType,
 } from 'src/engine/metadata-modules/field-metadata/types/enum-field-metadata-type.type';
 import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { isFlatFieldMetadataEntityOfTypes } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-falt-field-metadata-of-types.util';
+import { isFlatFieldMetadataEntityOfTypes } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-flat-field-metadata-of-types.util';
 
 export const isEnumFlatFieldMetadata = (
   flatFieldMetadata: FlatFieldMetadata,

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/is-relation-flat-field-metadata.util.ts

@@ -3,7 +3,7 @@ import {
   type RelationFieldMetadataType,
 } from 'src/engine/metadata-modules/field-metadata/types/relation-field-metadata-type.type';
 import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { isFlatFieldMetadataEntityOfTypes } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-falt-field-metadata-of-types.util';
+import { isFlatFieldMetadataEntityOfTypes } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-flat-field-metadata-of-types.util';
 
 export const isRelationFlatFieldMetadata = (
   flatFieldMetadata: FlatFieldMetadata,