Logic function refactorization (#17861)

As title

packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/code-action/components/WorkflowEditActionCode.tsx

@@ -1,6 +1,8 @@
-import { useGetLogicFunctionSourceCode } from '@/logic-functions/hooks/useGetLogicFunctionSourceCode';
-import { useGetAvailablePackages } from '@/settings/logic-functions/hooks/useGetAvailablePackages';
-import { type LogicFunctionFormValues } from '@/settings/logic-functions/hooks/useLogicFunctionUpdateFormState';
+import { useGetAvailablePackages } from '@/logic-functions/hooks/useGetAvailablePackages';
+import {
+  type LogicFunctionFormValues,
+  useLogicFunctionUpdateFormState,
+} from '@/logic-functions/hooks/useLogicFunctionUpdateFormState';
 import { useFullScreenModal } from '@/ui/layout/fullscreen/hooks/useFullScreenModal';
 import { type BreadcrumbProps } from '@/ui/navigation/bread-crumb/components/Breadcrumb';
 import { useGetUpdatableWorkflowVersionOrThrow } from '@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow';
@@ -11,7 +13,6 @@ import { setNestedValue } from '@/workflow/workflow-steps/workflow-actions/code-
 
 import { CmdEnterActionButton } from '@/action-menu/components/CmdEnterActionButton';
 import { LogicFunctionExecutionResult } from '@/logic-functions/components/LogicFunctionExecutionResult';
-import { INDEX_FILE_NAME } from '@/logic-functions/constants/IndexFileName';
 import { getFunctionInputFromSourceCode } from '@/logic-functions/utils/getFunctionInputFromSourceCode';
 import { mergeDefaultFunctionInputAndFunctionInput } from '@/logic-functions/utils/mergeDefaultFunctionInputAndFunctionInput';
 import { InputLabel } from '@/ui/input/components/InputLabel';
@@ -35,10 +36,8 @@ import { WorkflowVariablePicker } from '@/workflow/workflow-variables/components
 import styled from '@emotion/styled';
 import { useLingui } from '@lingui/react/macro';
 
-import { SOURCE_FOLDER_NAME } from '@/logic-functions/constants/SourceFolderName';
 import { useExecuteLogicFunction } from '@/logic-functions/hooks/useExecuteLogicFunction';
 import { usePersistLogicFunction } from '@/logic-functions/hooks/usePersistLogicFunction';
-import { computeNewSources } from '@/logic-functions/utils/computeNewSources';
 import { WorkflowStepFooter } from '@/workflow/workflow-steps/components/WorkflowStepFooter';
 import { CODE_ACTION } from '@/workflow/workflow-steps/workflow-actions/constants/actions/CodeAction';
 import { type Monaco } from '@monaco-editor/react';
@@ -104,7 +103,7 @@ export const WorkflowEditActionCode = ({
     activeTabIdComponentState,
     WORKFLOW_LOGIC_FUNCTION_TAB_LIST_COMPONENT_ID,
   );
-  const { updateLogicFunctionSource } = usePersistLogicFunction();
+  const { updateLogicFunction } = usePersistLogicFunction();
   const { getUpdatableWorkflowVersion } =
     useGetUpdatableWorkflowVersionOrThrow();
 
@@ -126,21 +125,8 @@ export const WorkflowEditActionCode = ({
       action.settings.input.logicFunctionInput,
     );
 
-  const { code: codeFromApi, loading } = useGetLogicFunctionSourceCode({
-    logicFunctionId,
-  });
-
-  const [formValues, setFormValues] = useState<LogicFunctionFormValues>({
-    name: '',
-    description: '',
-    code: { src: { 'index.ts': '' } },
-  });
-
-  useEffect(() => {
-    if (isDefined(codeFromApi)) {
-      setFormValues((prev) => ({ ...prev, code: codeFromApi }));
-    }
-  }, [codeFromApi]);
+  const { formValues, setFormValues, loading } =
+    useLogicFunctionUpdateFormState({ logicFunctionId });
 
   const updateOutputSchemaFromTestResult = async (testResult: object) => {
     if (actionOptions.readonly === true) {
@@ -159,10 +145,12 @@ export const WorkflowEditActionCode = ({
   });
 
   const handleSave = useDebouncedCallback(async () => {
-    await updateLogicFunctionSource({
+    await updateLogicFunction({
       input: {
         id: logicFunctionId,
-        code: formValues.code,
+        update: {
+          sourceHandlerCode: formValues.code,
+        },
       },
     });
   }, 500);
@@ -174,11 +162,7 @@ export const WorkflowEditActionCode = ({
     setFormValues((prevState: LogicFunctionFormValues) => {
       return {
         ...prevState,
-        code: computeNewSources({
-          previousCode: prevState['code'],
-          filePath: `${SOURCE_FOLDER_NAME}/${INDEX_FILE_NAME}`,
-          value: newCode,
-        }),
+        code: newCode,
       };
     });
     await handleSave();
@@ -273,7 +257,7 @@ export const WorkflowEditActionCode = ({
     }
 
     if (!isExecuting) {
-      await executeLogicFunction({ forceRebuild: true });
+      await executeLogicFunction();
     }
   };
 
@@ -387,12 +371,6 @@ export const WorkflowEditActionCode = ({
     setIsFullScreen(false);
   };
 
-  const indexFileContent =
-    typeof formValues.code?.[SOURCE_FOLDER_NAME] !== 'string' &&
-    typeof formValues.code[SOURCE_FOLDER_NAME][INDEX_FILE_NAME] === 'string'
-      ? formValues.code[SOURCE_FOLDER_NAME][INDEX_FILE_NAME]
-      : '';
-
   const fullScreenOverlay = renderFullScreenModal(
     <div data-globally-prevent-click-outside="true">
       <WorkflowEditActionCodeFields
@@ -404,7 +382,7 @@ export const WorkflowEditActionCode = ({
       <StyledFullScreenCodeEditorContainer>
         <CodeEditor
           height="100%"
-          value={indexFileContent}
+          value={formValues.code}
           language="typescript"
           onChange={handleCodeChange}
           onMount={handleEditorDidMount}
@@ -439,7 +417,7 @@ export const WorkflowEditActionCode = ({
                 readonly={actionOptions.readonly}
               />
               <WorkflowCodeEditor
-                value={indexFileContent}
+                value={formValues.code}
                 onChange={handleCodeChange}
                 onMount={handleEditorDidMount}
                 options={{

packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/code-action/components/WorkflowReadonlyActionCode.tsx

@@ -1,9 +1,7 @@
-import { useGetAvailablePackages } from '@/settings/logic-functions/hooks/useGetAvailablePackages';
+import { useGetAvailablePackages } from '@/logic-functions/hooks/useGetAvailablePackages';
 import { type WorkflowCodeAction } from '@/workflow/types/Workflow';
 import { useGetLogicFunctionSourceCode } from '@/logic-functions/hooks/useGetLogicFunctionSourceCode';
 
-import { INDEX_FILE_NAME } from '@/logic-functions/constants/IndexFileName';
-import { SOURCE_FOLDER_NAME } from '@/logic-functions/constants/SourceFolderName';
 import { WorkflowStepBody } from '@/workflow/workflow-steps/components/WorkflowStepBody';
 import { WorkflowEditActionCodeFields } from '@/workflow/workflow-steps/workflow-actions/code-action/components/WorkflowEditActionCodeFields';
 import { getWrongExportedFunctionMarkers } from '@/workflow/workflow-steps/workflow-actions/code-action/utils/getWrongExportedFunctionMarkers';
@@ -52,13 +50,6 @@ export const WorkflowReadonlyActionCode = ({
     return null;
   }
 
-  const indexFileContent =
-    code != null &&
-    typeof code?.[SOURCE_FOLDER_NAME] !== 'string' &&
-    typeof code[SOURCE_FOLDER_NAME]?.[INDEX_FILE_NAME] === 'string'
-      ? code[SOURCE_FOLDER_NAME][INDEX_FILE_NAME]
-      : '';
-
   return (
     <>
       <WorkflowStepBody>
@@ -69,7 +60,7 @@ export const WorkflowReadonlyActionCode = ({
         <StyledCodeEditorContainer>
           <CodeEditor
             height={343}
-            value={indexFileContent}
+            value={code ?? undefined}
             language="typescript"
             onMount={handleEditorDidMount}
             setMarkers={getWrongExportedFunctionMarkers}

packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/logic-function-action/components/WorkflowEditActionLogicFunction.tsx

@@ -1,6 +1,6 @@
 import { getDefaultFunctionInputFromInputSchema } from '@/logic-functions/utils/getDefaultFunctionInputFromInputSchema';
 import { mergeDefaultFunctionInputAndFunctionInput } from '@/logic-functions/utils/mergeDefaultFunctionInputAndFunctionInput';
-import { useGetOneLogicFunction } from '@/settings/logic-functions/hooks/useGetOneLogicFunction';
+import { useGetOneLogicFunction } from '@/logic-functions/hooks/useGetOneLogicFunction';
 import { type WorkflowLogicFunctionAction } from '@/workflow/types/Workflow';
 import { WorkflowStepBody } from '@/workflow/workflow-steps/components/WorkflowStepBody';
 import { WorkflowStepFooter } from '@/workflow/workflow-steps/components/WorkflowStepFooter';