chore: remove IS_ROW_LEVEL_PERMISSION_PREDICATES_ENABLED and IS_DATE_TIME_WHOLE_DAY_FILTER_ENABLED feature flags (#19082)
## Summary - Removes `IS_ROW_LEVEL_PERMISSION_PREDICATES_ENABLED` feature flag, making row-level permission predicates always enabled. Removes early-return guards from query builders (select, update, insert) and the shared utility, the public feature flag metadata entry, and `updateFeatureFlag` calls from integration tests. - Removes `IS_DATE_TIME_WHOLE_DAY_FILTER_ENABLED` feature flag, making whole-day datetime filtering always enabled. Simplifies filter input components and hooks to always use date-only format for `IS` operand on `DATE_TIME` fields. - Cleans up enum definitions, seed data, generated schema files, and test mocks for both flags.
This commit is contained in:
+5
-14
@@ -8,7 +8,6 @@ import { SettingsRolePermissionsObjectLevelRecordLevelSection } from '@/settings
|
||||
import { settingsDraftRoleFamilyState } from '@/settings/roles/states/settingsDraftRoleFamilyState';
|
||||
import { SubMenuTopBarContainer } from '@/ui/layout/page/components/SubMenuTopBarContainer';
|
||||
import { useAtomFamilyStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomFamilyStateValue';
|
||||
import { useFeatureFlagsMap } from '@/workspace/hooks/useFeatureFlagsMap';
|
||||
import { t } from '@lingui/core/macro';
|
||||
import { useSearchParams } from 'react-router-dom';
|
||||
import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';
|
||||
@@ -23,7 +22,6 @@ import { useQuery } from '@apollo/client/react';
|
||||
import {
|
||||
type BillingEntitlement,
|
||||
BillingEntitlementKey,
|
||||
FeatureFlagKey,
|
||||
FindOneAgentDocument,
|
||||
} from '~/generated-metadata/graphql';
|
||||
|
||||
@@ -55,8 +53,6 @@ export const SettingsRolePermissionsObjectLevelObjectForm = ({
|
||||
objectId: objectMetadataId,
|
||||
});
|
||||
|
||||
const featureFlagsMap = useFeatureFlagsMap();
|
||||
|
||||
const workspaceBillingEntitlements = currentWorkspace?.billingEntitlements;
|
||||
|
||||
const isRLSBillingEntitlementEnabled =
|
||||
@@ -66,9 +62,6 @@ export const SettingsRolePermissionsObjectLevelObjectForm = ({
|
||||
entitlement.value === true,
|
||||
) ?? false;
|
||||
|
||||
const isRowLevelPermissionPredicatesEnabled =
|
||||
featureFlagsMap[FeatureFlagKey.IS_ROW_LEVEL_PERMISSION_PREDICATES_ENABLED];
|
||||
|
||||
const objectMetadataItem = objectMetadata.objectMetadataItem;
|
||||
|
||||
const objectLabelSingular = objectMetadataItem.labelSingular;
|
||||
@@ -164,13 +157,11 @@ export const SettingsRolePermissionsObjectLevelObjectForm = ({
|
||||
objectMetadataItem={objectMetadataItem}
|
||||
roleId={roleId}
|
||||
/>
|
||||
{isRowLevelPermissionPredicatesEnabled && (
|
||||
<SettingsRolePermissionsObjectLevelRecordLevelSection
|
||||
objectMetadataItem={objectMetadataItem}
|
||||
roleId={roleId}
|
||||
hasOrganizationPlan={isRLSBillingEntitlementEnabled}
|
||||
/>
|
||||
)}
|
||||
<SettingsRolePermissionsObjectLevelRecordLevelSection
|
||||
objectMetadataItem={objectMetadataItem}
|
||||
roleId={roleId}
|
||||
hasOrganizationPlan={isRLSBillingEntitlementEnabled}
|
||||
/>
|
||||
</SettingsPageContainer>
|
||||
</SubMenuTopBarContainer>
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user