Revert the external link confirmation popup for front components (#23567)
Reverts #23270 and #23404. Links in front components navigate natively again, with no confirmation popup and no per-app trusted-origins state in localStorage. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/23567?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->
This commit is contained in:
+4
-12
@@ -1,7 +1,5 @@
|
||||
import { ROOT_CONTAINER_STYLE } from '@/host/constants/RootContainerStyle';
|
||||
import { FrontComponentExternalNavigationContext } from '@/host/contexts/FrontComponentExternalNavigationContext';
|
||||
import { FrontComponentGeometryTrackerContext } from '@/host/contexts/FrontComponentGeometryTrackerContext';
|
||||
import { type RequestExternalNavigation } from '@/host/types/RequestExternalNavigation';
|
||||
import { createGeometryTracker } from '@/host/utils/createGeometryTracker';
|
||||
import { FrontComponentConfirmationModalResultEffect } from '@/remote/components/FrontComponentConfirmationModalResultEffect';
|
||||
import { FrontComponentErrorEffect } from '@/remote/components/FrontComponentErrorEffect';
|
||||
@@ -39,7 +37,6 @@ type FrontComponentRendererProps = {
|
||||
applicationVariables?: Record<string, string>;
|
||||
executionContext: FrontComponentExecutionContext;
|
||||
frontComponentHostCommunicationApi: FrontComponentHostCommunicationApi;
|
||||
onRequestExternalNavigation?: RequestExternalNavigation;
|
||||
onError: (error?: Error) => void;
|
||||
colorScheme: 'light' | 'dark';
|
||||
loadingFallback?: ReactNode;
|
||||
@@ -54,7 +51,6 @@ export const FrontComponentRenderer = ({
|
||||
applicationVariables,
|
||||
executionContext,
|
||||
frontComponentHostCommunicationApi,
|
||||
onRequestExternalNavigation,
|
||||
onError,
|
||||
colorScheme,
|
||||
loadingFallback,
|
||||
@@ -131,14 +127,10 @@ export const FrontComponentRenderer = ({
|
||||
resetKeys={[componentUrl]}
|
||||
fallbackRender={() => null}
|
||||
>
|
||||
<FrontComponentExternalNavigationContext.Provider
|
||||
value={onRequestExternalNavigation ?? null}
|
||||
>
|
||||
<RemoteRootRenderer
|
||||
receiver={receiver}
|
||||
components={fallbackComponentRegistry}
|
||||
/>
|
||||
</FrontComponentExternalNavigationContext.Provider>
|
||||
<RemoteRootRenderer
|
||||
receiver={receiver}
|
||||
components={fallbackComponentRegistry}
|
||||
/>
|
||||
</ErrorBoundary>
|
||||
</ThemeProvider>
|
||||
)}
|
||||
|
||||
Reference in New Issue
Block a user