diff --git a/nx.json b/nx.json index 1a15975922..bb94a73d3b 100644 --- a/nx.json +++ b/nx.json @@ -133,7 +133,7 @@ "outputs": ["{projectRoot}/{options.output-dir}"], "options": { "cwd": "{projectRoot}", - "command": "VITE_DISABLE_TYPESCRIPT_CHECKER=true VITE_DISABLE_ESLINT_CHECKER=true storybook build --test", + "command": "VITE_DISABLE_TYPESCRIPT_CHECKER=true storybook build --test", "output-dir": "storybook-static", "config-dir": ".storybook" }, diff --git a/packages/twenty-docs/developers/self-hosting/troubleshooting.mdx b/packages/twenty-docs/developers/self-hosting/troubleshooting.mdx index bf03e84dcf..ea763fde3a 100644 --- a/packages/twenty-docs/developers/self-hosting/troubleshooting.mdx +++ b/packages/twenty-docs/developers/self-hosting/troubleshooting.mdx @@ -69,7 +69,7 @@ This should work out of the box with the eslint extension installed. If this doe #### While running `npx nx start` or `npx nx start twenty-front`, Out of memory error is thrown -In `packages/twenty-front/.env` uncomment `VITE_DISABLE_TYPESCRIPT_CHECKER=true` and `VITE_DISABLE_ESLINT_CHECKER=true` to disable background checks thus reducing amount of needed RAM. +In `packages/twenty-front/.env` uncomment `VITE_DISABLE_TYPESCRIPT_CHECKER=true` to disable background checks thus reducing amount of needed RAM. **If it does not work:** Run only the services you need, instead of `npx nx start`. For instance, if you work on the server, run only `npx nx worker twenty-server` diff --git a/packages/twenty-front/.env.example b/packages/twenty-front/.env.example index 755698a121..f7e35a852f 100644 --- a/packages/twenty-front/.env.example +++ b/packages/twenty-front/.env.example @@ -1,13 +1,11 @@ REACT_APP_SERVER_BASE_URL=http://localhost:3000 VITE_BUILD_SOURCEMAP=false -VITE_DISABLE_ESLINT_CHECKER=true # ———————— Optional ———————— # REACT_APP_PORT=3001 # CHROMATIC_PROJECT_TOKEN= # VITE_DISABLE_TYPESCRIPT_CHECKER=true -# VITE_DISABLE_ESLINT_CHECKER=true # VITE_ENABLE_SSL=false # VITE_HOST=localhost.com # SSL_KEY_PATH="./certs/your-cert.key" diff --git a/packages/twenty-front/package.json b/packages/twenty-front/package.json index c823c4f10e..6d834ac01f 100644 --- a/packages/twenty-front/package.json +++ b/packages/twenty-front/package.json @@ -3,8 +3,8 @@ "private": true, "type": "module", "scripts": { - "build": "NODE_ENV=production VITE_DISABLE_TYPESCRIPT_CHECKER=true VITE_DISABLE_ESLINT_CHECKER=true NODE_OPTIONS=--max-old-space-size=8192 npx vite build && sh ./scripts/inject-runtime-env.sh", - "build:sourcemaps": "NODE_ENV=production VITE_BUILD_SOURCEMAP=true VITE_DISABLE_TYPESCRIPT_CHECKER=true VITE_DISABLE_ESLINT_CHECKER=true NODE_OPTIONS=--max-old-space-size=8192 npx vite build && sh ./scripts/inject-runtime-env.sh", + "build": "NODE_ENV=production VITE_DISABLE_TYPESCRIPT_CHECKER=true NODE_OPTIONS=--max-old-space-size=8192 npx vite build && sh ./scripts/inject-runtime-env.sh", + "build:sourcemaps": "NODE_ENV=production VITE_BUILD_SOURCEMAP=true VITE_DISABLE_TYPESCRIPT_CHECKER=true NODE_OPTIONS=--max-old-space-size=8192 npx vite build && sh ./scripts/inject-runtime-env.sh", "start:prod": "NODE_ENV=production npx serve -s build", "tsup": "npx tsup" }, diff --git a/packages/twenty-front/vite.config.ts b/packages/twenty-front/vite.config.ts index dbde1d1ce9..8c9d03d50c 100644 --- a/packages/twenty-front/vite.config.ts +++ b/packages/twenty-front/vite.config.ts @@ -24,7 +24,6 @@ export default defineConfig(({ command, mode }) => { REACT_APP_SERVER_BASE_URL, VITE_BUILD_SOURCEMAP, VITE_DISABLE_TYPESCRIPT_CHECKER, - VITE_DISABLE_ESLINT_CHECKER, VITE_HOST, SSL_CERT_PATH, SSL_KEY_PATH, @@ -59,10 +58,6 @@ export default defineConfig(({ command, mode }) => { ); } - if (VITE_DISABLE_ESLINT_CHECKER === 'true') { - console.log(`VITE_DISABLE_ESLINT_CHECKER: ${VITE_DISABLE_ESLINT_CHECKER}`); - } - if (VITE_BUILD_SOURCEMAP === 'true') { console.log(`VITE_BUILD_SOURCEMAP: ${VITE_BUILD_SOURCEMAP}`); } @@ -73,13 +68,6 @@ export default defineConfig(({ command, mode }) => { }; } - if (VITE_DISABLE_ESLINT_CHECKER !== 'true') { - checkers['eslint'] = { - lintCommand: 'eslint ../../packages/twenty-front --max-warnings 0', - useFlatConfig: true, - }; - } - return { root: __dirname, cacheDir: '../../node_modules/.vite/packages/twenty-front',