Remove viewGroup.fieldMetadataId (#16571)

Final step of
https://github.com/orgs/twentyhq/projects/1/views/8?pane=issue&itemId=142348748&issue=twentyhq%7Ccore-team-issues%7C1965

Removing viewGroup.fieldMetadataId.
It's already not used in FE anymore

packages/twenty-server/src/database/commands/upgrade-version-command/1-13/1-13-backfill-view-main-group-by-field-metadata-id.command.ts

@@ -1,210 +0,0 @@
-import { InjectRepository } from '@nestjs/typeorm';
-
-import { Command } from 'nest-commander';
-import { isDefined } from 'twenty-shared/utils';
-import { In, IsNull, Not, Repository } from 'typeorm';
-
-import { ActiveOrSuspendedWorkspacesMigrationCommandRunner } from 'src/database/commands/command-runners/active-or-suspended-workspaces-migration.command-runner';
-import { MigrationCommandOptions } from 'src/database/commands/command-runners/migration.command-runner';
-import { RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspaces-migration.command-runner';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { DataSourceService } from 'src/engine/metadata-modules/data-source/data-source.service';
-import { ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
-import { ViewEntity } from 'src/engine/metadata-modules/view/entities/view.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-
-@Command({
-  name: 'upgrade:1-13:backfill:view-main-group-by-field-metadata-id',
-  description:
-    'Backfill mainGroupByFieldMetadataId on views and clean up inconsistent viewGroups',
-})
-export class BackfillViewMainGroupByFieldMetadataIdCommand extends ActiveOrSuspendedWorkspacesMigrationCommandRunner {
-  constructor(
-    @InjectRepository(ViewEntity)
-    private readonly viewRepository: Repository<ViewEntity>,
-    @InjectRepository(ViewGroupEntity)
-    private readonly viewGroupRepository: Repository<ViewGroupEntity>,
-    @InjectRepository(WorkspaceEntity)
-    protected readonly workspaceRepository: Repository<WorkspaceEntity>,
-    protected readonly twentyORMGlobalManager: GlobalWorkspaceOrmManager,
-    protected readonly dataSourceService: DataSourceService,
-  ) {
-    super(workspaceRepository, twentyORMGlobalManager, dataSourceService);
-  }
-
-  override async runOnWorkspace({
-    workspaceId,
-    options,
-  }: RunOnWorkspaceArgs): Promise<void> {
-    await this.backfillMainGroupByFieldMetadataId(workspaceId, options);
-    await this.cleanupInconsistentViewGroups(workspaceId, options);
-  }
-
-  private async backfillMainGroupByFieldMetadataId(
-    workspaceId: string,
-    options: MigrationCommandOptions,
-  ): Promise<void> {
-    this.logger.log(
-      `Starting backfill of mainGroupByFieldMetadataId for workspace ${workspaceId}...`,
-    );
-
-    const viewsToBackfill = await this.viewRepository.find({
-      where: {
-        mainGroupByFieldMetadataId: IsNull(),
-        workspaceId,
-      },
-      select: ['id', 'workspaceId'],
-    });
-
-    this.logger.log(
-      `Found ${viewsToBackfill.length} views with null mainGroupByFieldMetadataId`,
-    );
-
-    let backfilledCount = 0;
-    let inconsistentViewsCount = 0;
-
-    for (const view of viewsToBackfill) {
-      const nonDeletedViewGroups = await this.viewGroupRepository.find({
-        where: {
-          viewId: view.id,
-          deletedAt: IsNull(),
-          workspaceId,
-        },
-        select: ['id', 'fieldMetadataId'],
-      });
-
-      if (nonDeletedViewGroups.length === 0) {
-        continue;
-      }
-
-      const uniqueFieldMetadataIds = [
-        ...new Set(nonDeletedViewGroups.map((vg) => vg.fieldMetadataId)),
-      ];
-
-      if (uniqueFieldMetadataIds.length === 1) {
-        const fieldMetadataId = uniqueFieldMetadataIds[0];
-
-        if (options.dryRun) {
-          this.logger.log(
-            `[DRY RUN] Would backfill view ${view.id} (workspace ${view.workspaceId}) with fieldMetadataId ${fieldMetadataId}`,
-          );
-        } else {
-          await this.viewRepository.update(
-            { id: view.id, workspaceId },
-            { mainGroupByFieldMetadataId: fieldMetadataId },
-          );
-          this.logger.log(
-            `Backfilled view ${view.id} (workspace ${view.workspaceId}) with fieldMetadataId ${fieldMetadataId}`,
-          );
-        }
-        backfilledCount++;
-      } else {
-        this.logger.error(
-          `Inconsistency detected for view ${view.id} (workspace ${view.workspaceId}): found ${uniqueFieldMetadataIds.length} different fieldMetadataIds`,
-        );
-
-        const fieldMetadataIdCounts = new Map<string, number>();
-
-        for (const vg of nonDeletedViewGroups) {
-          const count = fieldMetadataIdCounts.get(vg.fieldMetadataId) || 0;
-
-          fieldMetadataIdCounts.set(vg.fieldMetadataId, count + 1);
-        }
-
-        let mostNumerousFieldMetadataId = '';
-        let maxCount = 0;
-
-        for (const [
-          fieldMetadataId,
-          count,
-        ] of fieldMetadataIdCounts.entries()) {
-          if (count > maxCount) {
-            maxCount = count;
-            mostNumerousFieldMetadataId = fieldMetadataId;
-          }
-        }
-
-        if (options.dryRun) {
-          this.logger.log(
-            `[DRY RUN] Would backfill view ${view.id} (workspace ${view.workspaceId}) with fieldMetadataId ${mostNumerousFieldMetadataId} (most numerous, found ${maxCount} occurrences)`,
-          );
-        } else {
-          await this.viewRepository.update(
-            { id: view.id },
-            { mainGroupByFieldMetadataId: mostNumerousFieldMetadataId },
-          );
-          this.logger.log(
-            `Backfilled view ${view.id} (workspace ${view.workspaceId}) with fieldMetadataId ${mostNumerousFieldMetadataId} (most numerous, found ${maxCount} occurrences)`,
-          );
-        }
-        backfilledCount++;
-        inconsistentViewsCount++;
-      }
-    }
-
-    this.logger.log(
-      `${options.dryRun ? '[DRY RUN] Would have ' : ''}Backfilled ${backfilledCount} views${inconsistentViewsCount > 0 ? ` (${inconsistentViewsCount} with inconsistencies)` : ''}`,
-    );
-  }
-
-  private async cleanupInconsistentViewGroups(
-    workspaceId: string,
-    options: MigrationCommandOptions,
-  ): Promise<void> {
-    this.logger.log('Starting cleanup of inconsistent viewGroups...');
-
-    const viewsWithMainGroupBy = await this.viewRepository.find({
-      where: {
-        mainGroupByFieldMetadataId: Not(IsNull()),
-        workspaceId,
-      },
-      select: ['id', 'mainGroupByFieldMetadataId'],
-    });
-
-    this.logger.log(
-      `Found ${viewsWithMainGroupBy.length} views with mainGroupByFieldMetadataId set`,
-    );
-
-    let totalDeletedCount = 0;
-
-    for (const view of viewsWithMainGroupBy) {
-      if (!isDefined(view.mainGroupByFieldMetadataId)) {
-        continue;
-      }
-
-      const inconsistentViewGroups = await this.viewGroupRepository.find({
-        where: {
-          viewId: view.id,
-          fieldMetadataId: Not(view.mainGroupByFieldMetadataId),
-          workspaceId,
-        },
-        select: ['id'],
-      });
-
-      if (inconsistentViewGroups.length === 0) {
-        continue;
-      }
-
-      const viewGroupIds = inconsistentViewGroups.map((vg) => vg.id);
-
-      if (options.dryRun) {
-        this.logger.log(
-          `[DRY RUN] Would delete ${inconsistentViewGroups.length} viewGroups from view ${view.id}`,
-        );
-      } else {
-        await this.viewGroupRepository.delete({
-          id: In(viewGroupIds),
-          workspaceId,
-        });
-        this.logger.log(
-          `Deleted ${inconsistentViewGroups.length} viewGroups from view ${view.id}`,
-        );
-      }
-      totalDeletedCount += inconsistentViewGroups.length;
-    }
-
-    this.logger.log(
-      `${options.dryRun ? '[DRY RUN] Would have ' : ''}Deleted ${totalDeletedCount} inconsistent viewGroups`,
-    );
-  }
-}

packages/twenty-server/src/database/commands/upgrade-version-command/1-13/1-13-upgrade-version-command.module.ts

@@ -2,7 +2,6 @@ import { Module } from '@nestjs/common';
 import { TypeOrmModule } from '@nestjs/typeorm';
 
 import { BackfillPageLayoutUniversalIdentifiersCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-backfill-page-layout-universal-identifiers.command';
-import { BackfillViewMainGroupByFieldMetadataIdCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-backfill-view-main-group-by-field-metadata-id.command';
 import { CleanEmptyStringNullInTextFieldsCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-clean-empty-string-null-in-text-fields.command';
 import { DeduplicateRoleTargetsCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-deduplicate-role-targets.command';
 import { MigrateStandardInvalidEntitiesCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-migrate-standard-invalid-entities.command';
@@ -59,7 +58,6 @@ import { TimelineActivityWorkspaceEntity } from 'src/modules/timeline/standard-o
   ],
   providers: [
     CleanEmptyStringNullInTextFieldsCommand,
-    BackfillViewMainGroupByFieldMetadataIdCommand,
     BackfillPageLayoutUniversalIdentifiersCommand,
     DeduplicateRoleTargetsCommand,
     RenameIndexNameCommand,
@@ -69,7 +67,6 @@ import { TimelineActivityWorkspaceEntity } from 'src/modules/timeline/standard-o
   ],
   exports: [
     CleanEmptyStringNullInTextFieldsCommand,
-    BackfillViewMainGroupByFieldMetadataIdCommand,
     BackfillPageLayoutUniversalIdentifiersCommand,
     DeduplicateRoleTargetsCommand,
     RenameIndexNameCommand,

packages/twenty-server/src/database/commands/upgrade-version-command/upgrade.command.ts

@@ -10,7 +10,6 @@ import {
   type VersionCommands,
 } from 'src/database/commands/command-runners/upgrade.command-runner';
 import { BackfillPageLayoutUniversalIdentifiersCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-backfill-page-layout-universal-identifiers.command';
-import { BackfillViewMainGroupByFieldMetadataIdCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-backfill-view-main-group-by-field-metadata-id.command';
 import { CleanEmptyStringNullInTextFieldsCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-clean-empty-string-null-in-text-fields.command';
 import { DeduplicateRoleTargetsCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-deduplicate-role-targets.command';
 import { MigrateStandardInvalidEntitiesCommand } from 'src/database/commands/upgrade-version-command/1-13/1-13-migrate-standard-invalid-entities.command';
@@ -43,7 +42,6 @@ export class UpgradeCommand extends UpgradeCommandRunner {
     protected readonly updateRoleTargetsUniqueConstraintMigrationCommand: UpdateRoleTargetsUniqueConstraintMigrationCommand,
     protected readonly backfillPageLayoutUniversalIdentifiersCommand: BackfillPageLayoutUniversalIdentifiersCommand,
     protected readonly migrateStandardInvalidEntitiesCommand: MigrateStandardInvalidEntitiesCommand,
-    protected readonly backfillViewMainGroupByFieldMetadataIdCommand: BackfillViewMainGroupByFieldMetadataIdCommand,
     protected readonly cleanEmptyStringNullInTextFieldsCommand: CleanEmptyStringNullInTextFieldsCommand,
     protected readonly renameIndexNameCommand: RenameIndexNameCommand,
 
@@ -66,7 +64,6 @@ export class UpgradeCommand extends UpgradeCommandRunner {
       this.updateRoleTargetsUniqueConstraintMigrationCommand,
       this.backfillPageLayoutUniversalIdentifiersCommand,
       this.migrateStandardInvalidEntitiesCommand,
-      this.backfillViewMainGroupByFieldMetadataIdCommand,
       this.cleanEmptyStringNullInTextFieldsCommand,
       this.renameIndexNameCommand,
     ];