Prevent leak between /metadata and /graphql GQL schemas (#17845)
## Fix resolver schema leaking between `/metadata` and `/graphql` endpoints ### Summary - Patch `@nestjs/graphql` to support a `resolverSchemaScope` option that filters resolvers at both schema generation and runtime, preventing cross-endpoint leaking - Introduce `@CoreResolver()` and `@MetadataResolver()` decorators to explicitly scope each resolver to its endpoint - Move most resolvers (auth, billing, workspace, user, etc.) to the metadata schema where the frontend expects them; only workflow and timeline calendar/messaging resolvers remain on `/graphql` - Fix frontend `SSEQuerySubscribeEffect` to use the default (metadata) Apollo client instead of the core client ### Problem NestJS GraphQL's module-based resolver discovery traverses transitive imports, causing resolvers from `/metadata` modules to leak into the `/graphql` schema and vice versa. This made the schemas unpredictable and tightly coupled to module import order. ### Approach - Added `resolverSchemaScope` to `GqlModuleOptions` via a patch on `@nestjs/graphql`, filtering in both `filterResolvers()` (runtime binding) and `getAllCtors()` (schema generation) - Each resolver is explicitly decorated with `@CoreResolver()` or `@MetadataResolver()` - Organized decorator, constant, and type files under `graphql-config/` following project conventions Core GQL Schema: (see: no more fields!) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/668f3f0f-485e-43f0-92be-4345aeccacb6" /> Metadata GQL Schema (see no more getTimelineCalendarEventsFromCompany) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/443913db-e5fe-4161-b0e7-4a971cc80a71" />
This commit is contained in:
+3
-6
@@ -1,4 +1,3 @@
|
||||
import { useApolloCoreClient } from '@/object-metadata/hooks/useApolloCoreClient';
|
||||
import { ADD_QUERY_TO_EVENT_STREAM_MUTATION } from '@/sse-db-event/graphql/mutations/AddQueryToEventStreamMutation';
|
||||
import { REMOVE_QUERY_FROM_EVENT_STREAM_MUTATION } from '@/sse-db-event/graphql/mutations/RemoveQueryFromEventStreamMutation';
|
||||
import { activeQueryListenersState } from '@/sse-db-event/states/activeQueryListenersState';
|
||||
@@ -18,22 +17,20 @@ import { useDebouncedCallback } from 'use-debounce';
|
||||
import {
|
||||
type AddQuerySubscriptionInput,
|
||||
type RemoveQueryFromEventStreamInput,
|
||||
} from '~/generated/graphql';
|
||||
} from '~/generated-metadata/graphql';
|
||||
|
||||
export const SSEQuerySubscribeEffect = () => {
|
||||
const sseEventStreamId = useRecoilValue(sseEventStreamIdState);
|
||||
|
||||
const apolloCoreClient = useApolloCoreClient();
|
||||
|
||||
const [addQueryToEventStream] = useMutation<
|
||||
boolean,
|
||||
{ input: AddQuerySubscriptionInput }
|
||||
>(ADD_QUERY_TO_EVENT_STREAM_MUTATION, { client: apolloCoreClient });
|
||||
>(ADD_QUERY_TO_EVENT_STREAM_MUTATION);
|
||||
|
||||
const [removeQueryFromEventStream] = useMutation<
|
||||
void,
|
||||
{ input: RemoveQueryFromEventStreamInput }
|
||||
>(REMOVE_QUERY_FROM_EVENT_STREAM_MUTATION, { client: apolloCoreClient });
|
||||
>(REMOVE_QUERY_FROM_EVENT_STREAM_MUTATION);
|
||||
|
||||
const requiredQueryListeners = useRecoilValue(requiredQueryListenersState);
|
||||
const activeQueryListeners = useRecoilValue(activeQueryListenersState);
|
||||
|
||||
Reference in New Issue
Block a user