Migrate from ESLint to OxLint (#18443)

## Summary

Fully replaces ESLint with OxLint across the entire monorepo:

- **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint
configs (`.oxlintrc.json`) for every package: `twenty-front`,
`twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`,
`twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`,
`twenty-apps/*`, `create-twenty-app`
- **Migrated custom lint rules** from ESLint plugin format to OxLint JS
plugin system (`@oxlint/plugins`), including
`styled-components-prefixed-with-styled`, `no-hardcoded-colors`,
`sort-css-properties-alphabetically`,
`graphql-resolvers-should-be-guarded`,
`rest-api-methods-should-be-guarded`, `max-consts-per-file`, and
Jotai-related rules
- **Migrated custom rule tests** from ESLint `RuleTester` + Jest to
`oxlint/plugins-dev` `RuleTester` + Vitest
- **Removed all ESLint dependencies** from `package.json` files and
regenerated lockfiles
- **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in
`nx.json` and per-project `project.json` to use `oxlint` commands with
proper `dependsOn` for plugin builds
- **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more
ESLint executor
- **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with
`oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and
format-on-save with Prettier
- **Replaced all `eslint-disable` comments** with `oxlint-disable`
equivalents across the codebase
- **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint
- **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules`

### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`)

| Rule | Package | Violations | Auto-fixable |
|------|---------|-----------|-------------|
| `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes
|
| `typescript/consistent-type-imports` | twenty-server | 3814 | Yes |
| `twenty/max-consts-per-file` | twenty-server | 94 | No |

### Dropped plugins (no OxLint equivalent)

`eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`,
`import/order`, `prefer-arrow/prefer-arrow-functions`,
`eslint-plugin-mdx`, `@next/eslint-plugin-next`,
`eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial
coverage for `jsx-a11y` and `unused-imports`.

### Additional fixes (pre-existing issues exposed by merge)

- Fixed `EmailThreadPreview.tsx` broken import from main rename
(`useOpenEmailThreadInSidePanel`)
- Restored truthiness guard in `getActivityTargetObjectRecords.ts`
- Fixed `AgentTurnResolver` return types to match entity (virtual
`fileMediaType`/`fileUrl` are resolved via `@ResolveField()`)

## Test plan

- [x] `npx nx lint twenty-front` passes
- [x] `npx nx lint twenty-server` passes
- [x] `npx nx lint twenty-docs` passes
- [x] Custom oxlint rules validated with Vitest: `npx nx test
twenty-oxlint-rules`
- [x] `npx nx typecheck twenty-front` passes
- [x] `npx nx typecheck twenty-server` passes
- [x] CI workflows trigger correctly with `dependsOn:
["twenty-oxlint-rules:build"]`
- [x] IDE linting works with `oxc.oxc-vscode` extension
This commit is contained in:
Charles Bochet
2026-03-06 01:03:50 +01:00
committed by GitHub
parent b421efbff7
commit 9d57bc39e5
880 changed files with 4711 additions and 9687 deletions
@@ -4,6 +4,7 @@ import { useStartNodeCreation } from '@/workflow/workflow-diagram/hooks/useStart
import { type WorkflowDiagramStepNodeData } from '@/workflow/workflow-diagram/types/WorkflowDiagram';
import { styled } from '@linaria/react';
import { t } from '@lingui/core/macro';
import { isDefined } from 'twenty-shared/utils';
import { IconPlus } from 'twenty-ui/display';
import { IconButton } from 'twenty-ui/input';
@@ -53,7 +54,7 @@ export const WorkflowDiagramCreateStepElement = ({
<WorkflowDiagramConnector />
</StyledVerticalLineContainer>
{Label && <StyledLabelContainer>{Label}</StyledLabelContainer>}
{isDefined(Label) && <StyledLabelContainer>{Label}</StyledLabelContainer>}
<IconButton
Icon={IconPlus}
@@ -72,7 +72,7 @@ export const WorkflowDiagramHandleSource = ({
const dynamicStyles = useMemo(() => {
const isRight = position === Position.Right;
const transform = isRight ? 'translate(50%, -50%)' : 'translate(-50%, 50%)';
// eslint-disable-next-line lingui/no-unlocalized-strings
// oxlint-disable-next-line lingui/no-unlocalized-strings
const transformOrigin = isRight ? 'top right' : 'bottom left';
let bg: string;
@@ -116,7 +116,7 @@ export const WorkflowStepFilterValueInput = ({
const isDisabled = !stepFilter.operand;
const operandHasNoInput =
(stepFilter && !configurableViewFilterOperands.has(stepFilter.operand)) ??
(isDefined(stepFilter) && !configurableViewFilterOperands.has(stepFilter.operand)) ??
true;
const {
@@ -144,7 +144,7 @@ export const WorkflowEditTriggerDatabaseEventForm = ({
...trigger,
settings: {
...trigger.settings,
fields: fields ? (Array.isArray(fields) ? fields : [fields]) : null,
fields: isDefined(fields) ? (Array.isArray(fields) ? fields : [fields]) : null,
},
});
};
@@ -1,3 +1,4 @@
import { isDefined } from 'twenty-shared/utils';
import { useFilteredObjectMetadataItems } from '@/object-metadata/hooks/useFilteredObjectMetadataItems';
import { IconPicker } from '@/ui/input/components/IconPicker';
import { Select } from '@/ui/input/components/Select';
@@ -120,7 +121,7 @@ export const WorkflowEditTriggerManual = ({
options={availableMetadata}
disabled={triggerOptions.readonly}
onChange={(objectNameSingular) => {
if (triggerOptions.readonly === true || !availability) {
if (triggerOptions.readonly === true || !isDefined(availability)) {
return;
}
@@ -7,7 +7,7 @@ import { type OutputSchemaV2 } from '@/workflow/workflow-variables/types/StepOut
export const isCodeOutputSchema = (
stepType: WorkflowActionType | WorkflowTriggerType,
schema: OutputSchemaV2,
): schema is CodeOutputSchema => {
_schema: OutputSchemaV2,
): _schema is CodeOutputSchema => {
return stepType === 'CODE';
};
@@ -7,7 +7,7 @@ import { type OutputSchemaV2 } from '@/workflow/workflow-variables/types/StepOut
export const isDatabaseEventTriggerOutputSchema = (
stepType: WorkflowActionType | WorkflowTriggerType,
schema: OutputSchemaV2,
): schema is DatabaseEventTriggerOutputSchema => {
_schema: OutputSchemaV2,
): _schema is DatabaseEventTriggerOutputSchema => {
return stepType === 'DATABASE_EVENT';
};
@@ -7,7 +7,7 @@ import { type OutputSchemaV2 } from '@/workflow/workflow-variables/types/StepOut
export const isFindRecordsOutputSchema = (
stepType: WorkflowActionType | WorkflowTriggerType,
schema: OutputSchemaV2,
): schema is FindRecordsOutputSchema => {
_schema: OutputSchemaV2,
): _schema is FindRecordsOutputSchema => {
return stepType === 'FIND_RECORDS';
};
@@ -7,7 +7,7 @@ import { type OutputSchemaV2 } from '@/workflow/workflow-variables/types/StepOut
export const isFormOutputSchema = (
stepType: WorkflowActionType | WorkflowTriggerType,
schema: OutputSchemaV2,
): schema is FormOutputSchema => {
_schema: OutputSchemaV2,
): _schema is FormOutputSchema => {
return stepType === 'FORM';
};
@@ -7,7 +7,7 @@ import { type IteratorOutputSchema } from '@/workflow/workflow-variables/types/I
export const isIteratorOutputSchema = (
stepType: WorkflowActionType | WorkflowTriggerType,
schema: OutputSchemaV2,
): schema is IteratorOutputSchema => {
_schema: OutputSchemaV2,
): _schema is IteratorOutputSchema => {
return stepType === 'ITERATOR';
};
@@ -7,7 +7,7 @@ import { type OutputSchemaV2 } from '@/workflow/workflow-variables/types/StepOut
export const isManualTriggerOutputSchema = (
stepType: WorkflowActionType | WorkflowTriggerType,
schema: OutputSchemaV2,
): schema is ManualTriggerOutputSchema => {
_schema: OutputSchemaV2,
): _schema is ManualTriggerOutputSchema => {
return stepType === 'MANUAL';
};
@@ -14,7 +14,7 @@ const RECORD_STEP_TYPES = [
export const isRecordStepOutputSchema = (
stepType: WorkflowActionType | WorkflowTriggerType,
schema: OutputSchemaV2,
): schema is RecordActionOutputSchema => {
_schema: OutputSchemaV2,
): _schema is RecordActionOutputSchema => {
return RECORD_STEP_TYPES.includes(stepType);
};