Migrate from ESLint to OxLint (#18443)
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
This commit is contained in:
+3
-2
@@ -4,6 +4,7 @@ import { type ReactNode } from 'react';
|
||||
import { StyledFormCardTitle } from '@/settings/data-model/fields/components/StyledFormCardTitle';
|
||||
import { Trans } from '@lingui/react/macro';
|
||||
import { Card, CardContent } from 'twenty-ui/layout';
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { themeCssVariables } from 'twenty-ui/theme-constants';
|
||||
|
||||
type SettingsDataModelPreviewFormCardProps = {
|
||||
@@ -32,14 +33,14 @@ export const SettingsDataModelPreviewFormCard = ({
|
||||
}: SettingsDataModelPreviewFormCardProps) => (
|
||||
<Card className={className} fullWidth rounded>
|
||||
<StyledPreviewContainerWrapper>
|
||||
<CardContent divider={!!form}>
|
||||
<CardContent divider={isDefined(form)}>
|
||||
<StyledFormCardTitle>
|
||||
<Trans>Preview</Trans>
|
||||
</StyledFormCardTitle>
|
||||
{preview}
|
||||
</CardContent>
|
||||
</StyledPreviewContainerWrapper>
|
||||
{!!form && (
|
||||
{isDefined(form) && (
|
||||
<StyledFormContainerWrapper>
|
||||
<CardContent>{form}</CardContent>
|
||||
</StyledFormContainerWrapper>
|
||||
|
||||
+2
-1
@@ -1,3 +1,4 @@
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
|
||||
import { type FieldPhonesValue } from '@/object-record/record-field/ui/types/FieldMetadata';
|
||||
import { getSettingsFieldTypeConfig } from '@/settings/data-model/utils/getSettingsFieldTypeConfig';
|
||||
@@ -20,7 +21,7 @@ export const countryCodeToCallingCode = (countryCode: string): string => {
|
||||
|
||||
const callingCode = getCountryCallingCode(countryCode);
|
||||
|
||||
return callingCode ? `+${callingCode}` : '';
|
||||
return isDefined(callingCode) ? `+${callingCode}` : '';
|
||||
};
|
||||
|
||||
export const getPhonesFieldPreviewValue = ({
|
||||
|
||||
+2
-1
@@ -1,3 +1,4 @@
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { styled } from '@linaria/react';
|
||||
import { Handle, Position } from '@xyflow/react';
|
||||
import { objectMetadataItemsState } from '@/object-metadata/states/objectMetadataItemsState';
|
||||
@@ -40,7 +41,7 @@ export const ObjectFieldRow = ({ field }: ObjectFieldRowProps) => {
|
||||
|
||||
return (
|
||||
<StyledRow>
|
||||
{Icon && <Icon size={theme.icon.size.md} />}
|
||||
{isDefined(Icon) && <Icon size={theme.icon.size.md} />}
|
||||
<StyledFieldName>{relatedObject?.labelPlural ?? ''}</StyledFieldName>
|
||||
<Handle
|
||||
type={
|
||||
|
||||
+2
-1
@@ -1,3 +1,4 @@
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { styled } from '@linaria/react';
|
||||
|
||||
import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
|
||||
@@ -32,7 +33,7 @@ export const ObjectFieldRowWithoutRelation = ({
|
||||
|
||||
return (
|
||||
<StyledRow>
|
||||
{Icon && <Icon size={theme.icon.size.md} />}
|
||||
{isDefined(Icon) && <Icon size={theme.icon.size.md} />}
|
||||
<StyledFieldName>{field.label}</StyledFieldName>
|
||||
</StyledRow>
|
||||
);
|
||||
|
||||
+2
-2
@@ -12,7 +12,7 @@ import { FieldMetadataType } from '~/generated-metadata/graphql';
|
||||
import { ObjectFieldRowWithoutRelation } from '@/settings/data-model/graph-overview/components/SettingsDataModelOverviewFieldWithoutRelation';
|
||||
import '@xyflow/react/dist/style.css';
|
||||
import { SettingsPath } from 'twenty-shared/types';
|
||||
import { getSettingsPath } from 'twenty-shared/utils';
|
||||
import { isDefined, getSettingsPath } from 'twenty-shared/utils';
|
||||
import { IconChevronDown, IconChevronUp, useIcons } from 'twenty-ui/display';
|
||||
import { SettingsItemTypeTag } from '@/settings/components/SettingsItemTypeTag';
|
||||
import { ThemeContext, themeCssVariables } from 'twenty-ui/theme-constants';
|
||||
@@ -131,7 +131,7 @@ export const SettingsDataModelOverviewObject = ({
|
||||
objectNamePlural: objectMetadataItem.namePlural,
|
||||
})}
|
||||
>
|
||||
{Icon && <Icon size={theme.icon.size.md} />}
|
||||
{isDefined(Icon) && <Icon size={theme.icon.size.md} />}
|
||||
{objectMetadataItem.labelPlural}
|
||||
</Link>
|
||||
</StyledObjectLinkContainer>
|
||||
|
||||
+2
-1
@@ -1,3 +1,4 @@
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { type ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
|
||||
import { TableCell } from '@/ui/layout/table/components/TableCell';
|
||||
import { TableRow } from '@/ui/layout/table/components/TableRow';
|
||||
@@ -48,7 +49,7 @@ export const SettingsAvailableStandardObjectItemTableRow = ({
|
||||
color={themeCssVariables.font.color.primary}
|
||||
gap={themeCssVariables.spacing[2]}
|
||||
>
|
||||
{!!Icon && <Icon size={theme.icon.size.md} />}
|
||||
{isDefined(Icon) && <Icon size={theme.icon.size.md} />}
|
||||
{objectItem.labelPlural}
|
||||
</TableCell>
|
||||
<TableCell>
|
||||
|
||||
+2
-2
@@ -119,7 +119,7 @@ export const SettingsObjectFieldItemTableRow = ({
|
||||
fieldName: fieldMetadataItem.name,
|
||||
});
|
||||
|
||||
// eslint-disable-next-line twenty/no-navigate-prefer-link
|
||||
// oxlint-disable-next-line twenty/no-navigate-prefer-link
|
||||
const navigateToFieldEdit = () =>
|
||||
navigate(SettingsPath.ObjectFieldEdit, {
|
||||
objectNamePlural: objectMetadataItem.namePlural,
|
||||
@@ -177,7 +177,7 @@ export const SettingsObjectFieldItemTableRow = ({
|
||||
color={themeCssVariables.font.color.primary}
|
||||
gap={themeCssVariables.spacing[2]}
|
||||
>
|
||||
{!!Icon && (
|
||||
{isDefined(Icon) && (
|
||||
<Icon
|
||||
style={{
|
||||
minWidth: theme.icon.size.md,
|
||||
|
||||
+2
-1
@@ -1,3 +1,4 @@
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { type ReactNode, useContext } from 'react';
|
||||
import { styled } from '@linaria/react';
|
||||
import { useLingui } from '@lingui/react/macro';
|
||||
@@ -70,7 +71,7 @@ export const SettingsObjectMetadataItemTableRow = ({
|
||||
to={link}
|
||||
>
|
||||
<StyledNameTableCell>
|
||||
{!!Icon && (
|
||||
{isDefined(Icon) && (
|
||||
<Icon
|
||||
style={{
|
||||
minWidth: theme.icon.size.md,
|
||||
|
||||
+2
-2
@@ -12,7 +12,7 @@ export const StyledNameTableCell = (
|
||||
<TableCell
|
||||
color={themeCssVariables.font.color.primary}
|
||||
gap={themeCssVariables.spacing[2]}
|
||||
// eslint-disable-next-line react/jsx-props-no-spreading
|
||||
// oxlint-disable-next-line react/jsx-props-no-spreading
|
||||
{...props}
|
||||
/>
|
||||
);
|
||||
@@ -23,7 +23,7 @@ export const StyledActionTableCell = (
|
||||
<TableCell
|
||||
align="center"
|
||||
padding={`0 ${themeCssVariables.spacing[1]} 0 ${themeCssVariables.spacing[2]}`}
|
||||
// eslint-disable-next-line react/jsx-props-no-spreading
|
||||
// oxlint-disable-next-line react/jsx-props-no-spreading
|
||||
{...props}
|
||||
/>
|
||||
);
|
||||
|
||||
+3
-3
@@ -121,7 +121,7 @@ export const SettingsObjectRelationItemTableRow = ({
|
||||
fieldName: fieldMetadataItem.name,
|
||||
});
|
||||
|
||||
// eslint-disable-next-line twenty/no-navigate-prefer-link
|
||||
// oxlint-disable-next-line twenty/no-navigate-prefer-link
|
||||
const navigateToFieldEdit = () =>
|
||||
navigate(SettingsPath.ObjectFieldEdit, {
|
||||
objectNamePlural: objectMetadataItem.namePlural,
|
||||
@@ -149,7 +149,7 @@ export const SettingsObjectRelationItemTableRow = ({
|
||||
: undefined;
|
||||
|
||||
const targetObjectLabel =
|
||||
isRelatedObjectLinkable && relationObjectMetadataItem
|
||||
isRelatedObjectLinkable && isDefined(relationObjectMetadataItem)
|
||||
? relationObjectMetadataItem.labelPlural
|
||||
: fieldMetadataItem.label;
|
||||
|
||||
@@ -162,7 +162,7 @@ export const SettingsObjectRelationItemTableRow = ({
|
||||
color={themeCssVariables.font.color.primary}
|
||||
gap={themeCssVariables.spacing[2]}
|
||||
>
|
||||
{!!Icon && (
|
||||
{isDefined(Icon) && (
|
||||
<Icon
|
||||
style={{
|
||||
minWidth: theme.icon.size.md,
|
||||
|
||||
+1
-1
@@ -145,7 +145,7 @@ export const SettingsUpdateDataModelObjectAboutForm = ({
|
||||
};
|
||||
|
||||
return (
|
||||
// eslint-disable-next-line react/jsx-props-no-spreading
|
||||
// oxlint-disable-next-line react/jsx-props-no-spreading
|
||||
<FormProvider {...formConfig}>
|
||||
<SettingsDataModelObjectAboutForm
|
||||
onNewDirtyField={() => formConfig.handleSubmit(handleSave)()}
|
||||
|
||||
Reference in New Issue
Block a user