Migrate from ESLint to OxLint (#18443)

## Summary

Fully replaces ESLint with OxLint across the entire monorepo:

- **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint
configs (`.oxlintrc.json`) for every package: `twenty-front`,
`twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`,
`twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`,
`twenty-apps/*`, `create-twenty-app`
- **Migrated custom lint rules** from ESLint plugin format to OxLint JS
plugin system (`@oxlint/plugins`), including
`styled-components-prefixed-with-styled`, `no-hardcoded-colors`,
`sort-css-properties-alphabetically`,
`graphql-resolvers-should-be-guarded`,
`rest-api-methods-should-be-guarded`, `max-consts-per-file`, and
Jotai-related rules
- **Migrated custom rule tests** from ESLint `RuleTester` + Jest to
`oxlint/plugins-dev` `RuleTester` + Vitest
- **Removed all ESLint dependencies** from `package.json` files and
regenerated lockfiles
- **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in
`nx.json` and per-project `project.json` to use `oxlint` commands with
proper `dependsOn` for plugin builds
- **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more
ESLint executor
- **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with
`oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and
format-on-save with Prettier
- **Replaced all `eslint-disable` comments** with `oxlint-disable`
equivalents across the codebase
- **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint
- **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules`

### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`)

| Rule | Package | Violations | Auto-fixable |
|------|---------|-----------|-------------|
| `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes
|
| `typescript/consistent-type-imports` | twenty-server | 3814 | Yes |
| `twenty/max-consts-per-file` | twenty-server | 94 | No |

### Dropped plugins (no OxLint equivalent)

`eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`,
`import/order`, `prefer-arrow/prefer-arrow-functions`,
`eslint-plugin-mdx`, `@next/eslint-plugin-next`,
`eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial
coverage for `jsx-a11y` and `unused-imports`.

### Additional fixes (pre-existing issues exposed by merge)

- Fixed `EmailThreadPreview.tsx` broken import from main rename
(`useOpenEmailThreadInSidePanel`)
- Restored truthiness guard in `getActivityTargetObjectRecords.ts`
- Fixed `AgentTurnResolver` return types to match entity (virtual
`fileMediaType`/`fileUrl` are resolved via `@ResolveField()`)

## Test plan

- [x] `npx nx lint twenty-front` passes
- [x] `npx nx lint twenty-server` passes
- [x] `npx nx lint twenty-docs` passes
- [x] Custom oxlint rules validated with Vitest: `npx nx test
twenty-oxlint-rules`
- [x] `npx nx typecheck twenty-front` passes
- [x] `npx nx typecheck twenty-server` passes
- [x] CI workflows trigger correctly with `dependsOn:
["twenty-oxlint-rules:build"]`
- [x] IDE linting works with `oxc.oxc-vscode` extension
This commit is contained in:
Charles Bochet
2026-03-06 01:03:50 +01:00
committed by GitHub
parent b421efbff7
commit 9d57bc39e5
880 changed files with 4711 additions and 9687 deletions
@@ -5,6 +5,7 @@ import { t } from '@lingui/core/macro';
import { Card, CardContent } from 'twenty-ui/layout';
import { IconChevronRight } from 'twenty-ui/display';
import { Pill } from 'twenty-ui/components';
import { isDefined } from 'twenty-shared/utils';
import { ThemeContext, themeCssVariables } from 'twenty-ui/theme-constants';
type SettingsCardProps = {
@@ -113,7 +114,7 @@ export const SettingsCard = ({
{title}
{soon && <Pill label={t`Soon`} />}
</StyledTitle>
{Status && Status}
{isDefined(Status) && Status}
<StyledIconChevronRightContainer>
<IconChevronRight size={theme.icon.size.sm} />
</StyledIconChevronRightContainer>
@@ -46,7 +46,7 @@ export const SettingsDnsRecordsTable = ({
}: SettingsDnsRecordsTableProps) => {
const { copyToClipboard } = useCopyToClipboard();
if (!records || records.length === 0) {
if (records.length === 0) {
return null;
}
@@ -153,7 +153,7 @@ export const SettingsMorphRelationMultiSelect = ({
const { setSelectedItemId } = useSelectableList(dropdownId);
const handleDropdownOpen = () => {
if (selectedOptions && selectedOptions.length > 0 && !searchInputValue) {
if (selectedOptions.length > 0 && !searchInputValue) {
setSelectedItemId(selectedOptions[0].label);
}
};
@@ -11,6 +11,7 @@ import {
type IconComponent,
OverflowingTextWithTooltip,
} from 'twenty-ui/display';
import { isDefined } from 'twenty-shared/utils';
type SettingsOptionCardContentButtonProps = {
Icon?: IconComponent;
@@ -47,7 +48,7 @@ export const SettingsOptionCardContentButton = ({
</StyledSettingsCardDescription>
)}
</StyledSettingsCardTextContainer>
{Button && <StyledButtonContainer>{Button}</StyledButtonContainer>}
{isDefined(Button) && <StyledButtonContainer>{Button}</StyledButtonContainer>}
</StyledSettingsCardContent>
);
};
@@ -11,6 +11,7 @@ import { themeCssVariables } from 'twenty-ui/theme-constants';
const StyledSettingsPageContainer = styled.div<{
width?: number;
isMobile?: boolean;
}>`
display: flex;
flex-direction: column;
@@ -18,11 +19,11 @@ const StyledSettingsPageContainer = styled.div<{
overflow: auto;
padding: ${themeCssVariables.spacing[6]} ${themeCssVariables.spacing[8]}
${themeCssVariables.spacing[8]};
width: ${({ width }) => {
width: ${({ width, isMobile }) => {
if (isDefined(width)) {
return width + 'px';
}
if (useIsMobile()) {
if (isMobile) {
return 'unset';
}
return OBJECT_SETTINGS_WIDTH + 'px';
@@ -35,6 +36,7 @@ export const SettingsPageContainer = ({
}: {
children: ReactNode;
}) => {
const isMobile = useIsMobile();
const location = useLocation();
const settingsPath = useMemo(() => {
const sortedPaths = Object.values(SettingsPath).sort(
@@ -54,7 +56,9 @@ export const SettingsPageContainer = ({
return (
<ScrollWrapper componentInstanceId={componentInstanceId}>
<StyledSettingsPageContainer>{children}</StyledSettingsPageContainer>
<StyledSettingsPageContainer isMobile={isMobile}>
{children}
</StyledSettingsPageContainer>
</ScrollWrapper>
);
};