houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Migrate from ESLint to OxLint (#18443)

Browse Source 
## Summary

Fully replaces ESLint with OxLint across the entire monorepo:

- **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint
configs (`.oxlintrc.json`) for every package: `twenty-front`,
`twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`,
`twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`,
`twenty-apps/*`, `create-twenty-app`
- **Migrated custom lint rules** from ESLint plugin format to OxLint JS
plugin system (`@oxlint/plugins`), including
`styled-components-prefixed-with-styled`, `no-hardcoded-colors`,
`sort-css-properties-alphabetically`,
`graphql-resolvers-should-be-guarded`,
`rest-api-methods-should-be-guarded`, `max-consts-per-file`, and
Jotai-related rules
- **Migrated custom rule tests** from ESLint `RuleTester` + Jest to
`oxlint/plugins-dev` `RuleTester` + Vitest
- **Removed all ESLint dependencies** from `package.json` files and
regenerated lockfiles
- **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in
`nx.json` and per-project `project.json` to use `oxlint` commands with
proper `dependsOn` for plugin builds
- **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more
ESLint executor
- **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with
`oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and
format-on-save with Prettier
- **Replaced all `eslint-disable` comments** with `oxlint-disable`
equivalents across the codebase
- **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint
- **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules`

### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`)

| Rule | Package | Violations | Auto-fixable |
|------|---------|-----------|-------------|
| `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes
|
| `typescript/consistent-type-imports` | twenty-server | 3814 | Yes |
| `twenty/max-consts-per-file` | twenty-server | 94 | No |

### Dropped plugins (no OxLint equivalent)

`eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`,
`import/order`, `prefer-arrow/prefer-arrow-functions`,
`eslint-plugin-mdx`, `@next/eslint-plugin-next`,
`eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial
coverage for `jsx-a11y` and `unused-imports`.

### Additional fixes (pre-existing issues exposed by merge)

- Fixed `EmailThreadPreview.tsx` broken import from main rename
(`useOpenEmailThreadInSidePanel`)
- Restored truthiness guard in `getActivityTargetObjectRecords.ts`
- Fixed `AgentTurnResolver` return types to match entity (virtual
`fileMediaType`/`fileUrl` are resolved via `@ResolveField()`)

## Test plan

- [x] `npx nx lint twenty-front` passes
- [x] `npx nx lint twenty-server` passes
- [x] `npx nx lint twenty-docs` passes
- [x] Custom oxlint rules validated with Vitest: `npx nx test
twenty-oxlint-rules`
- [x] `npx nx typecheck twenty-front` passes
- [x] `npx nx typecheck twenty-server` passes
- [x] CI workflows trigger correctly with `dependsOn:
["twenty-oxlint-rules:build"]`
- [x] IDE linting works with `oxc.oxc-vscode` extension
This commit is contained in:
Charles Bochet
2026-03-06 01:03:50 +01:00
committed by GitHub
parent b421efbff7
commit 9d57bc39e5
880 changed files with 4711 additions and 9687 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-front/src/modules/page-layout/components/PageLayoutGridOverlay.tsx
+1 -1
View File
@@ -68,7 +68,7 @@ export const PageLayoutGridOverlay = () => {
const { createWidgetFromClick } = useCreateWidgetFromClick();
const numberOfRows = useMemo(() => {
const currentTabLayouts = pageLayoutCurrentLayouts[activeTabId ?? ''] || {
const currentTabLayouts = pageLayoutCurrentLayouts[activeTabId ?? ''] ?? {
desktop: [],
mobile: [],
};
packages/twenty-front/src/modules/page-layout/components/PageLayoutTabList.tsx
+2 -2
View File
@@ -113,10 +113,10 @@ export const PageLayoutTabList = ({
// TODO: drop once the configuration of all record page layouts has been migrated to the backend.
title:
shouldTranslateTabTitles &&
STANDARD_PAGE_LAYOUT_TAB_TITLE_TRANSLATIONS[tab.title]
isDefined(STANDARD_PAGE_LAYOUT_TAB_TITLE_TRANSLATIONS[tab.title])
? t(STANDARD_PAGE_LAYOUT_TAB_TITLE_TRANSLATIONS[tab.title])
: tab.title,
Icon: tab.icon ? getIcon(tab.icon) : undefined,
Icon: isDefined(tab.icon) ? getIcon(tab.icon) : undefined,
}));
const navigate = useNavigate();
packages/twenty-front/src/modules/page-layout/components/PageLayoutTabListDroppableMoreButton.tsx
+1 -1
View File
@@ -29,7 +29,7 @@ export const PageLayoutTabListDroppableMoreButton = ({
{(provided, snapshot) => (
<div
ref={provided.innerRef}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...provided.droppableProps}
>
<StyledTabMoreButtonWrapper isDraggingOver={snapshot.isDraggingOver}>
packages/twenty-front/src/modules/page-layout/components/PageLayoutTabListReorderableOverflowDropdown.tsx
+3 -3
View File
@@ -156,7 +156,7 @@ export const PageLayoutTabListReorderableOverflowDropdown = ({
<DropdownMenuItemsContainer>
<div
ref={provided.innerRef}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...provided.droppableProps}
>
{hiddenTabs.map((tab, index) => {
@@ -173,9 +173,9 @@ export const PageLayoutTabListReorderableOverflowDropdown = ({
{(draggableProvided, draggableSnapshot) => (
<StyledOverflowDropdownListDraggableWrapper
ref={draggableProvided.innerRef}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...draggableProvided.draggableProps}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...draggableProvided.dragHandleProps}
style={{
...draggableProvided.draggableProps.style,
packages/twenty-front/src/modules/page-layout/components/PageLayoutTabListReorderableTab.tsx
+2 -2
View File
@@ -38,9 +38,9 @@ export const PageLayoutTabListReorderableTab = ({
{(draggableProvided, draggableSnapshot) => (
<StyledTabContainer
ref={draggableProvided.innerRef}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...draggableProvided.draggableProps}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...draggableProvided.dragHandleProps}
onClick={draggableSnapshot.isDragging ? undefined : onSelect}
active={isActive}
packages/twenty-front/src/modules/page-layout/components/PageLayoutTabListVisibleTabs.tsx
+1 -1
View File
@@ -70,7 +70,7 @@ export const PageLayoutTabListVisibleTabs = ({
{(provided) => (
<StyledTabContainer
ref={provided.innerRef}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...provided.droppableProps}
>
{visibleTabs.slice(0, visibleTabCount).map((tab, index) => (
packages/twenty-front/src/modules/page-layout/components/PageLayoutTabRenderClone.tsx
+6 -5
View File
@@ -1,3 +1,4 @@
import { isDefined } from 'twenty-shared/utils';
import { PAGE_LAYOUT_TAB_LIST_DROPPABLE_IDS } from '@/page-layout/components/PageLayoutTabListDroppableIds';
import { pageLayoutTabListCurrentDragDroppableIdComponentState } from '@/page-layout/states/pageLayoutTabListCurrentDragDroppableIdComponentState';
import { GenericDropdownContentWidth } from '@/ui/layout/dropdown/constants/GenericDropdownContentWidth';
@@ -37,15 +38,15 @@ export const PageLayoutTabRenderClone = ({
pageLayoutTabListCurrentDragDroppableId ===
PAGE_LAYOUT_TAB_LIST_DROPPABLE_IDS.VISIBLE_TABS;
if (!tab) return null;
if (!isDefined(tab)) return null;
if (isHoveringTabList) {
return (
<StyledDraggableWrapper
ref={provided.innerRef}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...provided.draggableProps}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...provided.dragHandleProps}
style={{
...provided.draggableProps.style,
@@ -70,9 +71,9 @@ export const PageLayoutTabRenderClone = ({
<StyledDraggableWrapper
id={'clone-drag-wrapper'}
ref={provided.innerRef}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...provided.draggableProps}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...provided.dragHandleProps}
style={{
...provided.draggableProps.style,
packages/twenty-front/src/modules/page-layout/components/PageLayoutVerticalListEditor.tsx
+3 -3
View File
@@ -86,7 +86,7 @@ export const PageLayoutVerticalListEditor = ({
ref={provided.innerRef}
variant={variant}
shouldUseWhiteBackground={isMobile || isInSidePanel}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...provided.droppableProps}
>
{widgets.map((widget, index) => (
@@ -99,11 +99,11 @@ export const PageLayoutVerticalListEditor = ({
{(provided, snapshot) => (
<StyledDraggableWrapper
ref={provided.innerRef}
// eslint-disable-next-line react/jsx-props-no-spreading
// oxlint-disable-next-line react/jsx-props-no-spreading
{...provided.draggableProps}
isDragging={snapshot.isDragging}
>
{/* eslint-disable-next-line react/jsx-props-no-spreading */}
{/* oxlint-disable-next-line react/jsx-props-no-spreading */}
<div {...provided.dragHandleProps}>
<WidgetRenderer widget={widget} />
</div>