houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Release line chart and pie chart (#16166)

Browse Source 
- Remove the feature flag for these two charts.
- Reorder the charts
- Hide gauge chart
This commit is contained in:
Raphaël Bosi
2025-11-28 11:17:03 +01:00
committed by GitHub
parent eb362c6d5f
commit 9bc58a4ef9
3 changed files with 45 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-server/src/engine/core-modules/page-layout/utils/__tests__/validate-and-transform-widget-configuration.util.spec.ts
+23 -23
View File
@@ -247,23 +247,7 @@ describe('validateAndTransformWidgetConfiguration', () => {
});
describe('Feature flags', () => {
it('should throw error for unsupported graph type', () => {
expect(() =>
validateAndTransformWidgetConfiguration({
type: WidgetType.GRAPH,
configuration: TEST_PIE_CHART_CONFIG,
isDashboardV2Enabled: false,
}),
).toThrow(/IS_DASHBOARD_V2_ENABLED feature flag/);
expect(() =>
validateAndTransformWidgetConfiguration({
type: WidgetType.GRAPH,
configuration: TEST_LINE_CHART_CONFIG,
isDashboardV2Enabled: false,
}),
).toThrow(/IS_DASHBOARD_V2_ENABLED feature flag/);
it('should throw error for GAUGE chart type when IS_DASHBOARD_V2_ENABLED is false', () => {
expect(() =>
validateAndTransformWidgetConfiguration({
type: WidgetType.GRAPH,
@@ -273,7 +257,25 @@ describe('validateAndTransformWidgetConfiguration', () => {
).toThrow(/IS_DASHBOARD_V2_ENABLED feature flag/);
});
it('should not throw error when IS_DASHBOARD_V2_ENABLED feature flag is enabled', () => {
it('should not throw error for GAUGE chart type when IS_DASHBOARD_V2_ENABLED is true', () => {
expect(() =>
validateAndTransformWidgetConfiguration({
type: WidgetType.GRAPH,
configuration: TEST_GAUGE_CHART_CONFIG,
isDashboardV2Enabled: true,
}),
).not.toThrow();
});
it('should not throw error for PIE chart type regardless of IS_DASHBOARD_V2_ENABLED', () => {
expect(() =>
validateAndTransformWidgetConfiguration({
type: WidgetType.GRAPH,
configuration: TEST_PIE_CHART_CONFIG,
isDashboardV2Enabled: false,
}),
).not.toThrow();
expect(() =>
validateAndTransformWidgetConfiguration({
type: WidgetType.GRAPH,
@@ -283,21 +285,19 @@ describe('validateAndTransformWidgetConfiguration', () => {
).not.toThrow();
});
it('should not throw error when IS_DASHBOARD_V2_ENABLED feature flag is enabled', () => {
it('should not throw error for LINE chart type regardless of IS_DASHBOARD_V2_ENABLED', () => {
expect(() =>
validateAndTransformWidgetConfiguration({
type: WidgetType.GRAPH,
configuration: TEST_LINE_CHART_CONFIG,
isDashboardV2Enabled: true,
isDashboardV2Enabled: false,
}),
).not.toThrow();
});
it('should not throw error when IS_DASHBOARD_V2_ENABLED feature flag is enabled', () => {
expect(() =>
validateAndTransformWidgetConfiguration({
type: WidgetType.GRAPH,
configuration: TEST_GAUGE_CHART_CONFIG,
configuration: TEST_LINE_CHART_CONFIG,
isDashboardV2Enabled: true,
}),
).not.toThrow();
packages/twenty-server/src/engine/core-modules/page-layout/utils/validate-and-transform-widget-configuration.util.ts
+1 -3
View File
@@ -38,9 +38,7 @@ const validateGraphConfiguration = ({
return null;
}
const v2ChartTypes = [GraphType.PIE, GraphType.LINE, GraphType.GAUGE];
if (v2ChartTypes.includes(graphType) && !isDashboardV2Enabled) {
if (graphType === GraphType.GAUGE && !isDashboardV2Enabled) {
throw new Error(
`Chart type ${graphType} requires IS_DASHBOARD_V2_ENABLED feature flag`,
);