Remove old view implementation step 1 (#14189)

Let's move forward and get rid of the past... !

Removing prefetchViewState and the prefetch view query.

Next steps:
- renaming Selectors to remove prefetch keywork
- remove old view type and coreViewToView util
- rework optimistic rendering for coreViews
This commit is contained in:
Charles Bochet
2025-09-01 10:25:16 +02:00
committed by GitHub
parent 1e9723a6b7
commit 988f6ee1fa
31 changed files with 120 additions and 1212 deletions
@@ -1,29 +1,19 @@
import { useRecoilCallback } from 'recoil';
import { contextStoreCurrentViewIdComponentState } from '@/context-store/states/contextStoreCurrentViewIdComponentState';
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
import { prefetchViewFromViewIdFamilySelector } from '@/prefetch/states/selector/prefetchViewFromViewIdFamilySelector';
import { useRecoilComponentCallbackState } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentCallbackState';
import { useRefreshCoreViews } from '@/views/hooks/useRefreshCoreViews';
import { type GraphQLView } from '@/views/types/GraphQLView';
import { convertUpdateViewInputToCore } from '@/views/utils/convertUpdateViewInputToCore';
import { useFeatureFlagsMap } from '@/workspace/hooks/useFeatureFlagsMap';
import { isDefined } from 'twenty-shared/utils';
import { useUpdateCoreViewMutation } from '~/generated-metadata/graphql';
import { FeatureFlagKey } from '~/generated/graphql';
export const useUpdateCurrentView = () => {
const currentViewIdCallbackState = useRecoilComponentCallbackState(
contextStoreCurrentViewIdComponentState,
);
const featureFlagMap = useFeatureFlagsMap();
const isCoreViewEnabled = featureFlagMap[FeatureFlagKey.IS_CORE_VIEW_ENABLED];
const { updateOneRecord } = useUpdateOneRecord({
objectNameSingular: CoreObjectNameSingular.View,
});
const { refreshCoreViews } = useRefreshCoreViews();
const [updateOneCoreView] = useUpdateCoreViewMutation();
@@ -48,31 +38,18 @@ export const useUpdateCurrentView = () => {
}
if (isDefined(currentViewId)) {
if (isCoreViewEnabled) {
const input = convertUpdateViewInputToCore(view);
const input = convertUpdateViewInputToCore(view);
await updateOneCoreView({
variables: {
id: currentViewId,
input,
},
});
await refreshCoreViews(currentView.objectMetadataId);
} else {
await updateOneRecord({
idToUpdate: currentViewId,
updateOneRecordInput: view,
});
}
await updateOneCoreView({
variables: {
id: currentViewId,
input,
},
});
await refreshCoreViews(currentView.objectMetadataId);
}
},
[
currentViewIdCallbackState,
isCoreViewEnabled,
refreshCoreViews,
updateOneCoreView,
updateOneRecord,
],
[currentViewIdCallbackState, refreshCoreViews, updateOneCoreView],
);
return {