Change type import rule (#13751)

Forcing "type" to be explicit, works best will rollup on the frontend to
exclude depdendencies

packages/twenty-server/src/engine/core-modules/audit/audit-exception-filter.ts

@@ -1,4 +1,6 @@
-import { Catch, ExceptionFilter } from '@nestjs/common';
+import { Catch, type ExceptionFilter } from '@nestjs/common';
+
+import { assertUnreachable } from 'twenty-shared/utils';
 
 import {
   AuditException,
@@ -14,9 +16,7 @@ export class AuditExceptionFilter implements ExceptionFilter {
       case AuditExceptionCode.INVALID_INPUT:
         throw new UserInputError(exception);
       default: {
-        const _exhaustiveCheck: never = exception.code;
-
-        throw exception;
+        assertUnreachable(exception.code);
       }
     }
   }

packages/twenty-server/src/engine/core-modules/audit/audit.resolver.spec.ts

@@ -1,11 +1,11 @@
-import { Test, TestingModule } from '@nestjs/testing';
+import { Test, type TestingModule } from '@nestjs/testing';
 
 import {
   AuditException,
   AuditExceptionCode,
 } from 'src/engine/core-modules/audit/audit.exception';
-import { User } from 'src/engine/core-modules/user/user.entity';
-import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
+import { type User } from 'src/engine/core-modules/user/user.entity';
+import { type Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
 
 import { AuditResolver } from './audit.resolver';
 

packages/twenty-server/src/engine/core-modules/audit/audit.resolver.ts

@@ -9,8 +9,8 @@ import {
 import { CreateObjectEventInput } from 'src/engine/core-modules/audit/dtos/create-object-event.input';
 import { PreventNestToAutoLogGraphqlErrorsFilter } from 'src/engine/core-modules/graphql/filters/prevent-nest-to-auto-log-graphql-errors.filter';
 import { ResolverValidationPipe } from 'src/engine/core-modules/graphql/pipes/resolver-validation.pipe';
-import { User } from 'src/engine/core-modules/user/user.entity';
-import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
+import { type User } from 'src/engine/core-modules/user/user.entity';
+import { type Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
 import { AuthUser } from 'src/engine/decorators/auth/auth-user.decorator';
 import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
 import { PublicEndpointGuard } from 'src/engine/guards/public-endpoint.guard';

packages/twenty-server/src/engine/core-modules/audit/dtos/create-analytics.input.ts

@@ -10,7 +10,7 @@ import {
 import GraphQLJSON from 'graphql-type-json';
 
 import { TrackEventName } from 'src/engine/core-modules/audit/types/events.type';
-import { PageviewProperties } from 'src/engine/core-modules/audit/utils/events/pageview/pageview';
+import { type PageviewProperties } from 'src/engine/core-modules/audit/utils/events/pageview/pageview';
 
 enum AnalyticsType {
   PAGEVIEW = 'pageview',

packages/twenty-server/src/engine/core-modules/audit/jobs/create-audit-log-from-internal-event.ts

@@ -2,7 +2,7 @@ import { AuditService } from 'src/engine/core-modules/audit/services/audit.servi
 import { OBJECT_RECORD_CREATED_EVENT } from 'src/engine/core-modules/audit/utils/events/object-event/object-record-created';
 import { OBJECT_RECORD_DELETED_EVENT } from 'src/engine/core-modules/audit/utils/events/object-event/object-record-delete';
 import { OBJECT_RECORD_UPDATED_EVENT } from 'src/engine/core-modules/audit/utils/events/object-event/object-record-updated';
-import { ObjectRecordEvent } from 'src/engine/core-modules/event-emitter/types/object-record-event.event';
+import { type ObjectRecordEvent } from 'src/engine/core-modules/event-emitter/types/object-record-event.event';
 import { Process } from 'src/engine/core-modules/message-queue/decorators/process.decorator';
 import { Processor } from 'src/engine/core-modules/message-queue/decorators/processor.decorator';
 import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';

packages/twenty-server/src/engine/core-modules/audit/services/audit.service.spec.ts

@@ -1,4 +1,4 @@
-import { Test, TestingModule } from '@nestjs/testing';
+import { Test, type TestingModule } from '@nestjs/testing';
 
 import { AuditContextMock } from 'test/utils/audit-context.mock';
 

packages/twenty-server/src/engine/core-modules/audit/services/audit.service.ts

@@ -6,14 +6,14 @@ import {
   AuditExceptionCode,
 } from 'src/engine/core-modules/audit/audit.exception';
 import {
-  TrackEventName,
-  TrackEventProperties,
+  type TrackEventName,
+  type TrackEventProperties,
 } from 'src/engine/core-modules/audit/types/events.type';
 import {
   makePageview,
   makeTrackEvent,
 } from 'src/engine/core-modules/audit/utils/analytics.utils';
-import { PageviewProperties } from 'src/engine/core-modules/audit/utils/events/pageview/pageview';
+import { type PageviewProperties } from 'src/engine/core-modules/audit/utils/events/pageview/pageview';
 import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
 
 @Injectable()

packages/twenty-server/src/engine/core-modules/audit/types/events.type.ts

@@ -1,42 +1,42 @@
 import {
-  OBJECT_RECORD_CREATED_EVENT,
-  ObjectRecordCreatedTrackEvent,
+  type OBJECT_RECORD_CREATED_EVENT,
+  type ObjectRecordCreatedTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/object-event/object-record-created';
 import {
-  OBJECT_RECORD_DELETED_EVENT,
-  ObjectRecordDeletedTrackEvent,
+  type OBJECT_RECORD_DELETED_EVENT,
+  type ObjectRecordDeletedTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/object-event/object-record-delete';
 import {
-  OBJECT_RECORD_UPDATED_EVENT,
-  ObjectRecordUpdatedTrackEvent,
+  type OBJECT_RECORD_UPDATED_EVENT,
+  type ObjectRecordUpdatedTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/object-event/object-record-updated';
 import {
-  CUSTOM_DOMAIN_ACTIVATED_EVENT,
-  CustomDomainActivatedTrackEvent,
+  type CUSTOM_DOMAIN_ACTIVATED_EVENT,
+  type CustomDomainActivatedTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/workspace-event/custom-domain/custom-domain-activated';
 import {
-  CUSTOM_DOMAIN_DEACTIVATED_EVENT,
-  CustomDomainDeactivatedTrackEvent,
+  type CUSTOM_DOMAIN_DEACTIVATED_EVENT,
+  type CustomDomainDeactivatedTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/workspace-event/custom-domain/custom-domain-deactivated';
 import {
-  MONITORING_EVENT,
-  MonitoringTrackEvent,
+  type MONITORING_EVENT,
+  type MonitoringTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/workspace-event/monitoring/monitoring';
 import {
-  SERVERLESS_FUNCTION_EXECUTED_EVENT,
-  ServerlessFunctionExecutedTrackEvent,
+  type SERVERLESS_FUNCTION_EXECUTED_EVENT,
+  type ServerlessFunctionExecutedTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/workspace-event/serverless-function/serverless-function-executed';
 import {
-  USER_SIGNUP_EVENT,
-  UserSignupTrackEvent,
+  type USER_SIGNUP_EVENT,
+  type UserSignupTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/workspace-event/user/user-signup';
 import {
-  WEBHOOK_RESPONSE_EVENT,
-  WebhookResponseTrackEvent,
+  type WEBHOOK_RESPONSE_EVENT,
+  type WebhookResponseTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/workspace-event/webhook/webhook-response';
 import {
-  WORKSPACE_ENTITY_CREATED_EVENT,
-  WorkspaceEntityCreatedTrackEvent,
+  type WORKSPACE_ENTITY_CREATED_EVENT,
+  type WorkspaceEntityCreatedTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/workspace-event/workspace-entity/workspace-entity-created';
 
 // Define all track event names

packages/twenty-server/src/engine/core-modules/audit/utils/analytics.utils.ts

@@ -1,17 +1,17 @@
 import { format } from 'date-fns';
 
-import { AuditCommonPropertiesType } from 'src/engine/core-modules/audit/types/common.type';
+import { type AuditCommonPropertiesType } from 'src/engine/core-modules/audit/types/common.type';
 import {
-  TrackEventName,
-  TrackEventProperties,
+  type TrackEventName,
+  type TrackEventProperties,
 } from 'src/engine/core-modules/audit/types/events.type';
 import {
-  PageviewProperties,
+  type PageviewProperties,
   pageviewSchema,
 } from 'src/engine/core-modules/audit/utils/events/pageview/pageview';
 import {
   eventsRegistry,
-  GenericTrackEvent,
+  type GenericTrackEvent,
 } from 'src/engine/core-modules/audit/utils/events/workspace-event/track';
 
 const common = (): Record<AuditCommonPropertiesType, string> => ({