Improve test tooling (#18259)

## Summary

Unifies test mocking tooling across Jest and Storybook, replaces
handcrafted mock data with auto-generated server-fetched data, and
restructures the mock data generation script for maintainability.

### Mock data generation

- Split `generate-mock-data.ts` into three focused modules under
`scripts/mock-data/`:
  - `utils.ts` — shared authentication, GraphQL client, and file writer
  - `generate-metadata.ts` — fetches object metadata from `/metadata`
- `generate-record-data.ts` — fetches record data from `/graphql` using
metadata-driven dynamic queries
- The orchestrator (`generate-mock-data.ts`) authenticates once and
passes the token to both generators
- Company records are now fetched from the actual server (limited to 10
records) instead of being handcrafted
- Generated files are organized under `generated/metadata/objects/` and
`generated/data/companies/`

### Unified test utilities

- Consolidated Jest and MSW mocking into shared utilities that compose
production code (`prefillRecord`, `getRecordNodeFromRecord`,
`getRecordConnectionFromRecords`) with mock metadata
- Renamed `generateEmptyJestRecordNode` → `generateMockRecordNode` and
moved to `testing/utils/`
- Extracted `generateMockRecordConnection` into its own file
- Removed `sanitizeInputForPrefill` workaround (no longer needed with
correctly shaped generated data)
This commit is contained in:
Charles Bochet
2026-02-26 14:31:54 +01:00
committed by GitHub
parent 2f0103faa5
commit 8a7a19f312
33 changed files with 23068 additions and 21543 deletions
@@ -10,69 +10,75 @@ import { WorkflowVisualizerComponentInstanceContext } from '@/workflow/workflow-
import { workflowSelectedNodeComponentState } from '@/workflow/workflow-diagram/states/workflowSelectedNodeComponentState';
import { useStepsOutputSchema } from '@/workflow/workflow-variables/hooks/useStepsOutputSchema';
import { type Decorator } from '@storybook/react-vite';
import { useStore } from 'jotai';
import { useCallback, useEffect, useState } from 'react';
import { useAtomValue, useStore } from 'jotai';
import { useEffect, useState } from 'react';
import { isDefined } from 'twenty-shared/utils';
import {
getWorkflowMock,
getWorkflowNodeIdMock,
mockedWorkflow,
mockedWorkflowNodeId,
mockedWorkflowVersion,
} from '~/testing/mock-data/workflow';
export const WorkflowStepDecorator: Decorator = (Story) => {
const workflowVisualizerComponentInstanceId = 'workflow-visualizer-test-id';
const workflowVersion = getWorkflowMock().versions.edges[0]
.node as WorkflowVersion;
const workflowVersion = mockedWorkflowVersion as WorkflowVersion;
const { populateStepsOutputSchema } = useStepsOutputSchema();
const { loadMockedObjectMetadataItems } = useLoadMockedObjectMetadataItems();
const [ready, setReady] = useState(false);
const store = useStore();
const handleMount = useCallback(async () => {
await loadMockedObjectMetadataItems();
useEffect(() => {
const setup = async () => {
await loadMockedObjectMetadataItems();
store.set(
workflowVisualizerWorkflowIdComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
getWorkflowMock().id,
);
store.set(
workflowVisualizerWorkflowVersionIdComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
workflowVersion.id,
);
store.set(
workflowVisualizerWorkflowRunIdComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
'123',
);
store.set(
workflowSelectedNodeComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
getWorkflowNodeIdMock(),
);
store.set(
flowComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
{
workflowVersionId: workflowVersion.id,
trigger: workflowVersion.trigger,
steps: workflowVersion.steps,
},
);
store.set(
commandMenuWorkflowIdComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
getWorkflowMock().id,
);
populateStepsOutputSchema(workflowVersion);
setReady(true);
store.set(
workflowVisualizerWorkflowIdComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
mockedWorkflow.id,
);
store.set(
workflowVisualizerWorkflowVersionIdComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
workflowVersion.id,
);
store.set(
workflowVisualizerWorkflowRunIdComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
'123',
);
store.set(
workflowSelectedNodeComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
mockedWorkflowNodeId,
);
store.set(
flowComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
{
workflowVersionId: workflowVersion.id,
trigger: workflowVersion.trigger,
steps: workflowVersion.steps,
},
);
store.set(
commandMenuWorkflowIdComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
mockedWorkflow.id,
);
populateStepsOutputSchema(workflowVersion);
setReady(true);
};
setup();
}, [
loadMockedObjectMetadataItems,
populateStepsOutputSchema,
@@ -80,9 +86,11 @@ export const WorkflowStepDecorator: Decorator = (Story) => {
store,
]);
useEffect(() => {
handleMount();
}, [handleMount]);
const workflowVersionId = useAtomValue(
workflowVisualizerWorkflowVersionIdComponentState.atomFamily({
instanceId: workflowVisualizerComponentInstanceId,
}),
);
return (
<CommandMenuPageComponentInstanceContext.Provider
@@ -95,7 +103,7 @@ export const WorkflowStepDecorator: Decorator = (Story) => {
instanceId: workflowVisualizerComponentInstanceId,
}}
>
{ready && <Story />}
{ready && isDefined(workflowVersionId) && <Story />}
</WorkflowVisualizerComponentInstanceContext.Provider>
</CommandMenuPageComponentInstanceContext.Provider>
);