Stop propagating full workflow in components (#13900)

Workflow, workflow version and workflow runs should not be passed
through props or context. These are set in recoil component states and
that's where all hooks should look for these.

This PR stop propagating workflow with version through all components.
This commit is contained in:
Thomas Trompette
2025-08-13 18:02:13 +02:00
committed by GitHub
parent 5eba2a8011
commit 88735f6788
33 changed files with 299 additions and 389 deletions
@@ -1,8 +1,5 @@
import { useGetUpdatableWorkflowVersion } from '@/workflow/hooks/useGetUpdatableWorkflowVersion';
import {
type WorkflowVersion,
type WorkflowWithCurrentVersion,
} from '@/workflow/types/Workflow';
import { useGetUpdatableWorkflowVersionOrThrow } from '@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow';
import { type WorkflowVersion } from '@/workflow/types/Workflow';
import { useMutation } from '@apollo/client';
import { isDefined } from 'twenty-shared/utils';
import {
@@ -23,11 +20,7 @@ import { workflowDiagramComponentState } from '@/workflow/workflow-diagram/state
import { getOrganizedDiagram } from '@/workflow/workflow-diagram/utils/getOrganizedDiagram';
import { UPDATE_WORKFLOW_VERSION_POSITIONS } from '@/workflow/workflow-version/graphql/mutations/updateWorkflowVersionPositions';
export const useTidyUpWorkflowVersion = ({
workflow,
}: {
workflow?: WorkflowWithCurrentVersion;
}) => {
export const useTidyUpWorkflowVersion = () => {
const [workflowDiagram, setWorkflowDiagram] = useRecoilComponentState(
workflowDiagramComponentState,
);
@@ -49,20 +42,13 @@ export const useTidyUpWorkflowVersion = ({
UpdateWorkflowVersionPositionsMutationVariables
>(UPDATE_WORKFLOW_VERSION_POSITIONS, { client: apolloCoreClient });
const { getUpdatableWorkflowVersion } = useGetUpdatableWorkflowVersion();
const { getUpdatableWorkflowVersion } =
useGetUpdatableWorkflowVersionOrThrow();
const updateWorkflowVersionPosition = async (
positions: { id: string; position: { x: number; y: number } }[],
) => {
if (!isDefined(workflow)) {
throw new Error('Cannot find a workflow to update');
}
const workflowVersionId = await getUpdatableWorkflowVersion(workflow);
if (!isDefined(workflowVersionId)) {
throw new Error('Cannot find a workflow version to update');
}
const workflowVersionId = await getUpdatableWorkflowVersion();
await mutate({ variables: { input: { workflowVersionId, positions } } });
@@ -115,7 +101,7 @@ export const useTidyUpWorkflowVersion = ({
};
const tidyUpWorkflowVersion = async () => {
if (!isDefined(workflowDiagram) || !isDefined(workflow?.currentVersion)) {
if (!isDefined(workflowDiagram)) {
return;
}