Stop propagating full workflow in components (#13900)

Workflow, workflow version and workflow runs should not be passed
through props or context. These are set in recoil component states and
that's where all hooks should look for these.

This PR stop propagating workflow with version through all components.

packages/twenty-front/src/modules/workflow/workflow-steps/hooks/__tests__/useCreateStep.test.tsx

@@ -4,7 +4,7 @@ import { RecoilRoot } from 'recoil';
 import { WorkflowVisualizerComponentInstanceContext } from '../../../workflow-diagram/states/contexts/WorkflowVisualizerComponentInstanceContext';
 import { useCreateStep } from '../useCreateStep';
 
-const mockCreateDraftFromWorkflowVersion = jest.fn().mockResolvedValue('457');
+const mockGetUpdatableWorkflowVersion = jest.fn();
 const mockCreateWorkflowVersionStep = jest.fn().mockResolvedValue({
   data: {
     createWorkflowVersionStep: { createdStep: { id: '1', type: 'CODE' } },
@@ -20,9 +20,9 @@ jest.mock(
   }),
 );
 
-jest.mock('@/workflow/hooks/useCreateDraftFromWorkflowVersion', () => ({
-  useCreateDraftFromWorkflowVersion: () => ({
-    createDraftFromWorkflowVersion: mockCreateDraftFromWorkflowVersion,
+jest.mock('@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow', () => ({
+  useGetUpdatableWorkflowVersionOrThrow: () => ({
+    getUpdatableWorkflowVersion: mockGetUpdatableWorkflowVersion,
   }),
 }));
 
@@ -55,7 +55,14 @@ describe('useCreateStep', () => {
     versions: [],
   };
 
-  it('should create step in draft version', async () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('should create step in workflow version', async () => {
+    const mockWorkflowVersionId = 'version-123';
+    mockGetUpdatableWorkflowVersion.mockResolvedValue(mockWorkflowVersionId);
+
     const { result } = renderHook(
       () =>
         useCreateStep({
@@ -74,6 +81,13 @@ describe('useCreateStep', () => {
       });
     });
 
-    expect(mockCreateWorkflowVersionStep).toHaveBeenCalled();
+    expect(mockGetUpdatableWorkflowVersion).toHaveBeenCalled();
+    expect(mockCreateWorkflowVersionStep).toHaveBeenCalledWith({
+      workflowVersionId: mockWorkflowVersionId,
+      stepType: 'CODE',
+      parentStepId: 'parent-step-id',
+      nextStepId: undefined,
+      position: undefined,
+    });
   });
 });

packages/twenty-front/src/modules/workflow/workflow-steps/hooks/__tests__/useDeleteStep.test.ts

@@ -1,17 +1,10 @@
-import { type WorkflowWithCurrentVersion } from '@/workflow/types/Workflow';
 import { useDeleteStep } from '@/workflow/workflow-steps/hooks/useDeleteStep';
 import { renderHook } from '@testing-library/react';
-import { RecoilRoot } from 'recoil';
 
 const mockDeleteWorkflowVersionStep = jest.fn();
-const updateOneRecordMock = jest.fn();
-const mockCreateDraftFromWorkflowVersion = jest.fn().mockResolvedValue('457');
-
-jest.mock('@/object-record/hooks/useUpdateOneRecord', () => ({
-  useUpdateOneRecord: () => ({
-    updateOneRecord: updateOneRecordMock,
-  }),
-}));
+const mockGetUpdatableWorkflowVersion = jest.fn();
+const mockDeleteStepsOutputSchema = jest.fn();
+const mockCloseCommandMenu = jest.fn();
 
 jest.mock('@/workflow/hooks/useDeleteWorkflowVersionStep', () => ({
   useDeleteWorkflowVersionStep: () => ({
@@ -19,34 +12,51 @@ jest.mock('@/workflow/hooks/useDeleteWorkflowVersionStep', () => ({
   }),
 }));
 
-jest.mock('@/workflow/hooks/useCreateDraftFromWorkflowVersion', () => ({
-  useCreateDraftFromWorkflowVersion: () => ({
-    createDraftFromWorkflowVersion: mockCreateDraftFromWorkflowVersion,
+jest.mock('@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow', () => ({
+  useGetUpdatableWorkflowVersionOrThrow: () => ({
+    getUpdatableWorkflowVersion: mockGetUpdatableWorkflowVersion,
+  }),
+}));
+
+jest.mock('@/workflow/hooks/useStepsOutputSchema', () => ({
+  useStepsOutputSchema: () => ({
+    deleteStepsOutputSchema: mockDeleteStepsOutputSchema,
+  }),
+}));
+
+jest.mock('@/command-menu/hooks/useCommandMenu', () => ({
+  useCommandMenu: () => ({
+    closeCommandMenu: mockCloseCommandMenu,
   }),
 }));
 
 describe('useDeleteStep', () => {
-  const mockWorkflow = {
-    id: '123',
-    currentVersion: {
-      id: '456',
-      status: 'DRAFT',
-      steps: [],
-      trigger: { type: 'manual' },
-    },
-    versions: [],
-  };
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
 
-  it('should delete step in draft version', async () => {
-    const { result } = renderHook(
-      () =>
-        useDeleteStep({
-          workflow: mockWorkflow as unknown as WorkflowWithCurrentVersion,
-        }),
-      { wrapper: RecoilRoot },
-    );
-    await result.current.deleteStep('1');
+  it('should delete step and clean up dependencies', async () => {
+    const mockWorkflowVersionId = 'version-123';
+    const mockStepId = 'step-1';
+    const mockDeletedStepIds = ['step-1', 'step-2'];
 
-    expect(mockDeleteWorkflowVersionStep).toHaveBeenCalled();
+    mockGetUpdatableWorkflowVersion.mockResolvedValue(mockWorkflowVersionId);
+    mockDeleteWorkflowVersionStep.mockResolvedValue({
+      deletedStepIds: mockDeletedStepIds,
+    });
+
+    const { result } = renderHook(() => useDeleteStep());
+    await result.current.deleteStep(mockStepId);
+
+    expect(mockGetUpdatableWorkflowVersion).toHaveBeenCalled();
+    expect(mockDeleteWorkflowVersionStep).toHaveBeenCalledWith({
+      workflowVersionId: mockWorkflowVersionId,
+      stepId: mockStepId,
+    });
+    expect(mockCloseCommandMenu).toHaveBeenCalled();
+    expect(mockDeleteStepsOutputSchema).toHaveBeenCalledWith({
+      stepIds: mockDeletedStepIds,
+      workflowVersionId: mockWorkflowVersionId,
+    });
   });
 });

packages/twenty-front/src/modules/workflow/workflow-steps/hooks/__tests__/useUpdateStep.test.ts

@@ -1,15 +1,8 @@
-import { type WorkflowWithCurrentVersion } from '@/workflow/types/Workflow';
 import { useUpdateStep } from '@/workflow/workflow-steps/hooks/useUpdateStep';
 import { renderHook } from '@testing-library/react';
 
 const mockUpdateWorkflowVersionStep = jest.fn();
-const mockCreateDraftFromWorkflowVersion = jest.fn().mockResolvedValue('457');
-
-jest.mock('recoil', () => ({
-  useRecoilValue: () => 'parent-step-id',
-  useSetRecoilState: () => jest.fn(),
-  atom: (params: any) => params,
-}));
+const mockGetUpdatableWorkflowVersion = jest.fn();
 
 jest.mock(
   '@/workflow/workflow-steps/hooks/useUpdateWorkflowVersionStep',
@@ -20,35 +13,24 @@ jest.mock(
   }),
 );
 
-jest.mock('@/workflow/hooks/useCreateDraftFromWorkflowVersion', () => ({
-  useCreateDraftFromWorkflowVersion: () => ({
-    createDraftFromWorkflowVersion: mockCreateDraftFromWorkflowVersion,
+jest.mock('@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow', () => ({
+  useGetUpdatableWorkflowVersionOrThrow: () => ({
+    getUpdatableWorkflowVersion: mockGetUpdatableWorkflowVersion,
   }),
 }));
 
 describe('useUpdateStep', () => {
-  const mockWorkflow = {
-    id: '123',
-    currentVersion: {
-      id: '456',
-      status: 'DRAFT',
-      steps: [],
-      trigger: { type: 'manual' },
-    },
-    versions: [],
-  };
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
 
-  it('should update step in draft version', async () => {
-    const { result } = renderHook(() =>
-      useUpdateStep({
-        workflow: mockWorkflow as unknown as WorkflowWithCurrentVersion,
-      }),
-    );
-    await result.current.updateStep({
+  it('should update step in workflow version', async () => {
+    const mockWorkflowVersionId = 'version-123';
+    const mockStep = {
       id: '1',
       name: 'name',
       valid: true,
-      type: 'CODE',
+      type: 'CODE' as const,
       settings: {
         input: {
           serverlessFunctionId: 'id',
@@ -65,8 +47,17 @@ describe('useUpdateStep', () => {
           },
         },
       },
-    });
+    };
 
-    expect(mockUpdateWorkflowVersionStep).toHaveBeenCalled();
+    mockGetUpdatableWorkflowVersion.mockResolvedValue(mockWorkflowVersionId);
+
+    const { result } = renderHook(() => useUpdateStep());
+    await result.current.updateStep(mockStep);
+
+    expect(mockGetUpdatableWorkflowVersion).toHaveBeenCalled();
+    expect(mockUpdateWorkflowVersionStep).toHaveBeenCalledWith({
+      workflowVersionId: mockWorkflowVersionId,
+      step: mockStep,
+    });
   });
 });

packages/twenty-front/src/modules/workflow/workflow-steps/hooks/useCreateEdge.ts

@@ -1,20 +1,15 @@
-import { useGetUpdatableWorkflowVersion } from '@/workflow/hooks/useGetUpdatableWorkflowVersion';
-import { type WorkflowWithCurrentVersion } from '@/workflow/types/Workflow';
+import { useGetUpdatableWorkflowVersionOrThrow } from '@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow';
+import { type WorkflowDiagramEdge } from '@/workflow/workflow-diagram/types/WorkflowDiagramEdge';
 import { useCreateWorkflowVersionEdge } from '@/workflow/workflow-steps/hooks/useCreateWorkflowVersionEdge';
 import { useState } from 'react';
-import { isDefined } from 'twenty-shared/utils';
-import { type WorkflowDiagramEdge } from '@/workflow/workflow-diagram/types/WorkflowDiagramEdge';
 
-export const useCreateEdge = ({
-  workflow,
-}: {
-  workflow: WorkflowWithCurrentVersion;
-}) => {
+export const useCreateEdge = () => {
   const [isLoading, setIsLoading] = useState(false);
 
   const { createWorkflowVersionEdge } = useCreateWorkflowVersionEdge();
 
-  const { getUpdatableWorkflowVersion } = useGetUpdatableWorkflowVersion();
+  const { getUpdatableWorkflowVersion } =
+    useGetUpdatableWorkflowVersionOrThrow();
 
   const createEdge = async ({ source, target }: WorkflowDiagramEdge) => {
     if (isLoading) {
@@ -24,11 +19,7 @@ export const useCreateEdge = ({
     setIsLoading(true);
 
     try {
-      const workflowVersionId = await getUpdatableWorkflowVersion(workflow);
-
-      if (!isDefined(workflowVersionId)) {
-        throw new Error('Cannot find a workflow version to update');
-      }
+      const workflowVersionId = await getUpdatableWorkflowVersion();
 
       const createdEdge = (
         await createWorkflowVersionEdge({

packages/twenty-front/src/modules/workflow/workflow-steps/hooks/useCreateStep.ts

@@ -1,5 +1,5 @@
 import { useSetRecoilComponentState } from '@/ui/utilities/state/component-state/hooks/useSetRecoilComponentState';
-import { useGetUpdatableWorkflowVersion } from '@/workflow/hooks/useGetUpdatableWorkflowVersion';
+import { useGetUpdatableWorkflowVersionOrThrow } from '@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow';
 import { workflowLastCreatedStepIdComponentState } from '@/workflow/states/workflowLastCreatedStepIdComponentState';
 import {
   type WorkflowStepType,
@@ -24,7 +24,8 @@ export const useCreateStep = ({
     workflowLastCreatedStepIdComponentState,
   );
 
-  const { getUpdatableWorkflowVersion } = useGetUpdatableWorkflowVersion();
+  const { getUpdatableWorkflowVersion } =
+    useGetUpdatableWorkflowVersionOrThrow();
 
   if (!isDefined(workflow)) {
     return {
@@ -50,11 +51,7 @@ export const useCreateStep = ({
     setIsLoading(true);
 
     try {
-      const workflowVersionId = await getUpdatableWorkflowVersion(workflow);
-
-      if (!isDefined(workflowVersionId)) {
-        throw new Error("Couldn't get updatable workflow version");
-      }
+      const workflowVersionId = await getUpdatableWorkflowVersion();
 
       const workflowVersionStepChanges = (
         await createWorkflowVersionStep({

packages/twenty-front/src/modules/workflow/workflow-steps/hooks/useDeleteEdge.ts

@@ -1,25 +1,17 @@
-import { useGetUpdatableWorkflowVersion } from '@/workflow/hooks/useGetUpdatableWorkflowVersion';
-import { type WorkflowWithCurrentVersion } from '@/workflow/types/Workflow';
-import { assertWorkflowWithCurrentVersionIsDefined } from '@/workflow/utils/assertWorkflowWithCurrentVersionIsDefined';
+import { useGetUpdatableWorkflowVersionOrThrow } from '@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow';
 import { type WorkflowDiagramEdge } from '@/workflow/workflow-diagram/types/WorkflowDiagramEdge';
 import { useDeleteWorkflowVersionEdge } from '@/workflow/workflow-steps/hooks/useDeleteWorkflowVersionEdge';
 import { useState } from 'react';
-import { isDefined } from 'twenty-shared/utils';
 
-export const useDeleteEdge = ({
-  workflow,
-}: {
-  workflow: WorkflowWithCurrentVersion | undefined;
-}) => {
+export const useDeleteEdge = () => {
   const [isLoading, setIsLoading] = useState(false);
 
   const { deleteWorkflowVersionEdge } = useDeleteWorkflowVersionEdge();
 
-  const { getUpdatableWorkflowVersion } = useGetUpdatableWorkflowVersion();
+  const { getUpdatableWorkflowVersion } =
+    useGetUpdatableWorkflowVersionOrThrow();
 
   const deleteEdge = async ({ source, target }: WorkflowDiagramEdge) => {
-    assertWorkflowWithCurrentVersionIsDefined(workflow);
-
     if (isLoading) {
       return;
     }
@@ -27,11 +19,7 @@ export const useDeleteEdge = ({
     setIsLoading(true);
 
     try {
-      const workflowVersionId = await getUpdatableWorkflowVersion(workflow);
-
-      if (!isDefined(workflowVersionId)) {
-        throw new Error('Cannot find a workflow version to update');
-      }
+      const workflowVersionId = await getUpdatableWorkflowVersion();
 
       const deletedEdge = (
         await deleteWorkflowVersionEdge({

packages/twenty-front/src/modules/workflow/workflow-steps/hooks/useDeleteStep.ts

@@ -1,30 +1,18 @@
 import { useCommandMenu } from '@/command-menu/hooks/useCommandMenu';
 import { useDeleteWorkflowVersionStep } from '@/workflow/hooks/useDeleteWorkflowVersionStep';
-import { useGetUpdatableWorkflowVersion } from '@/workflow/hooks/useGetUpdatableWorkflowVersion';
+import { useGetUpdatableWorkflowVersionOrThrow } from '@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow';
 import { useStepsOutputSchema } from '@/workflow/hooks/useStepsOutputSchema';
-import { type WorkflowWithCurrentVersion } from '@/workflow/types/Workflow';
-import { assertWorkflowWithCurrentVersionIsDefined } from '@/workflow/utils/assertWorkflowWithCurrentVersionIsDefined';
-import { isDefined } from 'twenty-shared/utils';
 
-export const useDeleteStep = ({
-  workflow,
-}: {
-  workflow: WorkflowWithCurrentVersion | undefined;
-}) => {
+export const useDeleteStep = () => {
   const { deleteWorkflowVersionStep } = useDeleteWorkflowVersionStep();
   const { deleteStepsOutputSchema } = useStepsOutputSchema();
 
-  const { getUpdatableWorkflowVersion } = useGetUpdatableWorkflowVersion();
+  const { getUpdatableWorkflowVersion } =
+    useGetUpdatableWorkflowVersionOrThrow();
   const { closeCommandMenu } = useCommandMenu();
 
   const deleteStep = async (stepId: string) => {
-    assertWorkflowWithCurrentVersionIsDefined(workflow);
-
-    const workflowVersionId = await getUpdatableWorkflowVersion(workflow);
-
-    if (!isDefined(workflowVersionId)) {
-      throw new Error('Could not find workflow version');
-    }
+    const workflowVersionId = await getUpdatableWorkflowVersion();
 
     const workflowVersionStepChanges = await deleteWorkflowVersionStep({
       workflowVersionId,

packages/twenty-front/src/modules/workflow/workflow-steps/hooks/useUpdateStep.ts

@@ -1,29 +1,14 @@
-import { useGetUpdatableWorkflowVersion } from '@/workflow/hooks/useGetUpdatableWorkflowVersion';
-import {
-  type WorkflowStep,
-  type WorkflowWithCurrentVersion,
-} from '@/workflow/types/Workflow';
+import { useGetUpdatableWorkflowVersionOrThrow } from '@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow';
+import { type WorkflowStep } from '@/workflow/types/Workflow';
 import { useUpdateWorkflowVersionStep } from '@/workflow/workflow-steps/hooks/useUpdateWorkflowVersionStep';
-import { isDefined } from 'twenty-shared/utils';
 
-export const useUpdateStep = ({
-  workflow,
-}: {
-  workflow: WorkflowWithCurrentVersion;
-}) => {
-  const { getUpdatableWorkflowVersion } = useGetUpdatableWorkflowVersion();
+export const useUpdateStep = () => {
+  const { getUpdatableWorkflowVersion } =
+    useGetUpdatableWorkflowVersionOrThrow();
   const { updateWorkflowVersionStep } = useUpdateWorkflowVersionStep();
 
   const updateStep = async <T extends WorkflowStep>(updatedStep: T) => {
-    if (!isDefined(workflow.currentVersion)) {
-      throw new Error('Could not find current workflow version');
-    }
-
-    const workflowVersionId = await getUpdatableWorkflowVersion(workflow);
-
-    if (!isDefined(workflowVersionId)) {
-      throw new Error('Workflow version not found');
-    }
+    const workflowVersionId = await getUpdatableWorkflowVersion();
 
     await updateWorkflowVersionStep({
       workflowVersionId,

packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/code-action/components/WorkflowEditActionServerlessFunction.tsx

@@ -8,7 +8,7 @@ import {
   Breadcrumb,
   type BreadcrumbProps,
 } from '@/ui/navigation/bread-crumb/components/Breadcrumb';
-import { useGetUpdatableWorkflowVersion } from '@/workflow/hooks/useGetUpdatableWorkflowVersion';
+import { useGetUpdatableWorkflowVersionOrThrow } from '@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow';
 import { useWorkflowWithCurrentVersion } from '@/workflow/hooks/useWorkflowWithCurrentVersion';
 import { workflowVisualizerWorkflowIdComponentState } from '@/workflow/states/workflowVisualizerWorkflowIdComponentState';
 import { type WorkflowCodeAction } from '@/workflow/types/Workflow';
@@ -30,11 +30,11 @@ import { activeTabIdComponentState } from '@/ui/layout/tab-list/states/activeTab
 import { useHotkeysOnFocusedElement } from '@/ui/utilities/hotkey/hooks/useHotkeysOnFocusedElement';
 import { useListenClickOutside } from '@/ui/utilities/pointer-event/hooks/useListenClickOutside';
 import { useRecoilComponentValue } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValue';
-import { serverlessFunctionTestDataFamilyState } from '@/workflow/states/serverlessFunctionTestDataFamilyState';
 import { WorkflowStepBody } from '@/workflow/workflow-steps/components/WorkflowStepBody';
 import { WorkflowEditActionServerlessFunctionFields } from '@/workflow/workflow-steps/workflow-actions/code-action/components/WorkflowEditActionServerlessFunctionFields';
 import { WorkflowServerlessFunctionCodeEditor } from '@/workflow/workflow-steps/workflow-actions/code-action/components/WorkflowServerlessFunctionCodeEditor';
 import { WORKFLOW_SERVERLESS_FUNCTION_TAB_LIST_COMPONENT_ID } from '@/workflow/workflow-steps/workflow-actions/code-action/constants/WorkflowServerlessFunctionTabListComponentId';
+import { serverlessFunctionTestDataFamilyState } from '@/workflow/workflow-steps/workflow-actions/code-action/states/serverlessFunctionTestDataFamilyState';
 import { WorkflowServerlessFunctionTabId } from '@/workflow/workflow-steps/workflow-actions/code-action/types/WorkflowServerlessFunctionTabId';
 import { getWrongExportedFunctionMarkers } from '@/workflow/workflow-steps/workflow-actions/code-action/utils/getWrongExportedFunctionMarkers';
 import { useActionHeaderTypeOrThrow } from '@/workflow/workflow-steps/workflow-actions/hooks/useActionHeaderTypeOrThrow';
@@ -140,7 +140,8 @@ export const WorkflowEditActionServerlessFunction = ({
   );
   const { updateOneServerlessFunction } =
     useUpdateOneServerlessFunction(serverlessFunctionId);
-  const { getUpdatableWorkflowVersion } = useGetUpdatableWorkflowVersion();
+  const { getUpdatableWorkflowVersion } =
+    useGetUpdatableWorkflowVersionOrThrow();
 
   const workflowVisualizerWorkflowId = useRecoilComponentValue(
     workflowVisualizerWorkflowIdComponentState,
@@ -323,7 +324,7 @@ export const WorkflowEditActionServerlessFunction = ({
     if (actionOptions.readonly === true || !isDefined(workflow)) {
       return;
     }
-    await getUpdatableWorkflowVersion(workflow);
+    await getUpdatableWorkflowVersion();
     await onCodeChange(value);
   };
 

packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/code-action/states/serverlessFunctionTestDataFamilyState.ts

@@ -0,0 +1,36 @@
+import { createFamilyState } from '@/ui/utilities/state/utils/createFamilyState';
+import { ServerlessFunctionExecutionStatus } from '~/generated-metadata/graphql';
+
+export type ServerlessFunctionTestData = {
+  input: { [field: string]: any };
+  shouldInitInput: boolean;
+  output: {
+    data?: string;
+    logs: string;
+    duration?: number;
+    status?: ServerlessFunctionExecutionStatus;
+    error?: string;
+  };
+  language: 'plaintext' | 'json';
+  height: number;
+};
+
+export const DEFAULT_OUTPUT_VALUE = {
+  data: 'Enter an input above then press "Test"',
+  logs: '',
+  status: ServerlessFunctionExecutionStatus.IDLE,
+};
+
+export const serverlessFunctionTestDataFamilyState = createFamilyState<
+  ServerlessFunctionTestData,
+  string
+>({
+  key: 'serverlessFunctionTestDataFamilyState',
+  defaultValue: {
+    language: 'plaintext',
+    height: 64,
+    input: {},
+    shouldInitInput: true,
+    output: DEFAULT_OUTPUT_VALUE,
+  },
+});