Refactor action bar entries and context menu entries (#1608)

- refactored actionbar entries / context menu entries
This commit is contained in:
brendanlaschke
2023-09-15 18:51:02 +03:00
committed by GitHub
parent 955deaf878
commit 85a6d0aa12
16 changed files with 141 additions and 117 deletions
@@ -12,6 +12,8 @@ import { contextMenuEntriesState } from '../states/contextMenuEntriesState';
import { contextMenuIsOpenState } from '../states/contextMenuIsOpenState';
import { PositionType } from '../types/PositionType';
import { ContextMenuItem } from './ContextMenuItem';
type OwnProps = {
selectedIds: string[];
};
@@ -66,7 +68,15 @@ export function ContextMenu({ selectedIds }: OwnProps) {
>
<StyledDropdownMenu>
<StyledDropdownMenuItemsContainer>
{contextMenuEntries}
{contextMenuEntries.map((item) => (
<ContextMenuItem
Icon={item.Icon}
label={item.label}
accent={item.accent}
onClick={item.onClick}
key={item.label}
/>
))}
</StyledDropdownMenuItemsContainer>
</StyledDropdownMenu>
</StyledContainerContextMenu>
@@ -1,16 +1,16 @@
import { IconComponent } from '@/ui/icon/types/IconComponent';
import { MenuItem } from '@/ui/menu-item/components/MenuItem';
type ContextMenuEntryAccent = 'default' | 'danger';
import { ContextMenuItemAccent } from '../types/ContextMenuItemAccent';
type OwnProps = {
Icon: IconComponent;
label: string;
accent?: ContextMenuEntryAccent;
accent?: ContextMenuItemAccent;
onClick: () => void;
};
export function ContextMenuEntry({
export function ContextMenuItem({
label,
Icon,
accent = 'default',
@@ -1,7 +1,8 @@
import { ReactElement } from 'react';
import { atom } from 'recoil';
export const contextMenuEntriesState = atom<ReactElement[]>({
import { ContextMenuEntry } from '../types/ContextMenuEntry';
export const contextMenuEntriesState = atom<ContextMenuEntry[]>({
key: 'contextMenuEntriesState',
default: [],
});
@@ -0,0 +1,10 @@
import { IconComponent } from '@/ui/icon/types/IconComponent';
import { ContextMenuItemAccent } from './ContextMenuItemAccent';
export type ContextMenuEntry = {
label: string;
Icon: IconComponent;
accent?: ContextMenuItemAccent;
onClick: () => void;
};
@@ -0,0 +1 @@
export type ContextMenuItemAccent = 'default' | 'danger';