[REQUIRES_CACHE_FLUSH][GQL_VIEW_GROUP_API_BREAKING_CHANGE] ViewGroup in v2 (#15052)

# Introduction
Adding view-group to core engine v2
Following https://github.com/twentyhq/twenty/pull/15010 ( same pattern )

## What's done
- Created flat-view-group
- flat view group runner
- flat view group builder
- create view group service v2 and input transpilers
- refactor the existing view group resolver to fix standard (
BREAKING_CHANGE on graphql api update especially ) REST stays the same
- refactored the front to consume the mutations autogenerated

close https://github.com/twentyhq/core-team-issues/issues/1665
This commit is contained in:
Paul Rastoin
2025-10-14 15:55:50 +02:00
committed by GitHub
parent 5fec6a9afc
commit 7d747c9876
88 changed files with 2640 additions and 497 deletions
@@ -1,14 +1,6 @@
import { type AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';
import { ALL_METADATA_NAME } from 'src/engine/metadata-modules/flat-entity/constant/all-metadata-name.constant';
import { getMetadataFlatEntityMapsKey } from 'src/engine/metadata-modules/flat-entity/utils/get-metadata-flat-entity-maps-key.util';
export const ALL_FLAT_ENTITY_MAPS_PROPERTIES = [
'flatObjectMetadataMaps',
'flatViewFieldMaps',
'flatViewMaps',
'flatIndexMaps',
'flatServerlessFunctionMaps',
'flatDatabaseEventTriggerMaps',
'flatCronTriggerMaps',
'flatRouteTriggerMaps',
'flatFieldMetadataMaps',
'flatViewFilterMaps',
] as const satisfies (keyof AllFlatEntityMaps)[];
export const ALL_FLAT_ENTITY_MAPS_PROPERTIES = Object.keys(
ALL_METADATA_NAME,
).map(getMetadataFlatEntityMapsKey);
@@ -5,6 +5,7 @@ import { type MetadataFlatEntity } from 'src/engine/metadata-modules/flat-entity
import { FLAT_FIELD_METADATA_EDITABLE_PROPERTIES } from 'src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-editable-properties.constant';
import { FLAT_VIEW_FIELD_EDITABLE_PROPERTIES } from 'src/engine/metadata-modules/flat-view-field/constants/flat-view-field-editable-properties.constant';
import { FLAT_VIEW_FILTER_EDITABLE_PROPERTIES } from 'src/engine/metadata-modules/flat-view-filter/constants/flat-view-filter-editable-properties.constant';
import { FLAT_VIEW_GROUP_EDITABLE_PROPERTIES } from 'src/engine/metadata-modules/flat-view-group/constants/flat-view-group-editable-properties.constant';
import { FLAT_VIEW_EDITABLE_PROPERTIES } from 'src/engine/metadata-modules/flat-view/constants/flat-view-editable-properties.constant';
import { FLAT_ROUTE_TRIGGER_EDITABLE_PROPERTIES } from 'src/engine/metadata-modules/route-trigger/constants/flat-route-trigger-editable-properties.constant';
import { FLAT_SERVERLESS_FUNCTION_EDITABLE_PROPERTIES } from 'src/engine/metadata-modules/serverless-function/constants/flat-serverless-function-editable-properties.constant';
@@ -49,6 +50,10 @@ export const ALL_FLAT_ENTITY_PROPERTIES_TO_COMPARE_AND_STRINGIFY = {
propertiesToCompare: [...FLAT_VIEW_FIELD_EDITABLE_PROPERTIES, 'deletedAt'],
propertiesToStringify: [],
},
viewGroup: {
propertiesToCompare: [...FLAT_VIEW_GROUP_EDITABLE_PROPERTIES, 'deletedAt'],
propertiesToStringify: [],
},
index: {
propertiesToCompare: [
'indexType',
@@ -42,6 +42,10 @@ export const ALL_METADATA_NAME_MANY_TO_ONE_RELATIONS = {
view: 'viewId',
fieldMetadata: 'fieldMetadataId',
},
viewGroup: {
view: 'viewId',
fieldMetadata: 'fieldMetadataId',
},
index: {
objectMetadata: 'objectMetadataId',
},
@@ -3,6 +3,7 @@ export const ALL_METADATA_NAME = {
objectMetadata: 'objectMetadata',
view: 'view',
viewField: 'viewField',
viewGroup: 'viewGroup',
index: 'index',
serverlessFunction: 'serverlessFunction',
cronTrigger: 'cronTrigger',
@@ -43,4 +43,8 @@ export const ALL_METADATA_REQUIRED_METADATA_FOR_VALIDATION = {
view: true,
fieldMetadata: true,
},
viewGroup: {
fieldMetadata: true,
view: true,
},
} as const satisfies MetadataRequiredForValidation;
@@ -1,15 +1,15 @@
import { ALL_METADATA_NAME } from 'src/engine/metadata-modules/flat-entity/constant/all-metadata-name.constant';
import { EMPTY_FLAT_ENTITY_MAPS } from 'src/engine/metadata-modules/flat-entity/constant/empty-flat-entity-maps.constant';
import { type AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';
import { type AllMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-metadata-name.type';
import { getMetadataFlatEntityMapsKey } from 'src/engine/metadata-modules/flat-entity/utils/get-metadata-flat-entity-maps-key.util';
export const EMPTY_ALL_FLAT_ENTITY_MAPS = {
flatObjectMetadataMaps: EMPTY_FLAT_ENTITY_MAPS,
flatFieldMetadataMaps: EMPTY_FLAT_ENTITY_MAPS,
flatIndexMaps: EMPTY_FLAT_ENTITY_MAPS,
flatViewFieldMaps: EMPTY_FLAT_ENTITY_MAPS,
flatViewMaps: EMPTY_FLAT_ENTITY_MAPS,
flatServerlessFunctionMaps: EMPTY_FLAT_ENTITY_MAPS,
flatCronTriggerMaps: EMPTY_FLAT_ENTITY_MAPS,
flatDatabaseEventTriggerMaps: EMPTY_FLAT_ENTITY_MAPS,
flatRouteTriggerMaps: EMPTY_FLAT_ENTITY_MAPS,
flatViewFilterMaps: EMPTY_FLAT_ENTITY_MAPS,
} as const satisfies AllFlatEntityMaps;
export const EMPTY_ALL_FLAT_ENTITY_MAPS = (
Object.keys(ALL_METADATA_NAME) as AllMetadataName[]
).reduce<AllFlatEntityMaps>(
(acc, metadataName) => ({
...acc,
[getMetadataFlatEntityMapsKey(metadataName)]: EMPTY_FLAT_ENTITY_MAPS,
}),
{} as AllFlatEntityMaps,
);
@@ -1,6 +1,7 @@
import { type Expect } from 'twenty-shared/testing';
import { type AllFlatEntityTypesByMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-types-by-metadata-name';
import { type AllMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-metadata-name.type';
import { type FlatEntity } from 'src/engine/metadata-modules/flat-entity/types/flat-entity.type';
import { type WorkspaceMigrationActionV2 } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/types/workspace-migration-action-common-v2';
@@ -19,6 +20,16 @@ type ExpectedGenericAllFlatEntityInformationByMetadataEngine = {
// eslint-disable-next-line unused-imports/no-unused-vars
type Assertions = [
Expect<
keyof AllFlatEntityTypesByMetadataName extends AllMetadataName
? true
: false
>,
Expect<
AllMetadataName extends keyof AllFlatEntityTypesByMetadataName
? true
: false
>,
Expect<
AllFlatEntityTypesByMetadataName extends ExpectedGenericAllFlatEntityInformationByMetadataEngine
? true
@@ -8,6 +8,7 @@ import { type FlatIndexMetadata } from 'src/engine/metadata-modules/flat-index-m
import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
import { type FlatViewField } from 'src/engine/metadata-modules/flat-view-field/types/flat-view-field.type';
import { type FlatViewFilter } from 'src/engine/metadata-modules/flat-view-filter/types/flat-view-filter.type';
import { type FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
import { type FlatView } from 'src/engine/metadata-modules/flat-view/types/flat-view.type';
import { type IndexMetadataEntity } from 'src/engine/metadata-modules/index-metadata/index-metadata.entity';
import { type ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
@@ -17,6 +18,7 @@ import { type ServerlessFunctionEntity } from 'src/engine/metadata-modules/serve
import { type FlatServerlessFunction } from 'src/engine/metadata-modules/serverless-function/types/flat-serverless-function.type';
import { type ViewFieldEntity } from 'src/engine/metadata-modules/view-field/entities/view-field.entity';
import { type ViewFilterEntity } from 'src/engine/metadata-modules/view-filter/entities/view-filter.entity';
import { type ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
import { type ViewEntity } from 'src/engine/metadata-modules/view/entities/view.entity';
import {
type CreateCronTriggerAction,
@@ -62,6 +64,11 @@ import {
type DeleteViewFilterAction,
type UpdateViewFilterAction,
} from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-filter/types/workspace-migration-view-filter-action-v2.type';
import {
type CreateViewGroupAction,
type DeleteViewGroupAction,
type UpdateViewGroupAction,
} from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-group/types/workspace-migration-view-group-action-v2.type';
import {
type CreateViewAction,
type DeleteViewAction,
@@ -105,6 +112,15 @@ export type AllFlatEntityTypesByMetadataName = {
flatEntity: FlatViewField;
entity: ViewFieldEntity;
};
viewGroup: {
actions: {
created: CreateViewGroupAction;
updated: UpdateViewGroupAction;
deleted: DeleteViewGroupAction;
};
flatEntity: FlatViewGroup;
entity: ViewGroupEntity;
};
index: {
actions: {
created: CreateIndexAction;
@@ -2,6 +2,7 @@ import {
type FieldInputTranspilationResult,
type SuccessfulFieldInputTranspilation,
} from 'src/engine/metadata-modules/flat-field-metadata/types/field-input-transpilation-result.type';
import { EMPTY_ORCHESTRATOR_FAILURE_REPORT } from 'src/engine/workspace-manager/workspace-migration-v2/constant/empty-orchestrator-failure-report.constant';
import { WorkspaceMigrationBuilderExceptionV2 } from 'src/engine/workspace-manager/workspace-migration-v2/exceptions/workspace-migration-builder-exception-v2';
// This could be improved by still running the build and validate with available valid inputs
@@ -24,11 +25,7 @@ export const throwOnFieldInputTranspilationsError: ThrowOnFieldInputTranspilatio
throw new WorkspaceMigrationBuilderExceptionV2(
{
report: {
viewFilter: [],
fieldMetadata: [],
index: [],
view: [],
viewField: [],
...EMPTY_ORCHESTRATOR_FAILURE_REPORT,
objectMetadata: [
{
errors: failedInputTranspilationErrors,
@@ -36,10 +33,6 @@ export const throwOnFieldInputTranspilationsError: ThrowOnFieldInputTranspilatio
flatEntityMinimalInformation: {},
},
],
serverlessFunction: [],
databaseEventTrigger: [],
cronTrigger: [],
routeTrigger: [],
},
status: 'fail',
},
@@ -0,0 +1,8 @@
import { type FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
export const FLAT_VIEW_GROUP_EDITABLE_PROPERTIES = [
'isVisible',
'fieldValue',
'position',
'fieldMetadataId',
] as const satisfies (keyof FlatViewGroup)[];
@@ -0,0 +1,7 @@
import { type ViewGroupEntityRelationProperties } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
export const VIEW_GROUP_ENTITY_RELATION_PROPERTIES = [
'fieldMetadata',
'view',
'workspace',
] as const satisfies ViewGroupEntityRelationProperties[];
@@ -0,0 +1,50 @@
import { Injectable } from '@nestjs/common';
import { InjectRepository } from '@nestjs/typeorm';
import { Repository } from 'typeorm';
import { InjectCacheStorage } from 'src/engine/core-modules/cache-storage/decorators/cache-storage.decorator';
import { CacheStorageService } from 'src/engine/core-modules/cache-storage/services/cache-storage.service';
import { CacheStorageNamespace } from 'src/engine/core-modules/cache-storage/types/cache-storage-namespace.enum';
import { EMPTY_FLAT_ENTITY_MAPS } from 'src/engine/metadata-modules/flat-entity/constant/empty-flat-entity-maps.constant';
import { addFlatEntityToFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/add-flat-entity-to-flat-entity-maps-or-throw.util';
import { FlatViewGroupMaps } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group-maps.type';
import { fromViewGroupEntityToFlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/utils/from-view-group-entity-to-flat-view-group.util';
import { ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
import { WorkspaceFlatMapCache } from 'src/engine/workspace-flat-map-cache/decorators/workspace-flat-map-cache.decorator';
import { WorkspaceFlatMapCacheService } from 'src/engine/workspace-flat-map-cache/services/workspace-flat-map-cache.service';
@Injectable()
@WorkspaceFlatMapCache('flatViewGroupMaps')
export class WorkspaceFlatViewGroupMapCacheService extends WorkspaceFlatMapCacheService<FlatViewGroupMaps> {
constructor(
@InjectCacheStorage(CacheStorageNamespace.EngineWorkspace)
cacheStorageService: CacheStorageService,
@InjectRepository(ViewGroupEntity)
private readonly viewGroupRepository: Repository<ViewGroupEntity>,
) {
super(cacheStorageService);
}
protected async computeFlatMap({
workspaceId,
}: {
workspaceId: string;
}): Promise<FlatViewGroupMaps> {
const existingViewGroups = await this.viewGroupRepository.find({
where: {
workspaceId,
},
withDeleted: true,
});
return existingViewGroups.reduce((flatViewGroupMaps, viewGroupEntity) => {
const flatViewGroup = fromViewGroupEntityToFlatViewGroup(viewGroupEntity);
return addFlatEntityToFlatEntityMapsOrThrow({
flatEntity: flatViewGroup,
flatEntityMaps: flatViewGroupMaps,
});
}, EMPTY_FLAT_ENTITY_MAPS);
}
}
@@ -0,0 +1,4 @@
import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
import { type FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
export type FlatViewGroupMaps = FlatEntityMaps<FlatViewGroup>;
@@ -0,0 +1,18 @@
import { type Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
import { type FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
import { type ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
import { type ViewEntity } from 'src/engine/metadata-modules/view/entities/view.entity';
import { type ExtractRecordTypeOrmRelationProperties } from 'src/engine/workspace-manager/workspace-migration-v2/types/extract-record-typeorm-relation-properties.type';
export type ViewGroupEntityRelationProperties =
ExtractRecordTypeOrmRelationProperties<
ViewGroupEntity,
FieldMetadataEntity | ViewEntity | Workspace
>;
export type FlatViewGroup = Omit<
ViewGroupEntity,
ViewGroupEntityRelationProperties
> & {
universalIdentifier: string;
};
@@ -0,0 +1,36 @@
import { trimAndRemoveDuplicatedWhitespacesFromObjectStringProperties } from 'twenty-shared/utils';
import { v4 } from 'uuid';
import { type FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
import { type CreateViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/create-view-group.input';
export const fromCreateViewGroupInputToFlatViewGroupToCreate = ({
createViewGroupInput: rawCreateViewGroupInput,
workspaceId,
}: {
createViewGroupInput: CreateViewGroupInput;
workspaceId: string;
}): FlatViewGroup => {
const { fieldMetadataId, viewId, ...createViewGroupInput } =
trimAndRemoveDuplicatedWhitespacesFromObjectStringProperties(
rawCreateViewGroupInput,
['fieldMetadataId', 'fieldValue', 'id', 'viewId'],
);
const createdAt = new Date();
const viewGroupId = createViewGroupInput.id ?? v4();
return {
id: viewGroupId,
fieldMetadataId,
viewId,
workspaceId,
createdAt: createdAt,
updatedAt: createdAt,
deletedAt: null,
universalIdentifier: viewGroupId,
isVisible: createViewGroupInput.isVisible ?? true,
fieldValue: createViewGroupInput.fieldValue,
position: createViewGroupInput.position ?? 0,
};
};
@@ -0,0 +1,40 @@
import { t } from '@lingui/core/macro';
import {
extractAndSanitizeObjectStringFields,
isDefined,
} from 'twenty-shared/utils';
import { type FlatViewGroupMaps } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group-maps.type';
import { type FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
import { type DeleteViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/delete-view-group.input';
import {
ViewGroupException,
ViewGroupExceptionCode,
} from 'src/engine/metadata-modules/view-group/exceptions/view-group.exception';
export const fromDeleteViewGroupInputToFlatViewGroupOrThrow = ({
deleteViewGroupInput: rawDeleteViewGroupInput,
flatViewGroupMaps,
}: {
deleteViewGroupInput: DeleteViewGroupInput;
flatViewGroupMaps: FlatViewGroupMaps;
}): FlatViewGroup => {
const { id: viewGroupId } = extractAndSanitizeObjectStringFields(
rawDeleteViewGroupInput,
['id'],
);
const existingFlatViewGroupToDelete = flatViewGroupMaps.byId[viewGroupId];
if (!isDefined(existingFlatViewGroupToDelete)) {
throw new ViewGroupException(
t`View group to delete not found`,
ViewGroupExceptionCode.VIEW_GROUP_NOT_FOUND,
);
}
return {
...existingFlatViewGroupToDelete,
deletedAt: new Date(),
};
};
@@ -0,0 +1,37 @@
import { t } from '@lingui/core/macro';
import {
extractAndSanitizeObjectStringFields,
isDefined,
} from 'twenty-shared/utils';
import { type FlatViewGroupMaps } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group-maps.type';
import { type FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
import { type DestroyViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/destroy-view-group.input';
import {
ViewGroupException,
ViewGroupExceptionCode,
} from 'src/engine/metadata-modules/view-group/exceptions/view-group.exception';
export const fromDestroyViewGroupInputToFlatViewGroupOrThrow = ({
destroyViewGroupInput,
flatViewGroupMaps,
}: {
destroyViewGroupInput: DestroyViewGroupInput;
flatViewGroupMaps: FlatViewGroupMaps;
}): FlatViewGroup => {
const { id: viewGroupId } = extractAndSanitizeObjectStringFields(
destroyViewGroupInput,
['id'],
);
const existingFlatViewGroupToDestroy = flatViewGroupMaps.byId[viewGroupId];
if (!isDefined(existingFlatViewGroupToDestroy)) {
throw new ViewGroupException(
t`View group to destroy not found`,
ViewGroupExceptionCode.VIEW_GROUP_NOT_FOUND,
);
}
return existingFlatViewGroupToDestroy;
};
@@ -0,0 +1,50 @@
import { t } from '@lingui/core/macro';
import {
extractAndSanitizeObjectStringFields,
isDefined,
trimAndRemoveDuplicatedWhitespacesFromObjectStringProperties,
} from 'twenty-shared/utils';
import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
import { FLAT_VIEW_GROUP_EDITABLE_PROPERTIES } from 'src/engine/metadata-modules/flat-view-group/constants/flat-view-group-editable-properties.constant';
import { type FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
import { type UpdateViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/update-view-group.input';
import {
ViewGroupException,
ViewGroupExceptionCode,
} from 'src/engine/metadata-modules/view-group/exceptions/view-group.exception';
import { mergeUpdateInExistingRecord } from 'src/utils/merge-update-in-existing-record.util';
export const fromUpdateViewGroupInputToFlatViewGroupToUpdateOrThrow = ({
updateViewGroupInput: rawUpdateViewGroupInput,
flatViewGroupMaps,
}: {
updateViewGroupInput: UpdateViewGroupInput;
flatViewGroupMaps: FlatEntityMaps<FlatViewGroup>;
}): FlatViewGroup => {
const { id: viewGroupToUpdateId, update } =
trimAndRemoveDuplicatedWhitespacesFromObjectStringProperties(
rawUpdateViewGroupInput,
['id'],
);
const existingFlatViewGroupToUpdate =
flatViewGroupMaps.byId[viewGroupToUpdateId];
if (!isDefined(existingFlatViewGroupToUpdate)) {
throw new ViewGroupException(
t`View group to update not found`,
ViewGroupExceptionCode.VIEW_GROUP_NOT_FOUND,
);
}
const updatedEditableGroupProperties = extractAndSanitizeObjectStringFields(
update,
FLAT_VIEW_GROUP_EDITABLE_PROPERTIES,
);
return mergeUpdateInExistingRecord({
existing: existingFlatViewGroupToUpdate,
properties: FLAT_VIEW_GROUP_EDITABLE_PROPERTIES,
update: updatedEditableGroupProperties,
});
};
@@ -0,0 +1,21 @@
import { removePropertiesFromRecord } from 'twenty-shared/utils';
import { VIEW_GROUP_ENTITY_RELATION_PROPERTIES } from 'src/engine/metadata-modules/flat-view-group/constants/view-group-entity-relation-properties.constant';
import { type FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
import { type ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
export const fromViewGroupEntityToFlatViewGroup = (
viewGroupEntity: ViewGroupEntity,
): FlatViewGroup => {
const viewGroupEntityWithoutRelations = removePropertiesFromRecord(
viewGroupEntity,
VIEW_GROUP_ENTITY_RELATION_PROPERTIES,
);
return {
...viewGroupEntityWithoutRelations,
universalIdentifier:
viewGroupEntityWithoutRelations.universalIdentifier ??
viewGroupEntityWithoutRelations.id,
};
};
@@ -43,7 +43,7 @@ export class WorkspaceFlatViewMapCacheService extends WorkspaceFlatMapCacheServi
id: true,
},
},
relations: ['viewFields', 'viewFilters'],
relations: ['viewFields', 'viewFilters', 'viewGroups'],
withDeleted: true,
});
@@ -24,4 +24,5 @@ export type FlatView = Omit<ViewEntity, ViewEntityRelationProperties> & {
universalIdentifier: string;
viewFieldIds: string[];
viewFilterIds: string[];
viewGroupIds: string[];
};
@@ -45,5 +45,6 @@ export const fromCreateViewInputToFlatViewToCreate = ({
universalIdentifier: v4(),
viewFieldIds: [],
viewFilterIds: [],
viewGroupIds: [],
};
};
@@ -17,5 +17,6 @@ export const fromViewEntityToFlatView = (viewEntity: ViewEntity): FlatView => {
viewEntityWithoutRelations.id,
viewFieldIds: viewEntity.viewFields.map((viewField) => viewField.id),
viewFilterIds: viewEntity.viewFilters.map((viewFilter) => viewFilter.id),
viewGroupIds: viewEntity.viewGroups.map((viewGroup) => viewGroup.id),
};
};
@@ -1,24 +1,41 @@
import { Field, InputType } from '@nestjs/graphql';
import {
IsBoolean,
IsNumber,
IsOptional,
IsString,
IsUUID,
} from 'class-validator';
import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
@InputType()
export class CreateViewGroupInput {
@IsOptional()
@IsUUID()
@Field(() => UUIDScalarType, { nullable: true })
id?: string;
@IsUUID()
@Field(() => UUIDScalarType, { nullable: false })
fieldMetadataId: string;
@IsOptional()
@IsBoolean()
@Field({ nullable: true, defaultValue: true })
isVisible?: boolean;
@IsString()
@Field({ nullable: false })
fieldValue: string;
@IsOptional()
@IsNumber()
@Field({ nullable: true, defaultValue: 0 })
position?: number;
@IsUUID()
@Field(() => UUIDScalarType, { nullable: false })
viewId: string;
}
@@ -0,0 +1,15 @@
import { InputType } from '@nestjs/graphql';
import { IDField } from '@ptc-org/nestjs-query-graphql';
import { IsUUID } from 'class-validator';
import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
@InputType()
export class DeleteViewGroupInput {
@IDField(() => UUIDScalarType, {
description: 'The id of the view group to delete.',
})
@IsUUID()
id: string;
}
@@ -0,0 +1,15 @@
import { InputType } from '@nestjs/graphql';
import { IDField } from '@ptc-org/nestjs-query-graphql';
import { IsUUID } from 'class-validator';
import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
@InputType()
export class DestroyViewGroupInput {
@IDField(() => UUIDScalarType, {
description: 'The id of the view group to destroy.',
})
@IsUUID()
id: string;
}
@@ -1,6 +1,54 @@
import { InputType, PartialType } from '@nestjs/graphql';
import { Field, InputType } from '@nestjs/graphql';
import { CreateViewGroupInput } from './create-view-group.input';
import {
IsBoolean,
IsNotEmpty,
IsNumber,
IsOptional,
IsString,
IsUUID,
ValidateNested,
} from 'class-validator';
import { Type } from 'class-transformer';
import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
@InputType()
export class UpdateViewGroupInput extends PartialType(CreateViewGroupInput) {}
class UpdateViewGroupInputUpdates {
@IsOptional()
@IsUUID()
@Field(() => UUIDScalarType, { nullable: true })
fieldMetadataId?: string;
@IsOptional()
@IsBoolean()
@Field({ nullable: true })
isVisible?: boolean;
@IsOptional()
@IsString()
@Field({ nullable: true })
fieldValue?: string;
@IsOptional()
@IsNumber()
@Field({ nullable: true })
position?: number;
}
@InputType()
export class UpdateViewGroupInput {
@IsUUID()
@IsNotEmpty()
@Field(() => UUIDScalarType, {
description: 'The id of the view group to update',
})
id: string;
@Type(() => UpdateViewGroupInputUpdates)
@ValidateNested()
@Field(() => UpdateViewGroupInputUpdates, {
description: 'The view group to update',
})
update: UpdateViewGroupInputUpdates;
}
@@ -57,7 +57,7 @@ export class ViewGroupEntity extends SyncableEntity {
updatedAt: Date;
@DeleteDateColumn({ type: 'timestamptz' })
deletedAt?: Date | null;
deletedAt: Date | null;
@ManyToOne(() => Workspace, {
onDelete: 'CASCADE',
@@ -1,14 +1,17 @@
import { UseFilters, UseGuards } from '@nestjs/common';
import { Args, Mutation, Query, Resolver } from '@nestjs/graphql';
import { isDefined } from 'twenty-shared/utils';
import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
import { WorkspaceAuthGuard } from 'src/engine/guards/workspace-auth.guard';
import { CreateViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/create-view-group.input';
import { DeleteViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/delete-view-group.input';
import { DestroyViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/destroy-view-group.input';
import { UpdateViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/update-view-group.input';
import { ViewGroupDTO } from 'src/engine/metadata-modules/view-group/dtos/view-group.dto';
import { ViewGroupV2Service } from 'src/engine/metadata-modules/view-group/services/view-group-v2.service';
import { ViewGroupService } from 'src/engine/metadata-modules/view-group/services/view-group.service';
import { ViewGraphqlApiExceptionFilter } from 'src/engine/metadata-modules/view/utils/view-graphql-api-exception.filter';
@@ -16,7 +19,11 @@ import { ViewGraphqlApiExceptionFilter } from 'src/engine/metadata-modules/view/
@UseFilters(ViewGraphqlApiExceptionFilter)
@UseGuards(WorkspaceAuthGuard)
export class ViewGroupResolver {
constructor(private readonly viewGroupService: ViewGroupService) {}
constructor(
private readonly viewGroupService: ViewGroupService,
private readonly featureFlagService: FeatureFlagService,
private readonly viewGroupV2Service: ViewGroupV2Service,
) {}
@Query(() => [ViewGroupDTO])
async getCoreViewGroups(
@@ -41,47 +48,104 @@ export class ViewGroupResolver {
@Mutation(() => ViewGroupDTO)
async createCoreViewGroup(
@Args('input') input: CreateViewGroupInput,
@AuthWorkspace() workspace: Workspace,
@Args('input') createViewGroupInput: CreateViewGroupInput,
@AuthWorkspace() { id: workspaceId }: Workspace,
): Promise<ViewGroupDTO> {
const isWorkspaceMigrationV2Enabled =
await this.featureFlagService.isFeatureEnabled(
FeatureFlagKey.IS_WORKSPACE_MIGRATION_V2_ENABLED,
workspaceId,
);
if (isWorkspaceMigrationV2Enabled) {
return await this.viewGroupV2Service.createOne({
createViewGroupInput,
workspaceId,
});
}
return this.viewGroupService.create({
...input,
workspaceId: workspace.id,
...createViewGroupInput,
workspaceId,
});
}
@Mutation(() => ViewGroupDTO)
async updateCoreViewGroup(
@Args('id', { type: () => String }) id: string,
@Args('input') input: UpdateViewGroupInput,
@AuthWorkspace() workspace: Workspace,
@Args('input') updateViewGroupInput: UpdateViewGroupInput,
@AuthWorkspace() { id: workspaceId }: Workspace,
): Promise<ViewGroupDTO> {
return this.viewGroupService.update(id, workspace.id, input);
const isWorkspaceMigrationV2Enabled =
await this.featureFlagService.isFeatureEnabled(
FeatureFlagKey.IS_WORKSPACE_MIGRATION_V2_ENABLED,
workspaceId,
);
if (isWorkspaceMigrationV2Enabled) {
return await this.viewGroupV2Service.updateOne({
updateViewGroupInput,
workspaceId,
});
}
return this.viewGroupService.update(
updateViewGroupInput.id,
workspaceId,
updateViewGroupInput.update,
);
}
@Mutation(() => Boolean)
@Mutation(() => ViewGroupDTO)
async deleteCoreViewGroup(
@Args('id', { type: () => String }) id: string,
@AuthWorkspace() workspace: Workspace,
): Promise<boolean> {
@Args('input') deleteViewGroupInput: DeleteViewGroupInput,
@AuthWorkspace() { id: workspaceId }: Workspace,
): Promise<ViewGroupDTO> {
const isWorkspaceMigrationV2Enabled =
await this.featureFlagService.isFeatureEnabled(
FeatureFlagKey.IS_WORKSPACE_MIGRATION_V2_ENABLED,
workspaceId,
);
if (isWorkspaceMigrationV2Enabled) {
return await this.viewGroupV2Service.deleteOne({
deleteViewGroupInput,
workspaceId,
});
}
const deletedViewGroup = await this.viewGroupService.delete(
id,
workspace.id,
deleteViewGroupInput.id,
workspaceId,
);
return isDefined(deletedViewGroup);
return deletedViewGroup;
}
@Mutation(() => Boolean)
@Mutation(() => ViewGroupDTO)
async destroyCoreViewGroup(
@Args('id', { type: () => String }) id: string,
@AuthWorkspace() workspace: Workspace,
): Promise<boolean> {
const deletedViewGroup = await this.viewGroupService.destroy(
id,
workspace.id,
@Args('input') destroyViewGroupInput: DestroyViewGroupInput,
@AuthWorkspace() { id: workspaceId }: Workspace,
): Promise<ViewGroupDTO> {
const isWorkspaceMigrationV2Enabled =
await this.featureFlagService.isFeatureEnabled(
FeatureFlagKey.IS_WORKSPACE_MIGRATION_V2_ENABLED,
workspaceId,
);
if (isWorkspaceMigrationV2Enabled) {
const destroyedViewGroup = await this.viewGroupV2Service.destroyOne({
destroyViewGroupInput,
workspaceId,
});
return destroyedViewGroup;
}
const destroyedViewGroup = await this.viewGroupService.destroy(
destroyViewGroupInput.id,
workspaceId,
);
return isDefined(deletedViewGroup);
return destroyedViewGroup;
}
}
@@ -315,7 +315,7 @@ describe('ViewGroupService', () => {
expect(viewGroupService.findById).toHaveBeenCalledWith(id, workspaceId);
expect(viewGroupRepository.delete).toHaveBeenCalledWith(id);
expect(result).toEqual(true);
expect(result).toEqual(mockViewGroup);
});
});
});
@@ -0,0 +1,323 @@
import { Injectable } from '@nestjs/common';
import { isDefined } from 'twenty-shared/utils';
import { EMPTY_FLAT_ENTITY_MAPS } from 'src/engine/metadata-modules/flat-entity/constant/empty-flat-entity-maps.constant';
import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
import { addFlatEntityToFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/add-flat-entity-to-flat-entity-maps-or-throw.util';
import { deleteFlatEntityFromFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/delete-flat-entity-from-flat-entity-maps-or-throw.util';
import { findFlatEntityByIdInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps-or-throw.util';
import { getSubFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/get-sub-flat-entity-maps-or-throw.util';
import { replaceFlatEntityInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/replace-flat-entity-in-flat-entity-maps-or-throw.util';
import { fromCreateViewGroupInputToFlatViewGroupToCreate } from 'src/engine/metadata-modules/flat-view-group/utils/from-create-view-group-input-to-flat-view-group-to-create.util';
import { fromDeleteViewGroupInputToFlatViewGroupOrThrow } from 'src/engine/metadata-modules/flat-view-group/utils/from-delete-view-group-input-to-flat-view-group-or-throw.util';
import { fromDestroyViewGroupInputToFlatViewGroupOrThrow } from 'src/engine/metadata-modules/flat-view-group/utils/from-destroy-view-group-input-to-flat-view-group-or-throw.util';
import { fromUpdateViewGroupInputToFlatViewGroupToUpdateOrThrow } from 'src/engine/metadata-modules/flat-view-group/utils/from-update-view-group-input-to-flat-view-group-to-update-or-throw.util';
import { CreateViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/create-view-group.input';
import { DeleteViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/delete-view-group.input';
import { DestroyViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/destroy-view-group.input';
import { UpdateViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/update-view-group.input';
import { ViewGroupDTO } from 'src/engine/metadata-modules/view-group/dtos/view-group.dto';
import { WorkspaceMigrationBuilderExceptionV2 } from 'src/engine/workspace-manager/workspace-migration-v2/exceptions/workspace-migration-builder-exception-v2';
import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration-v2/services/workspace-migration-validate-build-and-run-service';
@Injectable()
export class ViewGroupV2Service {
constructor(
private readonly workspaceMigrationValidateBuildAndRunService: WorkspaceMigrationValidateBuildAndRunService,
private readonly flatEntityMapsCacheService: WorkspaceManyOrAllFlatEntityMapsCacheService,
) {}
async createOne({
createViewGroupInput,
workspaceId,
}: {
createViewGroupInput: CreateViewGroupInput;
workspaceId: string;
}): Promise<ViewGroupDTO> {
const {
flatViewGroupMaps: existingFlatViewGroupMaps,
flatViewMaps,
flatFieldMetadataMaps,
} = await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
{
workspaceId,
flatMapsKeys: [
'flatViewGroupMaps',
'flatViewMaps',
'flatFieldMetadataMaps',
],
},
);
const flatViewGroupToCreate =
fromCreateViewGroupInputToFlatViewGroupToCreate({
createViewGroupInput,
workspaceId,
});
const toFlatViewGroupMaps = addFlatEntityToFlatEntityMapsOrThrow({
flatEntity: flatViewGroupToCreate,
flatEntityMaps: existingFlatViewGroupMaps,
});
const validateAndBuildResult =
await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(
{
fromToAllFlatEntityMaps: {
flatViewGroupMaps: {
from: existingFlatViewGroupMaps,
to: toFlatViewGroupMaps,
},
},
dependencyAllFlatEntityMaps: {
flatFieldMetadataMaps,
flatViewMaps,
},
buildOptions: {
isSystemBuild: false,
inferDeletionFromMissingEntities: false,
},
workspaceId,
},
);
if (isDefined(validateAndBuildResult)) {
throw new WorkspaceMigrationBuilderExceptionV2(
validateAndBuildResult,
'Multiple validation errors occurred while creating view group',
);
}
const { flatViewGroupMaps: recomputedExistingFlatViewGroupMaps } =
await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
{
workspaceId,
flatMapsKeys: ['flatViewGroupMaps'],
},
);
return findFlatEntityByIdInFlatEntityMapsOrThrow({
flatEntityId: flatViewGroupToCreate.id,
flatEntityMaps: recomputedExistingFlatViewGroupMaps,
});
}
async updateOne({
updateViewGroupInput,
workspaceId,
}: {
workspaceId: string;
updateViewGroupInput: UpdateViewGroupInput;
}): Promise<ViewGroupDTO> {
const {
flatViewGroupMaps: existingFlatViewGroupMaps,
flatViewMaps,
flatFieldMetadataMaps,
} = await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
{
workspaceId,
flatMapsKeys: [
'flatViewGroupMaps',
'flatViewMaps',
'flatFieldMetadataMaps',
],
},
);
const optimisticallyUpdatedFlatViewGroup =
fromUpdateViewGroupInputToFlatViewGroupToUpdateOrThrow({
flatViewGroupMaps: existingFlatViewGroupMaps,
updateViewGroupInput,
});
const toFlatViewGroupMaps = addFlatEntityToFlatEntityMapsOrThrow({
flatEntity: optimisticallyUpdatedFlatViewGroup,
flatEntityMaps: EMPTY_FLAT_ENTITY_MAPS,
});
const validateAndBuildResult =
await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(
{
fromToAllFlatEntityMaps: {
flatViewGroupMaps: {
from: existingFlatViewGroupMaps,
to: toFlatViewGroupMaps,
},
},
dependencyAllFlatEntityMaps: {
flatViewMaps,
flatFieldMetadataMaps,
},
buildOptions: {
isSystemBuild: false,
inferDeletionFromMissingEntities: false,
},
workspaceId,
},
);
if (isDefined(validateAndBuildResult)) {
throw new WorkspaceMigrationBuilderExceptionV2(
validateAndBuildResult,
'Multiple validation errors occurred while updating view group',
);
}
const { flatViewGroupMaps: recomputedExistingFlatViewGroupMaps } =
await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
{
workspaceId,
flatMapsKeys: ['flatViewGroupMaps'],
},
);
return findFlatEntityByIdInFlatEntityMapsOrThrow({
flatEntityId: optimisticallyUpdatedFlatViewGroup.id,
flatEntityMaps: recomputedExistingFlatViewGroupMaps,
});
}
async deleteOne({
deleteViewGroupInput,
workspaceId,
}: {
deleteViewGroupInput: DeleteViewGroupInput;
workspaceId: string;
}): Promise<ViewGroupDTO> {
const {
flatViewGroupMaps: existingFlatViewGroupMaps,
flatViewMaps,
flatFieldMetadataMaps,
} = await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
{
workspaceId,
flatMapsKeys: [
'flatViewGroupMaps',
'flatViewMaps',
'flatFieldMetadataMaps',
],
},
);
const optimisticallyUpdatedFlatViewGroupWithDeletedAt =
fromDeleteViewGroupInputToFlatViewGroupOrThrow({
flatViewGroupMaps: existingFlatViewGroupMaps,
deleteViewGroupInput,
});
const toFlatViewGroupMaps = replaceFlatEntityInFlatEntityMapsOrThrow({
flatEntity: optimisticallyUpdatedFlatViewGroupWithDeletedAt,
flatEntityMaps: existingFlatViewGroupMaps,
});
const validateAndBuildResult =
await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(
{
fromToAllFlatEntityMaps: {
flatViewGroupMaps: {
from: existingFlatViewGroupMaps,
to: toFlatViewGroupMaps,
},
},
dependencyAllFlatEntityMaps: {
flatFieldMetadataMaps,
flatViewMaps,
},
buildOptions: {
isSystemBuild: false,
inferDeletionFromMissingEntities: false,
},
workspaceId,
},
);
if (isDefined(validateAndBuildResult)) {
throw new WorkspaceMigrationBuilderExceptionV2(
validateAndBuildResult,
'Multiple validation errors occurred while deleting view group',
);
}
const { flatViewGroupMaps: recomputedExistingFlatViewGroupMaps } =
await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
{
workspaceId,
flatMapsKeys: ['flatViewGroupMaps'],
},
);
return findFlatEntityByIdInFlatEntityMapsOrThrow({
flatEntityId: optimisticallyUpdatedFlatViewGroupWithDeletedAt.id,
flatEntityMaps: recomputedExistingFlatViewGroupMaps,
});
}
async destroyOne({
destroyViewGroupInput,
workspaceId,
}: {
destroyViewGroupInput: DestroyViewGroupInput;
workspaceId: string;
}): Promise<ViewGroupDTO> {
const {
flatViewGroupMaps: existingFlatViewGroupMaps,
flatViewMaps: existingFlatViewMaps,
flatFieldMetadataMaps: existingFlatFieldMetadataMaps,
} = await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
{
workspaceId,
flatMapsKeys: [
'flatViewGroupMaps',
'flatViewMaps',
'flatFieldMetadataMaps',
],
},
);
const existingViewGroupToDelete =
fromDestroyViewGroupInputToFlatViewGroupOrThrow({
destroyViewGroupInput,
flatViewGroupMaps: existingFlatViewGroupMaps,
});
const fromFlatViewGroupMaps = getSubFlatEntityMapsOrThrow({
flatEntityIds: [existingViewGroupToDelete.id],
flatEntityMaps: existingFlatViewGroupMaps,
});
const toFlatViewGroupMaps = deleteFlatEntityFromFlatEntityMapsOrThrow({
flatEntityMaps: fromFlatViewGroupMaps,
entityToDeleteId: existingViewGroupToDelete.id,
});
const validateAndBuildResult =
await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(
{
fromToAllFlatEntityMaps: {
flatViewGroupMaps: {
from: fromFlatViewGroupMaps,
to: toFlatViewGroupMaps,
},
},
dependencyAllFlatEntityMaps: {
flatViewMaps: existingFlatViewMaps,
flatFieldMetadataMaps: existingFlatFieldMetadataMaps,
},
buildOptions: {
isSystemBuild: false,
inferDeletionFromMissingEntities: true,
},
workspaceId,
},
);
if (isDefined(validateAndBuildResult)) {
throw new WorkspaceMigrationBuilderExceptionV2(
validateAndBuildResult,
'Multiple validation errors occurred while destroying view group',
);
}
return existingViewGroupToDelete;
}
}
@@ -168,7 +168,7 @@ export class ViewGroupService {
return viewGroup;
}
async destroy(id: string, workspaceId: string): Promise<boolean> {
async destroy(id: string, workspaceId: string): Promise<ViewGroupEntity> {
const viewGroup = await this.findById(id, workspaceId);
if (!isDefined(viewGroup)) {
@@ -185,7 +185,7 @@ export class ViewGroupService {
await this.flushGraphQLCache(workspaceId);
return true;
return viewGroup;
}
private async flushGraphQLCache(workspaceId: string): Promise<void> {
@@ -1,19 +1,26 @@
import { Module } from '@nestjs/common';
import { TypeOrmModule } from '@nestjs/typeorm';
import { FeatureFlagModule } from 'src/engine/core-modules/feature-flag/feature-flag.module';
import { WorkspaceManyOrAllFlatEntityMapsCacheModule } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.module';
import { ViewGroupController } from 'src/engine/metadata-modules/view-group/controllers/view-group.controller';
import { ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
import { ViewGroupResolver } from 'src/engine/metadata-modules/view-group/resolvers/view-group.resolver';
import { ViewGroupV2Service } from 'src/engine/metadata-modules/view-group/services/view-group-v2.service';
import { ViewGroupService } from 'src/engine/metadata-modules/view-group/services/view-group.service';
import { WorkspaceCacheStorageModule } from 'src/engine/workspace-cache-storage/workspace-cache-storage.module';
import { WorkspaceMigrationV2Module } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-v2.module';
@Module({
imports: [
TypeOrmModule.forFeature([ViewGroupEntity]),
WorkspaceCacheStorageModule,
FeatureFlagModule,
WorkspaceMigrationV2Module,
WorkspaceManyOrAllFlatEntityMapsCacheModule,
],
controllers: [ViewGroupController],
providers: [ViewGroupService, ViewGroupResolver],
providers: [ViewGroupService, ViewGroupV2Service, ViewGroupResolver],
exports: [ViewGroupService],
})
export class ViewGroupModule {}
@@ -1,9 +1,10 @@
import { SetMetadata } from '@nestjs/common';
import { type ALL_FLAT_ENTITY_MAPS_PROPERTIES } from 'src/engine/metadata-modules/flat-entity/constant/all-flat-entity-maps-properties.constant';
import { type AllMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-metadata-name.type';
import { type MetadataToFlatEntityMapsKey } from 'src/engine/metadata-modules/flat-entity/types/metadata-to-flat-entity-maps-key';
export const WORKSPACE_FLAT_MAP_CACHE_KEY = 'workspaceFlatMapCacheKey';
export const WorkspaceFlatMapCache = (
cacheKey: (typeof ALL_FLAT_ENTITY_MAPS_PROPERTIES)[number],
cacheKey: MetadataToFlatEntityMapsKey<AllMetadataName>,
) => SetMetadata(WORKSPACE_FLAT_MAP_CACHE_KEY, cacheKey);
@@ -8,11 +8,13 @@ import { WorkspaceFlatIndexMapCacheService } from 'src/engine/metadata-modules/f
import { WorkspaceFlatObjectMetadataMapCacheService } from 'src/engine/metadata-modules/flat-object-metadata/services/workspace-flat-object-metadata-map-cache.service';
import { WorkspaceFlatViewFieldMapCacheService } from 'src/engine/metadata-modules/flat-view-field/services/workspace-flat-view-field-map-cache.service';
import { WorkspaceFlatViewFilterMapCacheService } from 'src/engine/metadata-modules/flat-view-filter/services/workspace-flat-view-filter-map-cache.service';
import { WorkspaceFlatViewGroupMapCacheService } from 'src/engine/metadata-modules/flat-view-group/services/workspace-flat-view-group-map-cache.service';
import { WorkspaceFlatViewMapCacheService } from 'src/engine/metadata-modules/flat-view/services/workspace-flat-view-map-cache.service';
import { IndexMetadataEntity } from 'src/engine/metadata-modules/index-metadata/index-metadata.entity';
import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
import { ViewFieldEntity } from 'src/engine/metadata-modules/view-field/entities/view-field.entity';
import { ViewFilterEntity } from 'src/engine/metadata-modules/view-filter/entities/view-filter.entity';
import { ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
import { ViewEntity } from 'src/engine/metadata-modules/view/entities/view.entity';
import { WorkspaceMetadataCacheModule } from 'src/engine/metadata-modules/workspace-metadata-cache/workspace-metadata-cache.module';
import { WorkspaceMetadataVersionModule } from 'src/engine/metadata-modules/workspace-metadata-version/workspace-metadata-version.module';
@@ -32,6 +34,7 @@ import { WorkspaceFlatMapCacheRegistryService } from 'src/engine/workspace-flat-
IndexMetadataEntity,
FieldMetadataEntity,
ObjectMetadataEntity,
ViewGroupEntity,
]),
],
providers: [
@@ -42,6 +45,7 @@ import { WorkspaceFlatMapCacheRegistryService } from 'src/engine/workspace-flat-
WorkspaceFlatViewFilterMapCacheService,
WorkspaceFlatIndexMapCacheService,
WorkspaceFlatFieldMetadataMapCacheService,
WorkspaceFlatViewGroupMapCacheService,
],
exports: [
WorkspaceFlatMapCacheRegistryService,
@@ -51,6 +55,7 @@ import { WorkspaceFlatMapCacheRegistryService } from 'src/engine/workspace-flat-
WorkspaceFlatViewFilterMapCacheService,
WorkspaceFlatIndexMapCacheService,
WorkspaceFlatFieldMetadataMapCacheService,
WorkspaceFlatViewGroupMapCacheService,
],
})
export class WorkspaceFlatMapCacheModule {}
@@ -0,0 +1,12 @@
import { ALL_METADATA_NAME } from 'src/engine/metadata-modules/flat-entity/constant/all-metadata-name.constant';
import { type OrchestratorFailureReport } from 'src/engine/workspace-manager/workspace-migration-v2/types/workspace-migration-orchestrator.type';
export const EMPTY_ORCHESTRATOR_FAILURE_REPORT = (
Object.keys(ALL_METADATA_NAME) as (keyof typeof ALL_METADATA_NAME)[]
).reduce(
(orchestratorReport, metadataName) => ({
...orchestratorReport,
[metadataName]: [],
}),
{} as OrchestratorFailureReport,
);
@@ -1,5 +1,6 @@
import { type I18n } from '@lingui/core';
import { EMPTY_ORCHESTRATOR_FAILURE_REPORT } from 'src/engine/workspace-manager/workspace-migration-v2/constant/empty-orchestrator-failure-report.constant';
import { type WorkspaceMigrationBuilderExceptionV2 } from 'src/engine/workspace-manager/workspace-migration-v2/exceptions/workspace-migration-builder-exception-v2';
import { type ValidationErrorResponse } from 'src/engine/workspace-manager/workspace-migration-v2/interceptors/types/validate-error-response.type';
import { translateOrchestratorFailureReport } from 'src/engine/workspace-manager/workspace-migration-v2/interceptors/utils/translate-validation-errors.util';
@@ -20,20 +21,10 @@ export const fromWorkspaceMigrationBuilderExceptionToValidationResponseError = (
invalidCronTrigger: 0,
invalidRouteTrigger: 0,
invalidFieldMetadata: 0,
invalidViewGroup: 0,
totalErrors: 0,
},
errors: {
fieldMetadata: [],
index: [],
objectMetadata: [],
view: [],
viewField: [],
serverlessFunction: [],
databaseEventTrigger: [],
cronTrigger: [],
routeTrigger: [],
viewFilter: [],
},
errors: EMPTY_ORCHESTRATOR_FAILURE_REPORT,
};
const report =
@@ -5,8 +5,8 @@ import { isDefined } from 'twenty-shared/utils';
import { EMPTY_ALL_FLAT_ENTITY_MAPS } from 'src/engine/metadata-modules/flat-entity/constant/empty-all-flat-entity-maps.constant';
import { AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';
import { EMPTY_ORCHESTRATOR_ACTIONS_REPORT } from 'src/engine/workspace-manager/workspace-migration-v2/constant/empty-orchestrator-actions-report.constant';
import { EMPTY_ORCHESTRATOR_FAILURE_REPORT } from 'src/engine/workspace-manager/workspace-migration-v2/constant/empty-orchestrator-failure-report.constant';
import {
OrchestratorFailureReport,
WorkspaceMigrationOrchestratorBuildArgs,
WorkspaceMigrationOrchestratorFailedResult,
WorkspaceMigrationOrchestratorSuccessfulResult,
@@ -21,7 +21,9 @@ import { WorkspaceMigrationV2RouteTriggerActionsBuilderService } from 'src/engin
import { WorkspaceMigrationV2ServerlessFunctionActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/serverless-function/workspace-migration-v2-serverless-function-actions-builder.service';
import { WorkspaceMigrationV2ViewFieldActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-field/workspace-migration-v2-view-field-actions-builder.service';
import { WorkspaceMigrationV2ViewFilterActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-filter/workspace-migration-v2-view-filter-actions-builder.service';
import { WorkspaceMigrationV2ViewGroupActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-group/workspace-migration-v2-view-group-actions-builder.service';
import { WorkspaceMigrationV2ViewActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view/workspace-migration-v2-view-actions-builder.service';
@Injectable()
export class WorkspaceMigrationBuildOrchestratorService {
constructor(
@@ -30,6 +32,7 @@ export class WorkspaceMigrationBuildOrchestratorService {
private readonly workspaceMigrationV2ViewActionsBuilderService: WorkspaceMigrationV2ViewActionsBuilderService,
private readonly workspaceMigrationV2ViewFieldActionsBuilderService: WorkspaceMigrationV2ViewFieldActionsBuilderService,
private readonly workspaceMigrationV2ViewFilterActionsBuilderService: WorkspaceMigrationV2ViewFilterActionsBuilderService,
private readonly workspaceMigrationV2ViewGroupActionsBuilderService: WorkspaceMigrationV2ViewGroupActionsBuilderService,
private readonly workspaceMigrationV2ServerlessFunctionActionsBuilderService: WorkspaceMigrationV2ServerlessFunctionActionsBuilderService,
private readonly workspaceMigrationV2DatabaseEventTriggerActionsBuilderService: WorkspaceMigrationV2DatabaseEventTriggerActionsBuilderService,
private readonly workspaceMigrationV2CronTriggerActionsBuilderService: WorkspaceMigrationV2CronTriggerActionsBuilderService,
@@ -80,18 +83,9 @@ export class WorkspaceMigrationBuildOrchestratorService {
const orchestratorActionsReport = structuredClone({
...EMPTY_ORCHESTRATOR_ACTIONS_REPORT,
});
const orchestratorFailureReport: OrchestratorFailureReport = {
objectMetadata: [],
view: [],
viewField: [],
index: [],
serverlessFunction: [],
databaseEventTrigger: [],
cronTrigger: [],
routeTrigger: [],
fieldMetadata: [],
viewFilter: [],
};
const orchestratorFailureReport = structuredClone(
EMPTY_ORCHESTRATOR_FAILURE_REPORT,
);
const optimisticAllFlatEntityMaps = this.setupOptimisticCache({
fromToAllFlatEntityMaps,
@@ -108,6 +102,7 @@ export class WorkspaceMigrationBuildOrchestratorService {
flatRouteTriggerMaps,
flatFieldMetadataMaps,
flatViewFilterMaps,
flatViewGroupMaps,
} = fromToAllFlatEntityMaps;
if (isDefined(flatObjectMetadataMaps)) {
@@ -302,6 +297,36 @@ export class WorkspaceMigrationBuildOrchestratorService {
}
}
if (isDefined(flatViewGroupMaps)) {
const { from: fromFlatViewGroupMaps, to: toFlatViewGroupMaps } =
flatViewGroupMaps;
const viewGroupResult =
await this.workspaceMigrationV2ViewGroupActionsBuilderService.validateAndBuild(
{
from: fromFlatViewGroupMaps,
to: toFlatViewGroupMaps,
buildOptions,
dependencyOptimisticFlatEntityMaps: {
flatFieldMetadataMaps:
optimisticAllFlatEntityMaps.flatFieldMetadataMaps,
flatViewMaps: optimisticAllFlatEntityMaps.flatViewMaps,
},
workspaceId,
},
);
optimisticAllFlatEntityMaps.flatViewGroupMaps =
viewGroupResult.optimisticFlatEntityMaps;
optimisticAllFlatEntityMaps.flatViewMaps =
viewGroupResult.dependencyOptimisticFlatEntityMaps.flatViewMaps;
if (viewGroupResult.status === 'fail') {
orchestratorFailureReport.viewGroup.push(...viewGroupResult.errors);
} else {
orchestratorActionsReport.viewGroup = viewGroupResult.actions;
}
}
if (isDefined(flatServerlessFunctionMaps)) {
const {
from: fromFlatServerlessFunctionMaps,
@@ -471,6 +496,9 @@ export class WorkspaceMigrationBuildOrchestratorService {
...aggregatedOrchestratorActionsReport.viewFilter.deleted,
...aggregatedOrchestratorActionsReport.viewFilter.created,
...aggregatedOrchestratorActionsReport.viewFilter.updated,
...aggregatedOrchestratorActionsReport.viewGroup.deleted,
...aggregatedOrchestratorActionsReport.viewGroup.created,
...aggregatedOrchestratorActionsReport.viewGroup.updated,
///
// Serverless functions
@@ -0,0 +1,26 @@
import { type FlatEntityPropertiesUpdates } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-properties-updates.type';
import { type FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
export type CreateViewGroupAction = {
type: 'create_view_group';
viewGroup: FlatViewGroup;
};
export type UpdateViewGroupAction = {
type: 'update_view_group';
viewGroupId: string;
updates: FlatEntityPropertiesUpdates<'viewGroup'>;
};
export type DeleteViewGroupAction = {
type: 'delete_view_group';
viewGroupId: string;
};
export type WorkspaceMigrationViewGroupActionV2 =
| CreateViewGroupAction
| UpdateViewGroupAction
| DeleteViewGroupAction;
export type WorkspaceMigrationViewGroupActionTypeV2 =
WorkspaceMigrationViewGroupActionV2['type'];
@@ -0,0 +1,164 @@
import { Injectable } from '@nestjs/common';
import { isDefined } from 'twenty-shared/utils';
import { ALL_METADATA_NAME } from 'src/engine/metadata-modules/flat-entity/constant/all-metadata-name.constant';
import { findFlatEntityByIdInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps-or-throw.util';
import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps.util';
import { replaceFlatEntityInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/replace-flat-entity-in-flat-entity-maps-or-throw.util';
import { UpdateViewGroupAction } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-group/types/workspace-migration-view-group-action-v2.type';
import { WorkspaceEntityMigrationBuilderV2Service } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/services/workspace-entity-migration-builder-v2.service';
import { FlatEntityUpdateValidationArgs } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/types/flat-entity-update-validation-args.type';
import { FlatEntityValidationArgs } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/types/flat-entity-validation-args.type';
import { FlatEntityValidationReturnType } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/types/flat-entity-validation-result.type';
import { FlatViewGroupValidatorService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/services/flat-view-group-validator.service';
@Injectable()
export class WorkspaceMigrationV2ViewGroupActionsBuilderService extends WorkspaceEntityMigrationBuilderV2Service<
typeof ALL_METADATA_NAME.viewGroup
> {
constructor(
private readonly flatViewGroupValidatorService: FlatViewGroupValidatorService,
) {
super(ALL_METADATA_NAME.viewGroup);
}
protected async validateFlatEntityCreation(
args: FlatEntityValidationArgs<typeof ALL_METADATA_NAME.viewGroup>,
): Promise<
FlatEntityValidationReturnType<
typeof ALL_METADATA_NAME.viewGroup,
'created'
>
> {
const validationResult =
this.flatViewGroupValidatorService.validateFlatViewGroupCreation(args);
if (validationResult.errors.length > 0) {
return {
status: 'fail',
...validationResult,
};
}
const {
flatEntityToValidate: flatViewGroupToValidate,
dependencyOptimisticFlatEntityMaps,
} = args;
const flatView = findFlatEntityByIdInFlatEntityMapsOrThrow({
flatEntityId: flatViewGroupToValidate.viewId,
flatEntityMaps: dependencyOptimisticFlatEntityMaps.flatViewMaps,
});
const updatedFlatViewMaps = replaceFlatEntityInFlatEntityMapsOrThrow({
flatEntity: {
...flatView,
viewGroupIds: [...flatView.viewGroupIds, flatViewGroupToValidate.id],
},
flatEntityMaps: dependencyOptimisticFlatEntityMaps.flatViewMaps,
});
return {
status: 'success',
action: {
type: 'create_view_group',
viewGroup: flatViewGroupToValidate,
},
dependencyOptimisticFlatEntityMaps: {
...dependencyOptimisticFlatEntityMaps,
flatViewMaps: updatedFlatViewMaps,
},
};
}
protected async validateFlatEntityDeletion(
args: FlatEntityValidationArgs<typeof ALL_METADATA_NAME.viewGroup>,
): Promise<
FlatEntityValidationReturnType<
typeof ALL_METADATA_NAME.viewGroup,
'deleted'
>
> {
const validationResult =
this.flatViewGroupValidatorService.validateFlatViewGroupDeletion(args);
if (validationResult.errors.length > 0) {
return {
status: 'fail',
...validationResult,
};
}
const {
flatEntityToValidate: flatViewGroupToValidate,
dependencyOptimisticFlatEntityMaps,
} = args;
const flatView = findFlatEntityByIdInFlatEntityMaps({
flatEntityId: flatViewGroupToValidate.viewId,
flatEntityMaps: dependencyOptimisticFlatEntityMaps.flatViewMaps,
});
const updatedFlatViewMaps = isDefined(flatView)
? replaceFlatEntityInFlatEntityMapsOrThrow({
flatEntity: {
...flatView,
viewGroupIds: flatView.viewGroupIds.filter(
(id) => id !== flatViewGroupToValidate.id,
),
},
flatEntityMaps: dependencyOptimisticFlatEntityMaps.flatViewMaps,
})
: dependencyOptimisticFlatEntityMaps.flatViewMaps;
return {
status: 'success',
action: {
type: 'delete_view_group',
viewGroupId: flatViewGroupToValidate.id,
},
dependencyOptimisticFlatEntityMaps: {
...dependencyOptimisticFlatEntityMaps,
flatViewMaps: updatedFlatViewMaps,
},
};
}
protected async validateFlatEntityUpdate(
args: FlatEntityUpdateValidationArgs<typeof ALL_METADATA_NAME.viewGroup>,
): Promise<
FlatEntityValidationReturnType<
typeof ALL_METADATA_NAME.viewGroup,
'updated'
>
> {
const validationResult =
this.flatViewGroupValidatorService.validateFlatViewGroupUpdate(args);
if (validationResult.errors.length > 0) {
return {
status: 'fail',
...validationResult,
};
}
const {
dependencyOptimisticFlatEntityMaps,
flatEntityId,
flatEntityUpdates,
} = args;
const updateViewGroupAction: UpdateViewGroupAction = {
type: 'update_view_group',
viewGroupId: flatEntityId,
updates: flatEntityUpdates,
};
return {
status: 'success',
action: updateViewGroupAction,
dependencyOptimisticFlatEntityMaps,
};
}
}
@@ -0,0 +1,184 @@
import { Injectable } from '@nestjs/common';
import { msg, t } from '@lingui/core/macro';
import { isDefined } from 'twenty-shared/utils';
import { ALL_METADATA_NAME } from 'src/engine/metadata-modules/flat-entity/constant/all-metadata-name.constant';
import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps.util';
import { FlatViewGroup } from 'src/engine/metadata-modules/flat-view-group/types/flat-view-group.type';
import { ViewExceptionCode } from 'src/engine/metadata-modules/view/exceptions/view.exception';
import { FailedFlatEntityValidation } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/types/failed-flat-entity-validation.type';
import { FlatEntityUpdateValidationArgs } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/types/flat-entity-update-validation-args.type';
import { FlatEntityValidationArgs } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/types/flat-entity-validation-args.type';
import { fromFlatEntityPropertiesUpdatesToPartialFlatEntity } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/utils/from-flat-entity-properties-updates-to-partial-flat-entity';
@Injectable()
export class FlatViewGroupValidatorService {
public validateFlatViewGroupUpdate({
flatEntityId,
flatEntityUpdates,
optimisticFlatEntityMaps: optimisticFlatViewGroupMaps,
dependencyOptimisticFlatEntityMaps,
}: FlatEntityUpdateValidationArgs<
typeof ALL_METADATA_NAME.viewGroup
>): FailedFlatEntityValidation<FlatViewGroup> {
const validationResult: FailedFlatEntityValidation<FlatViewGroup> = {
type: 'update_view_group',
errors: [],
flatEntityMinimalInformation: {
id: flatEntityId,
},
};
const existingFlatViewGroup =
optimisticFlatViewGroupMaps.byId[flatEntityId];
if (!isDefined(existingFlatViewGroup)) {
validationResult.errors.push({
code: ViewExceptionCode.INVALID_VIEW_DATA,
message: t`View group to update not found`,
userFriendlyMessage: msg`View group to update not found`,
});
return validationResult;
}
const updatedFlatViewGroup = {
...existingFlatViewGroup,
...fromFlatEntityPropertiesUpdatesToPartialFlatEntity({
updates: flatEntityUpdates,
}),
};
validationResult.flatEntityMinimalInformation = {
id: updatedFlatViewGroup.id,
viewId: updatedFlatViewGroup.viewId,
fieldMetadataId: updatedFlatViewGroup.fieldMetadataId,
};
const flatView = findFlatEntityByIdInFlatEntityMaps({
flatEntityId: updatedFlatViewGroup.viewId,
flatEntityMaps: dependencyOptimisticFlatEntityMaps.flatViewMaps,
});
if (!isDefined(flatView)) {
validationResult.errors.push({
code: ViewExceptionCode.INVALID_VIEW_DATA,
message: t`View group to update parent view not found`,
userFriendlyMessage: msg`View group to update parent view not found`,
});
}
const flatFieldMetadata = findFlatEntityByIdInFlatEntityMaps({
flatEntityId: updatedFlatViewGroup.fieldMetadataId,
flatEntityMaps: dependencyOptimisticFlatEntityMaps.flatFieldMetadataMaps,
});
if (!isDefined(flatFieldMetadata)) {
validationResult.errors.push({
code: ViewExceptionCode.INVALID_VIEW_DATA,
message: t`View group to update parent field not found`,
userFriendlyMessage: msg`View group to update parent field not found`,
});
}
return validationResult;
}
public validateFlatViewGroupDeletion({
flatEntityToValidate: { id: viewGroupIdToDelete },
optimisticFlatEntityMaps: optimisticFlatViewGroupMaps,
}: FlatEntityValidationArgs<
typeof ALL_METADATA_NAME.viewGroup
>): FailedFlatEntityValidation<FlatViewGroup> {
const validationResult: FailedFlatEntityValidation<FlatViewGroup> = {
type: 'delete_view_group',
errors: [],
flatEntityMinimalInformation: {
id: viewGroupIdToDelete,
},
};
const existingFlatViewGroup =
optimisticFlatViewGroupMaps.byId[viewGroupIdToDelete];
if (!isDefined(existingFlatViewGroup)) {
validationResult.errors.push({
code: ViewExceptionCode.INVALID_VIEW_DATA,
message: t`View group to delete not found`,
userFriendlyMessage: msg`View group to delete not found`,
});
} else {
if (!isDefined(existingFlatViewGroup.deletedAt)) {
validationResult.errors.push({
code: ViewExceptionCode.INVALID_VIEW_DATA,
message: t`View group to delete has not been soft deleted`,
userFriendlyMessage: msg`View group to delete has not been soft deleted`,
});
}
}
return validationResult;
}
public validateFlatViewGroupCreation({
flatEntityToValidate: flatViewGroupToValidate,
optimisticFlatEntityMaps: optimisticFlatViewGroupMaps,
dependencyOptimisticFlatEntityMaps,
}: FlatEntityValidationArgs<
typeof ALL_METADATA_NAME.viewGroup
>): FailedFlatEntityValidation<FlatViewGroup> {
const validationResult: FailedFlatEntityValidation<FlatViewGroup> = {
type: 'create_view_group',
errors: [],
flatEntityMinimalInformation: {
id: flatViewGroupToValidate.id,
viewId: flatViewGroupToValidate.viewId,
fieldMetadataId: flatViewGroupToValidate.fieldMetadataId,
},
};
const existingFlatViewGroup =
optimisticFlatViewGroupMaps.byId[flatViewGroupToValidate.id];
if (isDefined(existingFlatViewGroup)) {
const flatViewGroupId = flatViewGroupToValidate.id;
validationResult.errors.push({
code: ViewExceptionCode.INVALID_VIEW_DATA,
message: t`View group metadata with id ${flatViewGroupId} already exists`,
userFriendlyMessage: msg`View group metadata already exists`,
});
}
const flatFieldMetadata = findFlatEntityByIdInFlatEntityMaps({
flatEntityId: flatViewGroupToValidate.fieldMetadataId,
flatEntityMaps: dependencyOptimisticFlatEntityMaps.flatFieldMetadataMaps,
});
if (!isDefined(flatFieldMetadata)) {
validationResult.errors.push({
code: ViewExceptionCode.INVALID_VIEW_DATA,
message: t`Field metadata not found`,
userFriendlyMessage: msg`Field metadata not found`,
});
}
const flatView =
dependencyOptimisticFlatEntityMaps.flatViewMaps.byId[
flatViewGroupToValidate.viewId
];
if (!isDefined(flatView)) {
validationResult.errors.push({
code: ViewExceptionCode.INVALID_VIEW_DATA,
message: t`View not found`,
userFriendlyMessage: msg`View not found`,
});
return validationResult;
}
return validationResult;
}
}
@@ -11,6 +11,7 @@ import { FlatRouteTriggerValidatorService } from 'src/engine/workspace-manager/w
import { FlatServerlessFunctionValidatorService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/services/flat-serverless-function-validator.service';
import { FlatViewFieldValidatorService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/services/flat-view-field-validator.service';
import { FlatViewFilterValidatorService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/services/flat-view-filter-validator.service';
import { FlatViewGroupValidatorService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/services/flat-view-group-validator.service';
import { FlatViewValidatorService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/services/flat-view-validator.service';
@Module({
@@ -19,6 +20,7 @@ import { FlatViewValidatorService } from 'src/engine/workspace-manager/workspace
FlatViewValidatorService,
FlatViewFieldValidatorService,
FlatViewFilterValidatorService,
FlatViewGroupValidatorService,
FlatIndexValidatorService,
FlatFieldMetadataValidatorService,
FlatObjectMetadataValidatorService,
@@ -32,6 +34,7 @@ import { FlatViewValidatorService } from 'src/engine/workspace-manager/workspace
FlatViewValidatorService,
FlatViewFieldValidatorService,
FlatViewFilterValidatorService,
FlatViewGroupValidatorService,
FlatIndexValidatorService,
FlatFieldMetadataValidatorService,
FlatObjectMetadataValidatorService,
@@ -11,6 +11,7 @@ import { WorkspaceMigrationV2RouteTriggerActionsBuilderService } from 'src/engin
import { WorkspaceMigrationV2ServerlessFunctionActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/serverless-function/workspace-migration-v2-serverless-function-actions-builder.service';
import { WorkspaceMigrationV2ViewFieldActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-field/workspace-migration-v2-view-field-actions-builder.service';
import { WorkspaceMigrationV2ViewFilterActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-filter/workspace-migration-v2-view-filter-actions-builder.service';
import { WorkspaceMigrationV2ViewGroupActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-group/workspace-migration-v2-view-group-actions-builder.service';
import { WorkspaceMigrationV2ViewActionsBuilderService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view/workspace-migration-v2-view-actions-builder.service';
import { WorkspaceMigrationBuilderValidatorsModule } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/workspace-migration-builder-validators.module';
@@ -22,6 +23,7 @@ import { WorkspaceMigrationBuilderValidatorsModule } from 'src/engine/workspace-
WorkspaceMigrationV2ViewActionsBuilderService,
WorkspaceMigrationV2ViewFieldActionsBuilderService,
WorkspaceMigrationV2ViewFilterActionsBuilderService,
WorkspaceMigrationV2ViewGroupActionsBuilderService,
WorkspaceMigrationV2IndexActionsBuilderService,
WorkspaceMigrationV2ServerlessFunctionActionsBuilderService,
WorkspaceMigrationV2DatabaseEventTriggerActionsBuilderService,
@@ -35,6 +37,7 @@ import { WorkspaceMigrationBuilderValidatorsModule } from 'src/engine/workspace-
WorkspaceMigrationV2ObjectActionsBuilderService,
WorkspaceMigrationV2ViewFieldActionsBuilderService,
WorkspaceMigrationV2ViewFilterActionsBuilderService,
WorkspaceMigrationV2ViewGroupActionsBuilderService,
WorkspaceMigrationV2FieldActionsBuilderService,
WorkspaceMigrationV2ServerlessFunctionActionsBuilderService,
WorkspaceMigrationV2DatabaseEventTriggerActionsBuilderService,
@@ -0,0 +1,55 @@
import { Injectable } from '@nestjs/common';
import {
OptimisticallyApplyActionOnAllFlatEntityMapsArgs,
WorkspaceMigrationRunnerActionHandler,
} from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/interfaces/workspace-migration-runner-action-handler-service.interface';
import { AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';
import { addFlatEntityToFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/add-flat-entity-to-flat-entity-maps-or-throw.util';
import { ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
import { CreateViewGroupAction } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-group/types/workspace-migration-view-group-action-v2.type';
import { WorkspaceMigrationActionRunnerArgs } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/types/workspace-migration-action-runner-args.type';
@Injectable()
export class CreateViewGroupActionHandlerService extends WorkspaceMigrationRunnerActionHandler(
'create_view_group',
) {
optimisticallyApplyActionOnAllFlatEntityMaps({
action,
allFlatEntityMaps,
}: OptimisticallyApplyActionOnAllFlatEntityMapsArgs<CreateViewGroupAction>): Partial<AllFlatEntityMaps> {
const { flatViewGroupMaps } = allFlatEntityMaps;
const { viewGroup } = action;
const updatedFlatViewGroupMaps = addFlatEntityToFlatEntityMapsOrThrow({
flatEntity: viewGroup,
flatEntityMaps: flatViewGroupMaps,
});
return {
flatViewGroupMaps: updatedFlatViewGroupMaps,
};
}
async executeForMetadata(
context: WorkspaceMigrationActionRunnerArgs<CreateViewGroupAction>,
): Promise<void> {
const { action, queryRunner, workspaceId } = context;
const { viewGroup } = action;
const viewGroupRepository =
queryRunner.manager.getRepository<ViewGroupEntity>(ViewGroupEntity);
await viewGroupRepository.insert({
...viewGroup,
workspaceId,
});
}
async executeForWorkspaceSchema(
_context: WorkspaceMigrationActionRunnerArgs<CreateViewGroupAction>,
): Promise<void> {
return;
}
}
@@ -0,0 +1,55 @@
import { Injectable } from '@nestjs/common';
import {
OptimisticallyApplyActionOnAllFlatEntityMapsArgs,
WorkspaceMigrationRunnerActionHandler,
} from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/interfaces/workspace-migration-runner-action-handler-service.interface';
import { AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';
import { deleteFlatEntityFromFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/delete-flat-entity-from-flat-entity-maps-or-throw.util';
import { ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
import { DeleteViewGroupAction } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-group/types/workspace-migration-view-group-action-v2.type';
import { WorkspaceMigrationActionRunnerArgs } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/types/workspace-migration-action-runner-args.type';
@Injectable()
export class DeleteViewGroupActionHandlerService extends WorkspaceMigrationRunnerActionHandler(
'delete_view_group',
) {
optimisticallyApplyActionOnAllFlatEntityMaps({
action,
allFlatEntityMaps,
}: OptimisticallyApplyActionOnAllFlatEntityMapsArgs<DeleteViewGroupAction>): Partial<AllFlatEntityMaps> {
const { flatViewGroupMaps } = allFlatEntityMaps;
const { viewGroupId } = action;
const updatedFlatViewGroupMaps = deleteFlatEntityFromFlatEntityMapsOrThrow({
entityToDeleteId: viewGroupId,
flatEntityMaps: flatViewGroupMaps,
});
return {
flatViewGroupMaps: updatedFlatViewGroupMaps,
};
}
async executeForMetadata(
context: WorkspaceMigrationActionRunnerArgs<DeleteViewGroupAction>,
): Promise<void> {
const { action, queryRunner, workspaceId } = context;
const { viewGroupId } = action;
const viewGroupRepository =
queryRunner.manager.getRepository<ViewGroupEntity>(ViewGroupEntity);
await viewGroupRepository.delete({
id: viewGroupId,
workspaceId,
});
}
async executeForWorkspaceSchema(
_context: WorkspaceMigrationActionRunnerArgs<DeleteViewGroupAction>,
): Promise<void> {
return;
}
}
@@ -0,0 +1,66 @@
import { Injectable } from '@nestjs/common';
import {
OptimisticallyApplyActionOnAllFlatEntityMapsArgs,
WorkspaceMigrationRunnerActionHandler,
} from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/interfaces/workspace-migration-runner-action-handler-service.interface';
import { AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';
import { findFlatEntityByIdInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps-or-throw.util';
import { replaceFlatEntityInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/replace-flat-entity-in-flat-entity-maps-or-throw.util';
import { ViewGroupEntity } from 'src/engine/metadata-modules/view-group/entities/view-group.entity';
import { UpdateViewGroupAction } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/builders/view-group/types/workspace-migration-view-group-action-v2.type';
import { WorkspaceMigrationActionRunnerArgs } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/types/workspace-migration-action-runner-args.type';
import { fromFlatEntityPropertiesUpdatesToPartialFlatEntity } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/utils/from-flat-entity-properties-updates-to-partial-flat-entity';
@Injectable()
export class UpdateViewGroupActionHandlerService extends WorkspaceMigrationRunnerActionHandler(
'update_view_group',
) {
optimisticallyApplyActionOnAllFlatEntityMaps({
action,
allFlatEntityMaps,
}: OptimisticallyApplyActionOnAllFlatEntityMapsArgs<UpdateViewGroupAction>): Partial<AllFlatEntityMaps> {
const { flatViewGroupMaps } = allFlatEntityMaps;
const { viewGroupId } = action;
const existingViewGroup = findFlatEntityByIdInFlatEntityMapsOrThrow({
flatEntityId: viewGroupId,
flatEntityMaps: flatViewGroupMaps,
});
const updatedViewGroup = {
...existingViewGroup,
...fromFlatEntityPropertiesUpdatesToPartialFlatEntity(action),
};
const updatedFlatViewGroupMaps = replaceFlatEntityInFlatEntityMapsOrThrow({
flatEntity: updatedViewGroup,
flatEntityMaps: flatViewGroupMaps,
});
return {
flatViewGroupMaps: updatedFlatViewGroupMaps,
};
}
async executeForMetadata(
context: WorkspaceMigrationActionRunnerArgs<UpdateViewGroupAction>,
): Promise<void> {
const { action, queryRunner } = context;
const { viewGroupId } = action;
const viewGroupRepository =
queryRunner.manager.getRepository<ViewGroupEntity>(ViewGroupEntity);
const update = fromFlatEntityPropertiesUpdatesToPartialFlatEntity(action);
await viewGroupRepository.update(viewGroupId, update);
}
async executeForWorkspaceSchema(
_context: WorkspaceMigrationActionRunnerArgs<UpdateViewGroupAction>,
): Promise<void> {
return;
}
}
@@ -27,6 +27,9 @@ import { UpdateViewFieldActionHandlerService } from 'src/engine/workspace-manage
import { CreateViewFilterActionHandlerService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/action-handlers/view-filter/services/create-view-filter-action-handler.service';
import { DeleteViewFilterActionHandlerService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/action-handlers/view-filter/services/delete-view-filter-action-handler.service';
import { UpdateViewFilterActionHandlerService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/action-handlers/view-filter/services/update-view-filter-action-handler.service';
import { CreateViewGroupActionHandlerService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/action-handlers/view-group/services/create-view-group-action-handler.service';
import { DeleteViewGroupActionHandlerService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/action-handlers/view-group/services/delete-view-group-action-handler.service';
import { UpdateViewGroupActionHandlerService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/action-handlers/view-group/services/update-view-group-action-handler.service';
import { CreateViewActionHandlerService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/action-handlers/view/services/create-view-action-handler.service';
import { DeleteViewActionHandlerService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/action-handlers/view/services/delete-view-action-handler.service';
import { UpdateViewActionHandlerService } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-runner-v2/action-handlers/view/services/update-view-action-handler.service';
@@ -57,6 +60,10 @@ import { UpdateViewActionHandlerService } from 'src/engine/workspace-manager/wor
UpdateViewFilterActionHandlerService,
DeleteViewFilterActionHandlerService,
CreateViewGroupActionHandlerService,
UpdateViewGroupActionHandlerService,
DeleteViewGroupActionHandlerService,
CreateServerlessFunctionActionHandlerService,
DeleteServerlessFunctionActionHandlerService,
UpdateServerlessFunctionActionHandlerService,