From 7aa2afc67e6ab8e4752c21d7a35fdf640a184d2c Mon Sep 17 00:00:00 2001 From: Charles Bochet Date: Mon, 4 May 2026 11:03:23 +0200 Subject: [PATCH] fix(shared): add uuid, @types/uuid, @types/qs for Docker CD (#20222) ## Summary - `twenty-shared` imports `uuid` (in `actor.composite-type.ts` and `createAnyFieldRecordFilterBaseProperties.ts`) and `qs` (in `getAppPath.ts`, `getSettingsPath.ts`), but `uuid` was not declared in `twenty-shared/package.json` and `@types/uuid` / `@types/qs` were missing as devDependencies. - After scoped/hoisted deps (#20140) those types/runtime came from the root `package.json` and are no longer guaranteed in the Docker `common-deps` graph, so `twenty-shared:build` (pulled in before `twenty-website-new` build) fails with `TS7016: Could not find a declaration file for module 'uuid' / 'qs'` in the CD pipeline (see [twenty-infra run 25309442711](https://github.com/twentyhq/twenty-infra/actions/runs/25309442711)). - Same shape of fix as #20219 which added `@types/lodash.camelcase`. ## Test plan - [x] `npx nx build twenty-shared` succeeds locally - [ ] CD pipeline succeeds for `Build website-new` --- packages/twenty-shared/package.json | 3 +++ yarn.lock | 3 +++ 2 files changed, 6 insertions(+) diff --git a/packages/twenty-shared/package.json b/packages/twenty-shared/package.json index d13fc3435a..3524b1dcf0 100644 --- a/packages/twenty-shared/package.json +++ b/packages/twenty-shared/package.json @@ -26,6 +26,8 @@ "@types/jest": "^30.0.0", "@types/lodash.camelcase": "^4.3.7", "@types/lodash.escaperegexp": "^4.1.9", + "@types/qs": "6.9.16", + "@types/uuid": "^9.0.2", "@typescript/native-preview": "^7.0.0-dev.20260116.1", "babel-plugin-module-resolver": "^5.0.2", "glob": "^11.1.0", @@ -54,6 +56,7 @@ "react-router-dom": "^6.4.4", "temporal-polyfill": "^0.3.0", "transliteration": "^2.3.5", + "uuid": "^9.0.0", "zod": "^4.1.11" }, "exports": { diff --git a/yarn.lock b/yarn.lock index 669ffb69af..e6886c0dba 100644 --- a/yarn.lock +++ b/yarn.lock @@ -58279,6 +58279,8 @@ __metadata: "@types/jest": "npm:^30.0.0" "@types/lodash.camelcase": "npm:^4.3.7" "@types/lodash.escaperegexp": "npm:^4.1.9" + "@types/qs": "npm:6.9.16" + "@types/uuid": "npm:^9.0.2" "@typescript/native-preview": "npm:^7.0.0-dev.20260116.1" ai: "npm:6.0.97" babel-plugin-module-resolver: "npm:^5.0.2" @@ -58301,6 +58303,7 @@ __metadata: tsc-alias: "npm:^1.8.16" tsx: "npm:^4.19.3" typescript: "npm:^5.9.2" + uuid: "npm:^9.0.0" vite: "npm:^7.0.0" vite-plugin-dts: "npm:3.8.1" vite-tsconfig-paths: "npm:^4.2.1"