houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Release dashboards V1 (#17386)

Browse Source 
Remove `IS_PAGE_LAYOUT_ENABLED` feature flag entirely
This commit is contained in:
Raphaël Bosi
2026-01-23 11:30:05 +01:00
committed by GitHub
parent b8da15d9d5
commit 78dd43dbb0
10 changed files with 17 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-front/src/modules/favorites/hooks/useWorkspaceFavorites.ts
+2 -17
View File
@@ -6,17 +6,12 @@ import { objectMetadataItemsState } from '@/object-metadata/states/objectMetadat
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
import { coreViewsState } from '@/views/states/coreViewState';
import { convertCoreViewToView } from '@/views/utils/convertCoreViewToView';
import { useFeatureFlagsMap } from '@/workspace/hooks/useFeatureFlagsMap';
import { useMemo } from 'react';
import { useRecoilValue } from 'recoil';
import {
FeatureFlagKey,
FieldMetadataType,
} from '~/generated-metadata/graphql';
import { FieldMetadataType } from '~/generated-metadata/graphql';
import { usePrefetchedFavoritesData } from './usePrefetchedFavoritesData';
export const useWorkspaceFavorites = () => {
const featureFlags = useFeatureFlagsMap();
const { workspaceFavorites } = usePrefetchedFavoritesData();
const coreViews = useRecoilValue(coreViewsState);
const objectMetadataItems = useRecoilValue(objectMetadataItemsState);
@@ -38,17 +33,7 @@ export const useWorkspaceFavorites = () => {
[favoriteObjectMetadataItem.fields],
);
const [dashboardObjectMetadataId] = objectMetadataItems
.filter((item) => item.nameSingular === CoreObjectNameSingular.Dashboard)
.map((item) => item.id);
const views = coreViews
.map(convertCoreViewToView)
.filter(
(view) =>
featureFlags[FeatureFlagKey.IS_PAGE_LAYOUT_ENABLED] === true ||
view.objectMetadataId !== dashboardObjectMetadataId,
);
const views = coreViews.map(convertCoreViewToView);
const sortedWorkspaceFavorites = useMemo(
() =>
packages/twenty-front/src/modules/object-record/record-show/utils/__tests__/evaluateTabVisibility.test.ts
+3 -3
View File
@@ -110,7 +110,7 @@ describe('evaluateTabVisibility', () => {
evaluateTabVisibility(
{
...baseConfig,
ifFeaturesDisabled: [FeatureFlagKey.IS_PAGE_LAYOUT_ENABLED],
ifFeaturesDisabled: [FeatureFlagKey.IS_RECORD_PAGE_LAYOUT_ENABLED],
},
baseContext,
),
@@ -123,7 +123,7 @@ describe('evaluateTabVisibility', () => {
currentWorkspace: {
featureFlags: [
{ key: FeatureFlagKey.IS_AI_ENABLED, value: true },
{ key: FeatureFlagKey.IS_PAGE_LAYOUT_ENABLED, value: true },
{ key: FeatureFlagKey.IS_RECORD_PAGE_LAYOUT_ENABLED, value: true },
],
},
};
@@ -131,7 +131,7 @@ describe('evaluateTabVisibility', () => {
evaluateTabVisibility(
{
...baseConfig,
ifFeaturesDisabled: [FeatureFlagKey.IS_PAGE_LAYOUT_ENABLED],
ifFeaturesDisabled: [FeatureFlagKey.IS_RECORD_PAGE_LAYOUT_ENABLED],
},
ctx,
),