houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Frontend tests improvements (#13115)

Browse Source 
Fix warnings and lower coverage by 0.1%
This commit is contained in:
Félix Malfait
2025-07-09 09:23:26 +02:00
committed by GitHub
parent 6057bdd389
commit 6ba6860e1c
29 changed files with 435 additions and 237 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-front/src/modules/ui/feedback/dialog-manager/hooks/__tests__/useDialogManager.test.tsx
+1 -2
View File
@@ -1,5 +1,4 @@
import { act } from 'react-dom/test-utils';
import { renderHook } from '@testing-library/react';
import { act, renderHook } from '@testing-library/react';
import { RecoilRoot } from 'recoil';
import { v4 as uuidv4 } from 'uuid';
packages/twenty-front/src/modules/ui/feedback/dialog-manager/hooks/internal/__tests__/useDialogManagerScopedStates.test.tsx
+1 -2
View File
@@ -1,5 +1,4 @@
import { act } from 'react-dom/test-utils';
import { renderHook } from '@testing-library/react';
import { act, renderHook } from '@testing-library/react';
import { RecoilRoot } from 'recoil';
import { useDialogManagerScopedStates } from '@/ui/feedback/dialog-manager/hooks/internal/useDialogManagerScopedStates';
packages/twenty-front/src/modules/ui/feedback/snack-bar-manager/hooks/internal/__tests__/useSnackBarManagerScopedStates.test.tsx
+1 -2
View File
@@ -1,5 +1,4 @@
import { act } from 'react-dom/test-utils';
import { renderHook } from '@testing-library/react';
import { act, renderHook } from '@testing-library/react';
import { RecoilRoot } from 'recoil';
import { useSnackBarManagerScopedStates } from '@/ui/feedback/snack-bar-manager/hooks/internal/useSnackBarManagerScopedStates';
packages/twenty-front/src/modules/ui/input/hooks/__tests__/useIconPicker.test.tsx
+1 -1
View File
@@ -1,5 +1,5 @@
import { act } from 'react-dom/test-utils';
import { renderHook } from '@testing-library/react';
import { act } from 'react';
import { RecoilRoot } from 'recoil';
import { useIconPicker } from '@/ui/input/hooks/useIconPicker';
packages/twenty-front/src/modules/ui/layout/selectable-list/hooks/__tests__/useSelectableList.test.ts
+1 -1
View File
@@ -1,5 +1,5 @@
import { renderHook } from '@testing-library/react';
import { act } from 'react-dom/test-utils';
import { act } from 'react';
import { RecoilRoot } from 'recoil';
import { useSelectableList } from '@/ui/layout/selectable-list/hooks/useSelectableList';
packages/twenty-front/src/modules/ui/navigation/step-bar/hooks/__tests__/useStepBar.test.tsx
+1 -2
View File
@@ -1,5 +1,4 @@
import { act } from 'react-dom/test-utils';
import { renderHook } from '@testing-library/react';
import { act, renderHook } from '@testing-library/react';
import { RecoilRoot, useRecoilValue } from 'recoil';
import { stepBarInternalState } from '../../states/stepBarInternalState';
packages/twenty-front/src/modules/ui/utilities/drag-select/components/__tests__/DragSelect.test.tsx
+25 -16
View File
@@ -1,4 +1,5 @@
import { render } from '@testing-library/react';
import { act } from 'react';
import { RecoilRoot } from 'recoil';
import { PointerEventListener } from '@/ui/utilities/pointer-event/types/PointerEventListener';
@@ -70,10 +71,12 @@ describe('DragSelect', () => {
preventDefault: jest.fn(),
};
callbacks.onMouseDown({
x: 150,
y: 150,
event: mockEvent,
act(() => {
callbacks.onMouseDown({
x: 150,
y: 150,
event: mockEvent,
});
});
expect(mockEvent.preventDefault).not.toHaveBeenCalled();
@@ -92,10 +95,12 @@ describe('DragSelect', () => {
preventDefault: jest.fn(),
};
callbacks.onMouseDown({
x: 150,
y: 150,
event: mockEvent,
act(() => {
callbacks.onMouseDown({
x: 150,
y: 150,
event: mockEvent,
});
});
expect(mockEvent.preventDefault).toHaveBeenCalled();
@@ -131,10 +136,12 @@ describe('DragSelect', () => {
.mockReturnValue(mockBoundaryElement);
mockBoundaryElement.contains = jest.fn().mockReturnValue(true);
callbacks.onMouseDown({
x: 150,
y: 150,
event: { target: mockTarget, preventDefault: jest.fn() },
act(() => {
callbacks.onMouseDown({
x: 150,
y: 150,
event: { target: mockTarget, preventDefault: jest.fn() },
});
});
expect(mockSelectableContainer.closest).toHaveBeenCalledWith(
@@ -160,10 +167,12 @@ describe('DragSelect', () => {
mockSelectableContainer.contains = jest.fn().mockReturnValue(true);
expect(() => {
callbacks.onMouseDown({
x: 150,
y: 150,
event: { target: mockTarget, preventDefault: jest.fn() },
act(() => {
callbacks.onMouseDown({
x: 150,
y: 150,
event: { target: mockTarget, preventDefault: jest.fn() },
});
});
}).not.toThrow();
});
packages/twenty-front/src/modules/ui/utilities/drag-select/hooks/__tests__/useDragSelect.test.tsx
+1 -1
View File
@@ -1,5 +1,5 @@
import { act } from 'react-dom/test-utils';
import { renderHook } from '@testing-library/react';
import { act } from 'react';
import { RecoilRoot } from 'recoil';
import { useDragSelect } from '../useDragSelect';
packages/twenty-front/src/modules/ui/utilities/hotkey/hooks/__tests__/useGoToHotkeys.test.tsx
+1 -2
View File
@@ -1,5 +1,4 @@
import { fireEvent, renderHook } from '@testing-library/react';
import { act } from 'react-dom/test-utils';
import { act, fireEvent, renderHook } from '@testing-library/react';
import { MemoryRouter, useLocation } from 'react-router-dom';
import { RecoilRoot } from 'recoil';
packages/twenty-front/src/modules/ui/utilities/recoil-scope/hooks/__tests__/useContextScopeId.test.tsx
+12 -1
View File
@@ -1,5 +1,5 @@
import { createContext } from 'react';
import { renderHook } from '@testing-library/react';
import { createContext } from 'react';
import { useContextScopeId } from '@/ui/utilities/recoil-scope/hooks/useContextScopeId';
@@ -25,8 +25,19 @@ describe('useContextScopeId', () => {
});
it('Should throw an error when used outside of the specified context', () => {
// Suppress console errors for this test since we're expecting an error
/* eslint-disable no-console */
const originalConsoleError = console.error;
console.error = jest.fn();
/* eslint-enable no-console */
expect(() => {
renderHook(() => useContextScopeId(nullContext));
}).toThrow(ERROR_MESSAGE);
// Restore console.error
/* eslint-disable no-console */
console.error = originalConsoleError;
/* eslint-enable no-console */
});
});
packages/twenty-front/src/modules/ui/utilities/recoil-scope/hooks/__tests__/useRecoilScopeId.test.tsx
+12 -1
View File
@@ -1,5 +1,5 @@
import { createContext } from 'react';
import { renderHook } from '@testing-library/react';
import { createContext } from 'react';
import { useRecoilScopeId } from '@/ui/utilities/recoil-scope/hooks/useRecoilScopeId';
@@ -25,8 +25,19 @@ describe('useRecoilScopeId', () => {
});
it('Should throw an error when used outside of the specified context', () => {
// Suppress console errors for this test since we're expecting an error
/* eslint-disable no-console */
const originalConsoleError = console.error;
console.error = jest.fn();
/* eslint-enable no-console */
expect(() => {
renderHook(() => useRecoilScopeId(nullContext));
}).toThrow(ERROR_MESSAGE);
// Restore console.error
/* eslint-disable no-console */
console.error = originalConsoleError;
/* eslint-enable no-console */
});
});