houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Failing morph relation creation v2 integration testing & fixes (#14253)

Browse Source 
# Introduction
closes https://github.com/twentyhq/core-team-issues/issues/1408
This commit is contained in:
Paul Rastoin
2025-09-03 12:14:43 +02:00
committed by GitHub
parent 2e7fe238ed
commit 6522498df0
43 changed files with 4022 additions and 2730 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/services/flat-field-metadata-validator.service.ts
+1 -11
View File
@@ -12,7 +12,6 @@ import { FlatFieldMetadataRelationPropertiesToCompare } from 'src/engine/metadat
import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
import { compareTwoFlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/utils/compare-two-flat-field-metadata.util';
import { isFlatFieldMetadataNameSyncedWithLabel } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-flat-field-metadata-name-synced-with-label.util';
import { isFlatFieldMetadataEntityOfType } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-flat-field-metadata-of-type.util';
import { isMorphOrRelationFlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-morph-or-relation-flat-field-metadata.util';
import { validateFlatFieldMetadataNameAvailability } from 'src/engine/metadata-modules/flat-field-metadata/validators/utils/validate-flat-field-metadata-name-availability.util';
import { validateFlatFieldMetadataName } from 'src/engine/metadata-modules/flat-field-metadata/validators/utils/validate-flat-field-metadata-name.util';
@@ -96,16 +95,7 @@ export class FlatFieldMetadataValidatorService {
toFlatFieldMetadata: updatedFlatFieldMetadata,
});
if (
isFlatFieldMetadataEntityOfType(
updatedFlatFieldMetadata,
FieldMetadataType.RELATION,
) ||
isFlatFieldMetadataEntityOfType(
updatedFlatFieldMetadata,
FieldMetadataType.MORPH_RELATION,
)
) {
if (isMorphOrRelationFlatFieldMetadata(updatedFlatFieldMetadata)) {
const relationNonEditableUpdatedProperties = updates.flatMap(
({ property }) =>
!FLAT_FIELD_METADATA_RELATION_PROPERTIES_TO_COMPARE.includes(