Fix E2E tests + Skip chromatic (#16838)

- Always skip chromatic job (we dont check the outcome)
- Fix workflow creation test
- Run E2E tests before merge (to enable through repo rulesets)
This commit is contained in:
Marie
2025-12-30 16:57:38 +01:00
committed by GitHub
parent 1128331cc1
commit 64d75d0b79
3 changed files with 9 additions and 5 deletions
+4 -3
View File
@@ -7,6 +7,8 @@ on:
pull_request:
merge_group:
permissions:
contents: read
@@ -130,7 +132,7 @@ jobs:
run: npx nx storybook:coverage twenty-front --checkCoverage=true --configuration=${{ matrix.storybook_scope }}
front-chromatic-deployment:
timeout-minutes: 30
if: contains(github.event.pull_request.labels.*.name, 'run-chromatic') || github.event_name == 'push'
if: false
needs: front-sb-build
runs-on: depot-ubuntu-24.04-8
env:
@@ -229,7 +231,7 @@ jobs:
always() &&
needs.changed-files-check-e2e.outputs.any_changed == 'true' &&
(needs.front-build.result == 'success' || needs.front-build.result == 'skipped') &&
(github.event_name == 'push' || (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'run-e2e')))
(github.event_name == 'push' || github.event_name == 'merge_group' || (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'run-e2e')))
timeout-minutes: 30
env:
NODE_OPTIONS: "--max-old-space-size=10240"
@@ -339,7 +341,6 @@ jobs:
changed-files-check,
front-task,
front-build,
front-chromatic-deployment,
merge-reports-and-check-coverage,
front-sb-test,
front-sb-build,