From 638d4015a1e85a3e257322322fc73740b3aa5049 Mon Sep 17 00:00:00 2001 From: Etienne <45695613+etiennejouan@users.noreply.github.com> Date: Mon, 1 Dec 2025 15:43:28 +0100 Subject: [PATCH] Null equivalence - Activate FF for all (#16209) --- .../dev-seeder/core/utils/seed-feature-flags.util.ts | 5 +++++ .../constants/default-feature-flags.ts | 1 + ...uccessful-create-input-by-field-metadata-type.constant.ts | 3 +-- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts index 036b90625f..75eefe3f44 100644 --- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts +++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts @@ -97,6 +97,11 @@ export const seedFeatureFlags = async ({ workspaceId: workspaceId, value: true, }, + { + key: FeatureFlagKey.IS_NULL_EQUIVALENCE_ENABLED, + workspaceId: workspaceId, + value: true, + }, ]) .execute(); }; diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/constants/default-feature-flags.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/constants/default-feature-flags.ts index b3b022fe39..31efe0cd65 100644 --- a/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/constants/default-feature-flags.ts +++ b/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/constants/default-feature-flags.ts @@ -2,4 +2,5 @@ import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/featu export const DEFAULT_FEATURE_FLAGS = [ FeatureFlagKey.IS_WORKSPACE_MIGRATION_V2_ENABLED, + FeatureFlagKey.IS_NULL_EQUIVALENCE_ENABLED, ] as const satisfies FeatureFlagKey[]; diff --git a/packages/twenty-server/test/integration/graphql/suites/inputs-validation/create-validation/constants/successful-create-input-by-field-metadata-type.constant.ts b/packages/twenty-server/test/integration/graphql/suites/inputs-validation/create-validation/constants/successful-create-input-by-field-metadata-type.constant.ts index d67fa7c8f3..c36beb5455 100644 --- a/packages/twenty-server/test/integration/graphql/suites/inputs-validation/create-validation/constants/successful-create-input-by-field-metadata-type.constant.ts +++ b/packages/twenty-server/test/integration/graphql/suites/inputs-validation/create-validation/constants/successful-create-input-by-field-metadata-type.constant.ts @@ -1,7 +1,6 @@ import { type FieldMetadataTypesToTestForCreateInputValidation } from 'test/integration/graphql/suites/inputs-validation/types/field-metadata-type-to-test'; import { TEST_TARGET_OBJECT_RECORD_ID_FIELD_VALUE } from 'test/integration/graphql/suites/inputs-validation/utils/setup-test-objects-with-all-field-types.util'; import { FieldMetadataType } from 'twenty-shared/types'; -import { isEmptyObject } from 'twenty-shared/utils'; export const successfulCreateInputByFieldMetadataType: { [K in Exclude< @@ -135,7 +134,7 @@ export const successfulCreateInputByFieldMetadataType: { rawJsonField: {}, }, validateInput: (record: Record) => { - return isEmptyObject(record.rawJsonField); + return record.rawJsonField === null; }, }, {