refactor: standardize AI acronym to Ai (PascalCase) across internal identifiers (#19837)
## Summary
The "AI" acronym was rendered inconsistently across the codebase. The
backend AI module had settled on PascalCase `Ai` (`AiAgentModule`,
`AiBillingService`, `AiChatModule`, `AiModelRegistryService`, etc.),
while frontend components, several DTOs, a few types, and shared
identifiers still used all-caps `AI` (`AIChatTab`,
`AISystemPromptPreviewDTO`, `SettingsPath.AIPrompts`, ...). CLAUDE.md
specifies PascalCase for classes; this PR normalizes everything internal
to `Ai`.
**This is a pure internal rename.** The GraphQL schema is untouched —
`@ObjectType` decorator string arguments, resolver method names (which
become Query/Mutation field names), gql template contents, and the
`generated-metadata/graphql.ts` file are preserved verbatim. The only
visible change is TypeScript identifiers and file names.
## Also folded in (adjacent cleanups)
- **`AgentModelConfigService` → `AiModelConfigService`**. Lives in
`ai-models/` and is used by multiple AI code paths, not just the Agent
entity. The "Agent" prefix was misleading.
- **`generate-text-input.dto.ts` → `generate-text.input.ts`**. The
`ai-agent/dtos/` folder already uses `<entity>.input.ts` convention for
Input classes (`create-agent.input.ts` etc.); the old path mixed
`.dto.ts` file extension with a class that has no DTO suffix. File
rename only; class stays `GenerateTextInput`.
- **Removed stale TODO** in `ai-model-config.type.ts` that asked for the
`AiModelConfig` rename that this PR performs.
## Rename methodology
Bulk rename via perl with anchored regex
`(?<!['"])(?<![A-Z.])AI([A-Z])(?=[a-z])/Ai$1/g`:
- **Lookbehind for non-uppercase** skips adjacent acronyms (`MOSAIC`,
`OIDCSSO`) and leaves `AIRBNB_ID` alone.
- **Lookbehind for non-quote** protects most string literals.
- **Lookahead for lowercase** restricts matches to PascalCase
identifiers (`AIChatTab`), leaving SCREAMING_SNAKE constants untouched.
Strict file-scope exclusions: `generated-metadata/**`, `generated/**`,
`locales/**`, `migrations/**`, `illustrations/**`, `halftone/**`, and
the two gql template files (`queries/getAISystemPromptPreview.ts`,
`mutations/uploadAIChatFile.ts`).
Post-rename reverts for identifiers where the regex was too eager:
- Backend resolver method names kept: `getAISystemPromptPreview`,
`uploadAIChatFile` (they are GraphQL field names).
- `@ObjectType('AdminAIModels')` / `('AISystemPromptPreview')` /
`('AISystemPromptSection')` kept as-is.
- Backend classes `ClientAIModelConfig` / `AdminAIModelConfig` kept
as-is (they use `@ObjectType()` with no argument, so the class name IS
the schema name).
- External-library symbols restored: `OpenAIProvider`,
`createOpenAICompatible`, `vercelAIIntegration`.
File renames use a two-step rename to work on macOS case-insensitive
filesystems: `git mv X.tsx X.tsx.tmp && git mv X.tsx.tmp renamed.tsx`.
## Diff audit
- 0 changes to migrations
- 0 changes to locale `.po` / `.ts` files
- 0 changes to `generated-metadata/graphql.ts`
- 0 changes to website illustration files (base64 blobs preserved)
- 0 renames inside user-facing translation strings (`t\`…\``,
`msg\`…\``, `<Trans>…</Trans>`)
## Test plan
- [x] `npx nx typecheck twenty-server` — PASS
- [x] `npx nx typecheck twenty-front` — PASS
- [x] `npx jest ai-model admin agent-role` — 79/79 PASS
- [x] `npx oxlint --type-aware` on 118 changed files — 0 errors
- [x] `npx prettier --check` on 118 changed files — clean
- [ ] CI
This commit is contained in:
+8
-8
@@ -39,7 +39,7 @@ export class NativeModelCapabilities {
|
||||
}
|
||||
|
||||
@ObjectType()
|
||||
export class ClientAIModelConfig {
|
||||
export class ClientAiModelConfig {
|
||||
@Field(() => String)
|
||||
// Composite model id (`provider/modelName`) for this workspace; matches registry and admin APIs.
|
||||
modelId: ModelId;
|
||||
@@ -88,7 +88,7 @@ export class ClientAIModelConfig {
|
||||
}
|
||||
|
||||
@ObjectType()
|
||||
export class AdminAIModelConfig {
|
||||
export class AdminAiModelConfig {
|
||||
@Field(() => String)
|
||||
// Composite model id (`provider/modelName`) used for toggles, defaults, and registry lookups.
|
||||
modelId: string;
|
||||
@@ -143,10 +143,10 @@ export class AdminAIModelConfig {
|
||||
dataResidency?: string;
|
||||
}
|
||||
|
||||
@ObjectType('AdminAIModels')
|
||||
export class AdminAIModelsDTO {
|
||||
@Field(() => [AdminAIModelConfig])
|
||||
models: AdminAIModelConfig[];
|
||||
@ObjectType('AdminAiModels')
|
||||
export class AdminAiModelsDTO {
|
||||
@Field(() => [AdminAiModelConfig])
|
||||
models: AdminAiModelConfig[];
|
||||
|
||||
@Field(() => String, { nullable: true })
|
||||
// Composite model id for the default “smart” role (`provider/modelName`).
|
||||
@@ -249,8 +249,8 @@ export class ClientConfig {
|
||||
@Field(() => Billing, { nullable: false })
|
||||
billing: Billing;
|
||||
|
||||
@Field(() => [ClientAIModelConfig])
|
||||
aiModels: ClientAIModelConfig[];
|
||||
@Field(() => [ClientAiModelConfig])
|
||||
aiModels: ClientAiModelConfig[];
|
||||
|
||||
@Field(() => Boolean)
|
||||
signInPrefilled: boolean;
|
||||
|
||||
+2
-2
@@ -14,7 +14,7 @@ import { SupportDriver } from 'src/engine/core-modules/twenty-config/interfaces/
|
||||
|
||||
import { MaintenanceModeService } from 'src/engine/core-modules/admin-panel/maintenance-mode.service';
|
||||
import {
|
||||
type ClientAIModelConfig,
|
||||
type ClientAiModelConfig,
|
||||
type ClientConfig,
|
||||
type NativeModelCapabilities,
|
||||
} from 'src/engine/core-modules/client-config/client-config.entity';
|
||||
@@ -76,7 +76,7 @@ export class ClientConfigService {
|
||||
? (resolvedProviders[providerName]?.label ?? providerName)
|
||||
: undefined;
|
||||
|
||||
const aiModels: ClientAIModelConfig[] = availableModels.map(
|
||||
const aiModels: ClientAiModelConfig[] = availableModels.map(
|
||||
(registeredModel) => {
|
||||
const modelConfig = this.aiModelRegistryService.getModelConfig(
|
||||
registeredModel.modelId,
|
||||
|
||||
Reference in New Issue
Block a user