Eslint migration 4 (#13773)

A new attempt to migrate!

packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator.ts

@@ -32,7 +32,7 @@ export function WorkspaceQueryHook(
     options.type = WorkspaceQueryHookType.PRE_HOOK;
   }
 
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   return (target: Function) => {
     SetMetadata(SCOPE_OPTIONS_METADATA, options)(target);
     SetMetadata(WORKSPACE_QUERY_HOOK_METADATA, options)(target);

packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-hook/workspace-query-hook-metadata.accessor.ts

@@ -1,9 +1,9 @@
-/* eslint-disable @typescript-eslint/ban-types */
+/* eslint-disable @typescript-eslint/no-unsafe-function-type */
 import { Injectable, type Type } from '@nestjs/common';
 import { Reflector } from '@nestjs/core';
 
-import { WORKSPACE_QUERY_HOOK_METADATA } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/workspace-query-hook.constants';
 import { type WorkspaceQueryHookOptions } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';
+import { WORKSPACE_QUERY_HOOK_METADATA } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/workspace-query-hook.constants';
 
 @Injectable()
 export class WorkspaceQueryHookMetadataAccessor {

packages/twenty-server/src/engine/core-modules/message-queue/decorators/processor.decorator.ts

@@ -37,7 +37,7 @@ export function Processor(
       ? queueNameOrOptions
       : { queueName: queueNameOrOptions };
 
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   return (target: Function) => {
     SetMetadata(SCOPE_OPTIONS_METADATA, options)(target);
     SetMetadata(PROCESSOR_METADATA, options)(target);

packages/twenty-server/src/engine/core-modules/message-queue/message-queue-metadata.accessor.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/ban-types */
+/* eslint-disable @typescript-eslint/no-unsafe-function-type */
 import { Injectable, type Type } from '@nestjs/common';
 import { Reflector } from '@nestjs/core';
 

packages/twenty-server/src/engine/core-modules/workspace/__tests__/workspace.service.spec.ts

@@ -243,7 +243,7 @@ describe('WorkspaceService', () => {
 
       await service.deleteWorkspace(mockWorkspace.id, true);
 
-      expect(billingSubscriptionService.deleteSubscriptions).toHaveBeenCalled;
+      expect(billingSubscriptionService.deleteSubscriptions).toHaveBeenCalled();
 
       expect(workspaceRepository.softDelete).toHaveBeenCalledWith({
         id: mockWorkspace.id,

packages/twenty-server/src/engine/metadata-modules/field-metadata/services/field-metadata.service-v2.ts

@@ -250,7 +250,7 @@ export class FieldMetadataServiceV2 {
             flatFieldMetadata: flatFieldMetadataToCreate,
             flatObjectMetadataMaps: optimisticFlatObjectMetadataMaps,
           });
-      } catch (e) {
+      } catch {
         throw new FieldMetadataException(
           'Optimistic cache manipulation failed, should never occur',
           FieldMetadataExceptionCode.INTERNAL_SERVER_ERROR,

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata-maps/utils/add-flat-field-metadata-in-flat-object-metadata-maps.util.ts

@@ -9,7 +9,7 @@ export const addFlatFieldMetadataInFlatObjectMetadataMaps = (
 ): FlatObjectMetadataMaps | undefined => {
   try {
     return addFlatFieldMetadataInFlatObjectMetadataMapsOrThrow(arg);
-  } catch (e) {
+  } catch {
     return undefined;
   }
 };

packages/twenty-server/src/engine/twenty-orm/interfaces/twenty-orm-options.interface.ts

@@ -1,7 +1,8 @@
 import { type FactoryProvider, type ModuleMetadata } from '@nestjs/common';
 
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
-export interface TwentyORMOptions {}
+export interface TwentyORMOptions {
+  [key: string]: unknown;
+}
 
 export type TwentyORMModuleAsyncOptions = {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any

packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-dynamic-relation-metadata-args.interface.ts

@@ -44,7 +44,7 @@ export interface WorkspaceDynamicRelationMetadataArgs {
   /**
    * Class to which relation is applied.
    */
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   readonly target: Function;
 
   /**

packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-entity-metadata-args.interface.ts

@@ -13,7 +13,7 @@ export interface WorkspaceEntityMetadataArgs {
    * Function target is a table defined in the class.
    * String target is a table defined in a json schema.
    */
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   readonly target: Function;
 
   /**

packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-extended-entity-metadata-args.interface.ts

@@ -6,7 +6,7 @@ export interface WorkspaceExtendedEntityMetadataArgs {
    * Function target is a table defined in the class.
    * String target is a table defined in a json schema.
    */
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   readonly target: Function;
 
   /**

packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-field-metadata-args.interface.ts

@@ -16,7 +16,7 @@ export interface WorkspaceFieldMetadataArgs {
   /**
    * Class to which field is applied.
    */
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   readonly target: Function;
 
   /**

packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-index-metadata-args.interface.ts

@@ -6,7 +6,7 @@ export interface WorkspaceIndexMetadataArgs {
   /**
    * Class to which index is applied.
    */
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   readonly target: Function;
 
   /*

packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-join-columns-metadata-args.interface.ts

@@ -2,7 +2,7 @@ export interface WorkspaceJoinColumnsMetadataArgs {
   /**
    * Class to which relation is applied.
    */
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   readonly target: Function;
 
   /**

packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-relation-metadata-args.interface.ts

@@ -15,7 +15,7 @@ export interface WorkspaceRelationMetadataArgs {
   /**
    * Class to which relation is applied.
    */
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   readonly target: Function;
 
   /**

packages/twenty-server/src/engine/twenty-orm/storage/metadata-args.storage.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/ban-types */
+/* eslint-disable @typescript-eslint/no-unsafe-function-type */
 
 import { type WorkspaceDynamicRelationMetadataArgs } from 'src/engine/twenty-orm/interfaces/workspace-dynamic-relation-metadata-args.interface';
 import { type WorkspaceEntityMetadataArgs } from 'src/engine/twenty-orm/interfaces/workspace-entity-metadata-args.interface';

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/companies-all.view.ts

@@ -31,9 +31,7 @@ export const companiesAllView = (
         fieldMetadataId:
           companyObjectMetadata.fields.find(
             (field) => field.standardId === COMPANY_STANDARD_FIELD_IDS.name,
-          )?.id ??
-          '' ??
-          '',
+          )?.id ?? '',
         position: 0,
         isVisible: true,
         size: 180,
@@ -43,9 +41,7 @@ export const companiesAllView = (
           companyObjectMetadata.fields.find(
             (field) =>
               field.standardId === COMPANY_STANDARD_FIELD_IDS.domainName,
-          )?.id ??
-          '' ??
-          '',
+          )?.id ?? '',
         position: 1,
         isVisible: true,
         size: 100,