feat: simplify AI chat architecture and add record links (#16463)
## Summary This PR significantly simplifies the AI chat architecture by removing complex routing/planning mechanisms and introduces clickable record links in AI responses. ## Changes ### AI Chat Architecture Simplification - **Removed** the entire `ai-chat-router` module (~850 lines) including: - Strategy decider service - Plan generator service - Complex routing logic - **Removed** agent execution planning services (~700 lines): - `agent-execution.service.ts` - `agent-plan-executor.service.ts` - `agent-tool-generator.service.ts` - **Added** centralized `ToolRegistryService` for tool management: - Builds searchable tool index (database, action, workflow tools) - Provides tool lookup by name - Supports agent search for loading expertise - **Added** `ChatExecutionService` as simple replacement: - Includes full tool catalog in system prompt - Pre-loads common tools (find/create/update for company, person, opportunity, task, note) - Uses `load_tools` mechanism for dynamic tool activation - Enables native web search by default ### Record References in AI Responses - Added `recordReferences` field to tool outputs for create, find, and update operations - Implemented `[[record:objectName:recordId:displayName]]` syntax for AI to reference records - Created `RecordLink` component that renders clickable chips with object icons - Integrated record link parsing into the markdown renderer - Users can now click directly on created/found records in AI responses ### Workflow Agent Fixes - Fixed cache invalidation issue when creating agents in workflows - Added default prompt for workflow-created agents to prevent validation errors - Relaxed agent validation to only check properties being updated (not all required properties) ### Code Quality Improvements - Extracted `getRecordDisplayName` utility that mirrors frontend's `getLabelIdentifierFieldValue` logic - Uses object metadata to determine the correct label identifier field - Handles `FULL_NAME` composite type for person/workspaceMember objects - Shared across create, find, and update record services ## Net Impact - **~1,200 lines deleted** (complex routing/planning code) - **~500 lines added** (simpler tool registry + record links) - Significantly reduced code complexity - Better tool discovery through full catalog in system prompt - Improved UX with clickable record references ## Testing - Typecheck passes - Lint passes - Manual testing of AI chat with record creation and linking
This commit is contained in:
Félix Malfait
+1
-13
@@ -18,9 +18,6 @@ import { AgentMessageEntity } from './entities/agent-message.entity';
|
||||
import { AgentTurnEntity } from './entities/agent-turn.entity';
|
||||
import { AgentActorContextService } from './services/agent-actor-context.service';
|
||||
import { AgentAsyncExecutorService } from './services/agent-async-executor.service';
|
||||
import { AgentExecutionService } from './services/agent-execution.service';
|
||||
import { AgentPlanExecutorService } from './services/agent-plan-executor.service';
|
||||
import { AgentToolGeneratorService } from './services/agent-tool-generator.service';
|
||||
|
||||
@Module({
|
||||
imports: [
|
||||
@@ -41,18 +38,9 @@ import { AgentToolGeneratorService } from './services/agent-tool-generator.servi
|
||||
RoleTargetEntity,
|
||||
]),
|
||||
],
|
||||
providers: [
|
||||
AgentAsyncExecutorService,
|
||||
AgentExecutionService,
|
||||
AgentToolGeneratorService,
|
||||
AgentActorContextService,
|
||||
AgentPlanExecutorService,
|
||||
],
|
||||
providers: [AgentAsyncExecutorService, AgentActorContextService],
|
||||
exports: [
|
||||
AgentAsyncExecutorService,
|
||||
AgentExecutionService,
|
||||
AgentPlanExecutorService,
|
||||
AgentToolGeneratorService,
|
||||
AgentActorContextService,
|
||||
TypeOrmModule.forFeature([
|
||||
AgentMessageEntity,
|
||||
|
||||
+3
-3
@@ -19,7 +19,7 @@ import {
|
||||
AgentExceptionCode,
|
||||
} from 'src/engine/metadata-modules/ai/ai-agent/agent.exception';
|
||||
import { AGENT_CONFIG } from 'src/engine/metadata-modules/ai/ai-agent/constants/agent-config.const';
|
||||
import { AGENT_SYSTEM_PROMPTS } from 'src/engine/metadata-modules/ai/ai-agent/constants/agent-system-prompts.const';
|
||||
import { WORKFLOW_SYSTEM_PROMPTS } from 'src/engine/metadata-modules/ai/ai-agent/constants/agent-system-prompts.const';
|
||||
import { AgentEntity } from 'src/engine/metadata-modules/ai/ai-agent/entities/agent.entity';
|
||||
import { repairToolCall } from 'src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util';
|
||||
import { AI_TELEMETRY_CONFIG } from 'src/engine/metadata-modules/ai/ai-models/constants/ai-telemetry.const';
|
||||
@@ -141,7 +141,7 @@ export class AgentAsyncExecutorService {
|
||||
this.logger.log(`Generated ${Object.keys(tools).length} tools for agent`);
|
||||
|
||||
const textResponse = await generateText({
|
||||
system: `${AGENT_SYSTEM_PROMPTS.BASE}\n${AGENT_SYSTEM_PROMPTS.WORKFLOW_ADDITIONS}\n\n${agent ? agent.prompt : ''}`,
|
||||
system: `${WORKFLOW_SYSTEM_PROMPTS.BASE}\n\n${agent ? agent.prompt : ''}`,
|
||||
tools,
|
||||
model: registeredModel.model,
|
||||
prompt: userPrompt,
|
||||
@@ -177,7 +177,7 @@ export class AgentAsyncExecutorService {
|
||||
}
|
||||
|
||||
const output = await generateObject({
|
||||
system: AGENT_SYSTEM_PROMPTS.OUTPUT_GENERATOR,
|
||||
system: WORKFLOW_SYSTEM_PROMPTS.OUTPUT_GENERATOR,
|
||||
model: registeredModel.model,
|
||||
prompt: `Based on the following execution results, generate the structured output according to the schema:
|
||||
|
||||
|
||||
-411
@@ -1,411 +0,0 @@
|
||||
import { Injectable, Logger } from '@nestjs/common';
|
||||
|
||||
import {
|
||||
convertToModelMessages,
|
||||
stepCountIs,
|
||||
streamText,
|
||||
ToolSet,
|
||||
UIDataTypes,
|
||||
UIMessage,
|
||||
UITools,
|
||||
} from 'ai';
|
||||
import { AppPath, type ActorMetadata } from 'twenty-shared/types';
|
||||
import { getAppPath } from 'twenty-shared/utils';
|
||||
import { In } from 'typeorm';
|
||||
|
||||
import { getAllSelectableColumnNames } from 'src/engine/api/utils/get-all-selectable-column-names.utils';
|
||||
import { WorkspaceDomainsService } from 'src/engine/core-modules/domain/workspace-domains/services/workspace-domains.service';
|
||||
import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
|
||||
import {
|
||||
AgentException,
|
||||
AgentExceptionCode,
|
||||
} from 'src/engine/metadata-modules/ai/ai-agent/agent.exception';
|
||||
import { AgentService } from 'src/engine/metadata-modules/ai/ai-agent/agent.service';
|
||||
import { AGENT_CONFIG } from 'src/engine/metadata-modules/ai/ai-agent/constants/agent-config.const';
|
||||
import { AGENT_SYSTEM_PROMPTS } from 'src/engine/metadata-modules/ai/ai-agent/constants/agent-system-prompts.const';
|
||||
import { RecordIdsByObjectMetadataNameSingularType } from 'src/engine/metadata-modules/ai/ai-agent/types/recordIdsByObjectMetadataNameSingular.type';
|
||||
import { repairToolCall } from 'src/engine/metadata-modules/ai/ai-agent/utils/repair-tool-call.util';
|
||||
import { AIBillingService } from 'src/engine/metadata-modules/ai/ai-billing/services/ai-billing.service';
|
||||
import { ToolHints } from 'src/engine/metadata-modules/ai/ai-chat-router/types/tool-hints.interface';
|
||||
import { AI_TELEMETRY_CONFIG } from 'src/engine/metadata-modules/ai/ai-models/constants/ai-telemetry.const';
|
||||
import { AiModelRegistryService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
|
||||
import { FlatAgentWithRoleId } from 'src/engine/metadata-modules/flat-agent/types/flat-agent.type';
|
||||
import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.manager';
|
||||
import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
|
||||
import { AgentModelConfigService } from 'src/engine/metadata-modules/ai/ai-models/services/agent-model-config.service';
|
||||
|
||||
import { AgentActorContextService } from './agent-actor-context.service';
|
||||
import { AgentToolGeneratorService } from './agent-tool-generator.service';
|
||||
|
||||
// Re-export for backward compatibility
|
||||
export { type AgentExecutionResult } from 'src/engine/metadata-modules/ai/ai-agent-execution/types/agent-execution-result.type';
|
||||
|
||||
export interface StreamChatResponseResult {
|
||||
stream: ReturnType<typeof streamText>;
|
||||
timings: {
|
||||
contextBuildTimeMs: number;
|
||||
toolGenerationTimeMs: number;
|
||||
aiRequestPrepTimeMs: number;
|
||||
toolCount: number;
|
||||
};
|
||||
}
|
||||
|
||||
@Injectable()
|
||||
export class AgentExecutionService {
|
||||
private readonly logger = new Logger(AgentExecutionService.name);
|
||||
|
||||
constructor(
|
||||
private readonly workspaceDomainsService: WorkspaceDomainsService,
|
||||
private readonly twentyORMGlobalManager: TwentyORMGlobalManager,
|
||||
private readonly aiModelRegistryService: AiModelRegistryService,
|
||||
private readonly agentToolGeneratorService: AgentToolGeneratorService,
|
||||
private readonly agentModelConfigService: AgentModelConfigService,
|
||||
private readonly aiBillingService: AIBillingService,
|
||||
private readonly agentActorContextService: AgentActorContextService,
|
||||
private readonly agentService: AgentService,
|
||||
private readonly workspaceCacheService: WorkspaceCacheService,
|
||||
) {}
|
||||
|
||||
async prepareAIRequestConfig({
|
||||
messages,
|
||||
system,
|
||||
agent,
|
||||
actorContext,
|
||||
roleIds,
|
||||
toolHints,
|
||||
additionalTools,
|
||||
}: {
|
||||
system: string;
|
||||
agent: FlatAgentWithRoleId | null;
|
||||
messages: UIMessage<unknown, UIDataTypes, UITools>[];
|
||||
actorContext?: ActorMetadata;
|
||||
roleIds?: string[];
|
||||
toolHints?: ToolHints;
|
||||
additionalTools?: ToolSet;
|
||||
}) {
|
||||
try {
|
||||
if (agent) {
|
||||
this.logger.log(
|
||||
`Preparing AI request config for agent ${agent.id} with model ${agent.modelId}`,
|
||||
);
|
||||
}
|
||||
|
||||
const registeredModel =
|
||||
await this.aiModelRegistryService.resolveModelForAgent(agent);
|
||||
|
||||
let tools: ToolSet = {};
|
||||
let providerOptions;
|
||||
|
||||
if (agent) {
|
||||
const baseTools =
|
||||
await this.agentToolGeneratorService.generateToolsForAgent(
|
||||
agent.id,
|
||||
agent.workspaceId,
|
||||
actorContext,
|
||||
roleIds,
|
||||
toolHints,
|
||||
);
|
||||
|
||||
const nativeModelTools =
|
||||
this.agentModelConfigService.getNativeModelTools(
|
||||
registeredModel,
|
||||
agent,
|
||||
);
|
||||
|
||||
tools = {
|
||||
...baseTools,
|
||||
...nativeModelTools,
|
||||
...(additionalTools || {}),
|
||||
};
|
||||
|
||||
providerOptions = this.agentModelConfigService.getProviderOptions(
|
||||
registeredModel,
|
||||
agent,
|
||||
);
|
||||
}
|
||||
|
||||
this.logger.log(
|
||||
`Generated ${Object.keys(tools).length} tools for agent (including ${Object.keys(additionalTools || {}).length} additional tools)`,
|
||||
);
|
||||
|
||||
return {
|
||||
system,
|
||||
tools,
|
||||
model: registeredModel.model,
|
||||
messages: convertToModelMessages(messages),
|
||||
stopWhen: stepCountIs(AGENT_CONFIG.MAX_STEPS),
|
||||
providerOptions,
|
||||
experimental_telemetry: AI_TELEMETRY_CONFIG,
|
||||
experimental_repairToolCall: async ({
|
||||
toolCall,
|
||||
tools: toolsForRepair,
|
||||
inputSchema,
|
||||
error,
|
||||
}: {
|
||||
toolCall: {
|
||||
type: 'tool-call';
|
||||
toolCallId: string;
|
||||
toolName: string;
|
||||
input: string;
|
||||
};
|
||||
tools: Record<string, unknown>;
|
||||
inputSchema: (toolCall: { toolName: string }) => unknown;
|
||||
error: Error;
|
||||
}) => {
|
||||
return repairToolCall({
|
||||
toolCall,
|
||||
tools: toolsForRepair,
|
||||
inputSchema,
|
||||
error,
|
||||
model: registeredModel.model,
|
||||
});
|
||||
},
|
||||
};
|
||||
} catch (error) {
|
||||
this.logger.error(
|
||||
`Failed to prepare AI request config for agent ${agent?.id ?? 'no agent'}`,
|
||||
error instanceof Error ? error.stack : error,
|
||||
);
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
|
||||
async getContextForSystemPrompt(
|
||||
workspace: WorkspaceEntity,
|
||||
recordIdsByObjectMetadataNameSingular: RecordIdsByObjectMetadataNameSingularType,
|
||||
userWorkspaceId: string,
|
||||
) {
|
||||
const { userWorkspaceRoleMap } =
|
||||
await this.workspaceCacheService.getOrRecompute(workspace.id, [
|
||||
'userWorkspaceRoleMap',
|
||||
]);
|
||||
|
||||
const roleId = userWorkspaceRoleMap[userWorkspaceId];
|
||||
|
||||
if (!roleId) {
|
||||
throw new AgentException(
|
||||
'Failed to retrieve user role.',
|
||||
AgentExceptionCode.ROLE_NOT_FOUND,
|
||||
);
|
||||
}
|
||||
|
||||
const workspaceDataSource =
|
||||
await this.twentyORMGlobalManager.getDataSourceForWorkspace({
|
||||
workspaceId: workspace.id,
|
||||
});
|
||||
|
||||
const flatObjectMetadataMaps =
|
||||
workspaceDataSource.internalContext.flatObjectMetadataMaps;
|
||||
const flatFieldMetadataMaps =
|
||||
workspaceDataSource.internalContext.flatFieldMetadataMaps;
|
||||
const objectIdByNameSingular =
|
||||
workspaceDataSource.internalContext.objectIdByNameSingular;
|
||||
const objectMetadataPermissions = workspaceDataSource.permissionsPerRoleId;
|
||||
|
||||
const contextObject = (
|
||||
await Promise.all(
|
||||
recordIdsByObjectMetadataNameSingular.map(
|
||||
async (recordsWithObjectMetadataNameSingular) => {
|
||||
if (recordsWithObjectMetadataNameSingular.recordIds.length === 0) {
|
||||
return [];
|
||||
}
|
||||
|
||||
const objectMetadataId =
|
||||
objectIdByNameSingular[
|
||||
recordsWithObjectMetadataNameSingular.objectMetadataNameSingular
|
||||
];
|
||||
const objectMetadataMapItem = objectMetadataId
|
||||
? flatObjectMetadataMaps.byId[objectMetadataId]
|
||||
: undefined;
|
||||
|
||||
if (!objectMetadataMapItem) {
|
||||
this.logger.warn(
|
||||
`Object metadata not found for ${recordsWithObjectMetadataNameSingular.objectMetadataNameSingular}`,
|
||||
);
|
||||
|
||||
return [];
|
||||
}
|
||||
|
||||
const repository = workspaceDataSource.getRepository(
|
||||
recordsWithObjectMetadataNameSingular.objectMetadataNameSingular,
|
||||
{ unionOf: [roleId] },
|
||||
);
|
||||
|
||||
const restrictedFields =
|
||||
objectMetadataPermissions?.[roleId]?.[objectMetadataMapItem.id]
|
||||
?.restrictedFields ?? {};
|
||||
|
||||
const hasRestrictedFields = Object.values(restrictedFields).some(
|
||||
(field) => field.canRead === false,
|
||||
);
|
||||
|
||||
const selectOptions = hasRestrictedFields
|
||||
? getAllSelectableColumnNames({
|
||||
restrictedFields,
|
||||
objectMetadata: {
|
||||
objectMetadataMapItem,
|
||||
flatFieldMetadataMaps,
|
||||
},
|
||||
})
|
||||
: undefined;
|
||||
|
||||
return (
|
||||
await repository.find({
|
||||
...(selectOptions && { select: selectOptions }),
|
||||
where: {
|
||||
id: In(recordsWithObjectMetadataNameSingular.recordIds),
|
||||
},
|
||||
})
|
||||
).map((record) => {
|
||||
return {
|
||||
...record,
|
||||
resourceUrl: this.workspaceDomainsService.buildWorkspaceURL({
|
||||
workspace,
|
||||
pathname: getAppPath(AppPath.RecordShowPage, {
|
||||
objectNameSingular:
|
||||
recordsWithObjectMetadataNameSingular.objectMetadataNameSingular,
|
||||
objectRecordId: record.id,
|
||||
}),
|
||||
}),
|
||||
};
|
||||
});
|
||||
},
|
||||
),
|
||||
)
|
||||
).flat(2);
|
||||
|
||||
return JSON.stringify(contextObject);
|
||||
}
|
||||
|
||||
async streamChatResponse({
|
||||
workspace,
|
||||
userWorkspaceId,
|
||||
agentId,
|
||||
messages,
|
||||
recordIdsByObjectMetadataNameSingular,
|
||||
toolHints,
|
||||
additionalTools,
|
||||
}: {
|
||||
workspace: WorkspaceEntity;
|
||||
userWorkspaceId: string;
|
||||
agentId: string;
|
||||
messages: UIMessage<unknown, UIDataTypes, UITools>[];
|
||||
recordIdsByObjectMetadataNameSingular: RecordIdsByObjectMetadataNameSingularType;
|
||||
toolHints?: ToolHints;
|
||||
additionalTools?: ToolSet;
|
||||
}): Promise<{
|
||||
stream: ReturnType<typeof streamText>;
|
||||
timings: {
|
||||
contextBuildTimeMs: number;
|
||||
toolGenerationTimeMs: number;
|
||||
aiRequestPrepTimeMs: number;
|
||||
toolCount: number;
|
||||
};
|
||||
contextInfo: {
|
||||
contextString: string;
|
||||
contextRecordCount: number;
|
||||
contextSizeBytes: number;
|
||||
};
|
||||
}> {
|
||||
try {
|
||||
const agent = await this.agentService.findOneAgentById({
|
||||
workspaceId: workspace.id,
|
||||
id: agentId,
|
||||
});
|
||||
|
||||
const contextBuildStart = Date.now();
|
||||
let contextPart = '';
|
||||
let contextRecordCount = 0;
|
||||
|
||||
if (recordIdsByObjectMetadataNameSingular.length > 0) {
|
||||
contextPart = await this.getContextForSystemPrompt(
|
||||
workspace,
|
||||
recordIdsByObjectMetadataNameSingular,
|
||||
userWorkspaceId,
|
||||
);
|
||||
|
||||
try {
|
||||
const contextData = JSON.parse(contextPart);
|
||||
|
||||
contextRecordCount = Array.isArray(contextData)
|
||||
? contextData.length
|
||||
: 0;
|
||||
} catch (error) {
|
||||
this.logger.warn('Failed to parse context for record count:', error);
|
||||
}
|
||||
}
|
||||
|
||||
const contextString = contextPart ? `\n\nCONTEXT:\n${contextPart}` : '';
|
||||
const contextBuildTime = Date.now() - contextBuildStart;
|
||||
|
||||
const { actorContext, roleId } =
|
||||
await this.agentActorContextService.buildUserAndAgentActorContext(
|
||||
userWorkspaceId,
|
||||
workspace.id,
|
||||
);
|
||||
|
||||
const aiRequestPrepStart = Date.now();
|
||||
|
||||
const aiRequestConfig = await this.prepareAIRequestConfig({
|
||||
system: `${AGENT_SYSTEM_PROMPTS.BASE}\n${AGENT_SYSTEM_PROMPTS.CHAT_ADDITIONS}\n\n${agent.prompt}${contextString}`,
|
||||
agent,
|
||||
messages,
|
||||
actorContext,
|
||||
roleIds: [roleId, ...(agent?.roleId ? [agent?.roleId] : [])],
|
||||
toolHints,
|
||||
additionalTools,
|
||||
});
|
||||
|
||||
const aiRequestPrepTime = Date.now() - aiRequestPrepStart;
|
||||
const toolCount = Object.keys(aiRequestConfig.tools || {}).length;
|
||||
const toolGenerationTime = aiRequestPrepTime;
|
||||
|
||||
this.logger.log(
|
||||
`Sending request to AI model with ${messages.length} messages and ${toolCount} tools`,
|
||||
);
|
||||
|
||||
const model =
|
||||
await this.aiModelRegistryService.resolveModelForAgent(agent);
|
||||
|
||||
const stream = streamText(aiRequestConfig);
|
||||
|
||||
stream.usage
|
||||
.then((usage) => {
|
||||
this.aiBillingService.calculateAndBillUsage(
|
||||
model.modelId,
|
||||
usage,
|
||||
workspace.id,
|
||||
agent.id,
|
||||
);
|
||||
})
|
||||
.catch((usageError) => {
|
||||
this.logger.error('Failed to get usage information:', usageError);
|
||||
});
|
||||
|
||||
return {
|
||||
stream,
|
||||
timings: {
|
||||
contextBuildTimeMs: contextBuildTime,
|
||||
toolGenerationTimeMs: toolGenerationTime,
|
||||
aiRequestPrepTimeMs: aiRequestPrepTime,
|
||||
toolCount,
|
||||
},
|
||||
contextInfo: {
|
||||
contextString: contextPart,
|
||||
contextRecordCount,
|
||||
contextSizeBytes: contextPart
|
||||
? Buffer.byteLength(contextPart, 'utf8')
|
||||
: 0,
|
||||
},
|
||||
};
|
||||
} catch (error) {
|
||||
this.logger.error('Error in streamChatResponse:', error);
|
||||
throw new AgentException(
|
||||
error instanceof Error
|
||||
? error.message
|
||||
: 'Failed to stream chat response',
|
||||
AgentExceptionCode.AGENT_EXECUTION_FAILED,
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
-251
@@ -1,251 +0,0 @@
|
||||
import { Injectable, Logger } from '@nestjs/common';
|
||||
|
||||
import { type WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
|
||||
import { AgentService } from 'src/engine/metadata-modules/ai/ai-agent/agent.service';
|
||||
import { type RecordIdsByObjectMetadataNameSingularType } from 'src/engine/metadata-modules/ai/ai-agent/types/recordIdsByObjectMetadataNameSingular.type';
|
||||
import { type PlanStep } from 'src/engine/metadata-modules/ai/ai-chat-router/types/router-result.interface';
|
||||
import { STANDARD_AGENT_DEFINITIONS } from 'src/engine/workspace-manager/workspace-sync-metadata/standard-agents/standard-agent-definitions';
|
||||
|
||||
import { AgentExecutionService } from './agent-execution.service';
|
||||
|
||||
export type PlanExecutionProgress = {
|
||||
type: 'plan-generated' | 'step-started' | 'step-completed';
|
||||
stepNumber?: number;
|
||||
agentName?: string;
|
||||
task?: string;
|
||||
output?: string;
|
||||
totalSteps?: number;
|
||||
reasoning?: string;
|
||||
};
|
||||
|
||||
export type StepResult = {
|
||||
stepNumber: number;
|
||||
agentName: string;
|
||||
output: string;
|
||||
};
|
||||
|
||||
export type PlanExecutionResult = {
|
||||
finalOutput: string;
|
||||
stepResults: StepResult[];
|
||||
};
|
||||
|
||||
@Injectable()
|
||||
export class AgentPlanExecutorService {
|
||||
private readonly logger = new Logger(AgentPlanExecutorService.name);
|
||||
|
||||
constructor(
|
||||
private readonly agentExecutionService: AgentExecutionService,
|
||||
private readonly agentService: AgentService,
|
||||
) {}
|
||||
|
||||
async executePlan({
|
||||
steps,
|
||||
reasoning,
|
||||
workspace,
|
||||
userWorkspaceId,
|
||||
recordIdsByObjectMetadataNameSingular,
|
||||
onProgress,
|
||||
writer,
|
||||
}: {
|
||||
steps: PlanStep[];
|
||||
reasoning: string;
|
||||
workspace: WorkspaceEntity;
|
||||
userWorkspaceId: string;
|
||||
recordIdsByObjectMetadataNameSingular: RecordIdsByObjectMetadataNameSingularType;
|
||||
onProgress?: (progress: PlanExecutionProgress) => void;
|
||||
writer?: {
|
||||
write: (chunk: unknown) => void;
|
||||
merge: (stream: unknown) => void;
|
||||
};
|
||||
}): Promise<PlanExecutionResult> {
|
||||
this.logger.log(`Executing plan with ${steps.length} steps`);
|
||||
|
||||
onProgress?.({
|
||||
type: 'plan-generated',
|
||||
totalSteps: steps.length,
|
||||
reasoning,
|
||||
});
|
||||
|
||||
const stepResults: StepResult[] = [];
|
||||
|
||||
for (const step of steps) {
|
||||
try {
|
||||
this.logger.log(
|
||||
`[PLAN EXECUTION] Step ${step.stepNumber}: Looking up agent "${step.agentName}"`,
|
||||
);
|
||||
|
||||
const agent = await this.agentService.findOneAgentByName({
|
||||
name: step.agentName,
|
||||
workspaceId: workspace.id,
|
||||
});
|
||||
|
||||
this.logger.log(
|
||||
`[PLAN EXECUTION] Step ${step.stepNumber}: Found agent "${agent.label}" (${agent.id})`,
|
||||
);
|
||||
|
||||
onProgress?.({
|
||||
type: 'step-started',
|
||||
stepNumber: step.stepNumber,
|
||||
agentName: step.agentName,
|
||||
task: step.task,
|
||||
});
|
||||
|
||||
const dependencyOutputs = this.gatherDependencyOutputs(
|
||||
step,
|
||||
stepResults,
|
||||
);
|
||||
|
||||
const promptWithContext = this.buildStepPrompt(step, dependencyOutputs);
|
||||
|
||||
const { stream: stepStream } =
|
||||
await this.agentExecutionService.streamChatResponse({
|
||||
workspace,
|
||||
agentId: agent.id,
|
||||
userWorkspaceId,
|
||||
messages: [
|
||||
{
|
||||
id: `step-${step.stepNumber}`,
|
||||
role: 'user' as const,
|
||||
parts: [{ type: 'text' as const, text: promptWithContext }],
|
||||
},
|
||||
],
|
||||
recordIdsByObjectMetadataNameSingular,
|
||||
});
|
||||
|
||||
let stepOutput = '';
|
||||
|
||||
if (writer) {
|
||||
writer.merge(
|
||||
stepStream.toUIMessageStream({
|
||||
onError: (error) => {
|
||||
return error instanceof Error ? error.message : String(error);
|
||||
},
|
||||
sendStart: false,
|
||||
onFinish: async ({ responseMessage }) => {
|
||||
stepOutput = responseMessage.parts
|
||||
.filter((part) => part.type === 'text')
|
||||
.map((part) => {
|
||||
if (part.type === 'text') {
|
||||
return part.text;
|
||||
}
|
||||
|
||||
return '';
|
||||
})
|
||||
.join('');
|
||||
},
|
||||
}),
|
||||
);
|
||||
|
||||
await stepStream.text;
|
||||
} else {
|
||||
stepOutput = await stepStream.text;
|
||||
}
|
||||
|
||||
stepResults.push({
|
||||
stepNumber: step.stepNumber,
|
||||
agentName: step.agentName,
|
||||
output: stepOutput,
|
||||
});
|
||||
|
||||
onProgress?.({
|
||||
type: 'step-completed',
|
||||
stepNumber: step.stepNumber,
|
||||
agentName: step.agentName,
|
||||
output: stepOutput,
|
||||
});
|
||||
|
||||
this.logger.log(
|
||||
`Completed step ${step.stepNumber}: ${step.task.substring(0, 50)}...`,
|
||||
);
|
||||
} catch (error) {
|
||||
this.logger.error(
|
||||
`Failed to execute step ${step.stepNumber}: ${step.task}`,
|
||||
error,
|
||||
);
|
||||
|
||||
throw new Error(
|
||||
`Plan execution failed at step ${step.stepNumber}: ${error.message}`,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
const finalOutput = this.synthesizeResults(stepResults, steps);
|
||||
|
||||
return {
|
||||
finalOutput,
|
||||
stepResults,
|
||||
};
|
||||
}
|
||||
|
||||
private gatherDependencyOutputs(
|
||||
step: PlanStep,
|
||||
previousResults: StepResult[],
|
||||
): string {
|
||||
if (!step.dependsOn || step.dependsOn.length === 0) {
|
||||
return '';
|
||||
}
|
||||
|
||||
const dependencyOutputs = step.dependsOn
|
||||
.map((depStepNum) => {
|
||||
const depResult = previousResults.find(
|
||||
(result) => result.stepNumber === depStepNum,
|
||||
);
|
||||
|
||||
if (!depResult) {
|
||||
throw new Error(
|
||||
`Dependency step ${depStepNum} not found for step ${step.stepNumber}`,
|
||||
);
|
||||
}
|
||||
|
||||
return `Step ${depStepNum} output:\n${depResult.output}`;
|
||||
})
|
||||
.join('\n\n');
|
||||
|
||||
return dependencyOutputs;
|
||||
}
|
||||
|
||||
private buildStepPrompt(step: PlanStep, dependencyOutputs: string): string {
|
||||
let prompt = `Task: ${step.task}\n\nExpected output: ${step.expectedOutput}`;
|
||||
|
||||
if (dependencyOutputs) {
|
||||
prompt += `\n\nPrevious step results:\n${dependencyOutputs}`;
|
||||
}
|
||||
|
||||
return prompt;
|
||||
}
|
||||
|
||||
private synthesizeResults(
|
||||
stepResults: StepResult[],
|
||||
steps: PlanStep[],
|
||||
): string {
|
||||
const lastStep = stepResults[stepResults.length - 1];
|
||||
|
||||
if (!lastStep) {
|
||||
return 'No results produced';
|
||||
}
|
||||
|
||||
const lastStepDefinition = steps.find(
|
||||
(s) => s.stepNumber === lastStep.stepNumber,
|
||||
);
|
||||
|
||||
if (lastStepDefinition) {
|
||||
const agentDefinition = STANDARD_AGENT_DEFINITIONS.find(
|
||||
(def) => def.name === lastStepDefinition.agentName,
|
||||
);
|
||||
|
||||
if (agentDefinition?.outputStrategy === 'direct') {
|
||||
return lastStep.output;
|
||||
}
|
||||
}
|
||||
|
||||
const summary = stepResults
|
||||
.map((result) => {
|
||||
const step = steps.find((s) => s.stepNumber === result.stepNumber);
|
||||
|
||||
return `**Step ${result.stepNumber}: ${step?.task || 'Unknown task'}**\n${result.output}`;
|
||||
})
|
||||
.join('\n\n---\n\n');
|
||||
|
||||
return summary;
|
||||
}
|
||||
}
|
||||
-47
@@ -1,47 +0,0 @@
|
||||
import { Injectable, Logger } from '@nestjs/common';
|
||||
|
||||
import { type ToolSet } from 'ai';
|
||||
|
||||
import type { ActorMetadata } from 'twenty-shared/types';
|
||||
|
||||
import { ToolCategory } from 'src/engine/core-modules/tool-provider/enums/tool-category.enum';
|
||||
import { ToolProviderService } from 'src/engine/core-modules/tool-provider/services/tool-provider.service';
|
||||
import type { ToolHints } from 'src/engine/metadata-modules/ai/ai-chat-router/types/tool-hints.interface';
|
||||
|
||||
@Injectable()
|
||||
export class AgentToolGeneratorService {
|
||||
private readonly logger = new Logger(AgentToolGeneratorService.name);
|
||||
|
||||
constructor(private readonly toolProvider: ToolProviderService) {}
|
||||
|
||||
// Generates base tools for chat context (DATABASE_CRUD and ACTION)
|
||||
// Additional tools (WORKFLOW, METADATA) are provided via additionalTools
|
||||
// from ChatToolsProviderService to avoid circular dependencies
|
||||
async generateToolsForAgent(
|
||||
agentId: string,
|
||||
workspaceId: string,
|
||||
actorContext?: ActorMetadata,
|
||||
roleIds?: string[],
|
||||
toolHints?: ToolHints,
|
||||
): Promise<ToolSet> {
|
||||
try {
|
||||
return await this.toolProvider.getTools({
|
||||
workspaceId,
|
||||
categories: [ToolCategory.DATABASE_CRUD, ToolCategory.ACTION],
|
||||
rolePermissionConfig: roleIds ? { intersectionOf: roleIds } : undefined,
|
||||
actorContext,
|
||||
toolHints,
|
||||
wrapWithErrorContext: true,
|
||||
});
|
||||
} catch (toolError) {
|
||||
const errorMessage =
|
||||
toolError instanceof Error ? toolError.message : 'Unknown error';
|
||||
|
||||
this.logger.warn(
|
||||
`Failed to generate tools for agent ${agentId}: ${errorMessage}. Proceeding without tools.`,
|
||||
);
|
||||
|
||||
return {};
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user