From 5c7c8d1bbafa6b540fe3dc6b79d58623fb375995 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix=20Malfait?= Date: Mon, 4 Aug 2025 13:00:54 +0200 Subject: [PATCH] Reset overflow visible to previous value, fix console error (#13586) Fixing two issues I introduced in #13583 and #13573 - Overflow visible is not needed, I missed that as I was switching between different implementations - Button within button not allowed (not the prettiest fix but I din't think it's worth digging deeper) --- .../navigation-drawer/components/NavigationDrawer.tsx | 2 +- .../navigation-drawer/components/NavigationDrawerItem.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawer.tsx b/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawer.tsx index 3504f65667..97ef139079 100644 --- a/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawer.tsx +++ b/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawer.tsx @@ -21,7 +21,7 @@ export type NavigationDrawerProps = { const StyledAnimatedContainer = styled(motion.div)` max-height: 100vh; - overflow: visible; + overflow: hidden; `; const StyledContainer = styled.div<{ diff --git a/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx b/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx index 1b0a24fe65..a8b01c285e 100644 --- a/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx +++ b/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx @@ -307,7 +307,7 @@ export const NavigationDrawerItem = ({ aria-selected={active} danger={danger} soon={soon} - as={to ? Link : undefined} + as={to ? Link : rightOptions ? 'div' : undefined} to={to ? to : undefined} indentationLevel={indentationLevel} isNavigationDrawerExpanded={isNavigationDrawerExpanded}