From 58b8b49d1dd078bcb38fddae610d62fed74d8c4b Mon Sep 17 00:00:00 2001 From: Marie <51697796+ijreilly@users.noreply.github.com> Date: Fri, 5 Dec 2025 15:27:25 +0100 Subject: [PATCH] Fix flaky storybook test (#16358) RecordTable story was flaky with this kind of error [(1)](https://www.apollographql.com/docs/react/errors#%7B%22version%22%3A%223.13.8%22%2C%22message%22%3A13%2C%22args%22%3A%5B%22addressStreet2%22%2C%22%7B%5Cn%20%20%5C%22__typename%5C%22%3A%20%5C%22Address%5C%22%2C%5Cn%20%20%5C%22addressLine1%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%5C%22addressLine2%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%5C%22addressCity%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%5C%22addressState%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%5C%22addressCountry%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%5C%22addressPostcode%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%5C%22addressLat%5C%22%3A%20null%2C%5Cn%20%20%5C%22addressLng%5C%22%3A%20null%5Cn%7D%22%5D%7D): _Missing field 'addressStreet2' while writing result { "typename": "Address", "addressLine1": "", "addressLine2": "", "addressCity": "", "addressState": "", "addressCountry": "", "addressPostcode": "", "addressLat": null, "addressLng": null }_ or [(2)](https://www.apollographql.com/docs/react/errors#%7B%22version%22%3A%223.13.8%22%2C%22message%22%3A13%2C%22args%22%3A%5B%22deletedAt%22%2C%22%7B%5Cn%20%20%5C%22__typename%5C%22%3A%20%5C%22Company%5C%22%2C%5Cn%20%20%5C%22id%5C%22%3A%20%5C%2220202020-5d81-46d6-bf83-f7fd33ea6102%5C%22%2C%5Cn%20%20%5C%22employees%5C%22%3A%20null%2C%5Cn%20%20%5C%22createdAt%5C%22%3A%20%5C%222025-01-06T08%3A30%3A15.412Z%5C%22%2C%5Cn%20%20%5C%22updatedAt%5C%22%3A%20%5C%222025-01-06T14%3A45%3A22.412Z%5C%22%2C%5Cn%20%20%5C%22name%5C%22%3A%20%5C%22Facebook%5C%22%2C%5Cn%20%20%5C%22idealCustomerProfile%5C%22%3A%20false%2C%5Cn%20%20%5C%22accountOwner%5C%22%3A%20null%2C%5Cn%20%20%5C%22accountOwnerId%5C%22%3A%20null%2C%5Cn%20%20%5C%22domainName%5C%22%3A%20%7B%5Cn%20%20%20%20%5C%22__typename%5C%22%3A%20%5C%22Links%5C%22%2C%5Cn%20%20%20%20%5C%22primaryLinkUrl%5C%22%3A%20%5C%22https%3A%2F%2Ffacebook.com%5C%22%2C%5Cn%20%20%20%20%5C%22primaryLinkLabel%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%20%20%5C%22secondaryLinks%5C%22%3A%20%5B%5D%5Cn%20%20%7D%2C%5Cn%20%20%5C%22address%5C%22%3A%20%7B%5Cn%20%20%20%20%5C%22addressStreet1%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%20%20%5C%22addressStreet2%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%20%20%5C%22addressCity%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%20%20%5C%22addressState%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%20%20%5C%22addressCountry%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%20%20%5C%22addressPostcode%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%20%20%5C%22addressLat%5C%22%3A%20null%2C%5Cn%20%20%20%20%5C%22addressLng%5C%22%3A%20null%5Cn%20%20%7D%2C%5Cn%20%20%5C%22previousEmployees%5C%22%3A%20null%2C%5Cn%20%20%5C%22annualRecurringRevenue%5C%22%3A%20%7B%5Cn%20%20%20%20%5C%22__typename%5C%22%3A%20%5C%22Currency%5C%22%2C%5Cn%20%20%20%20%5C%22amountMicros%5C%22%3A%20null%2C%5Cn%20%20%20%20%5C%22currencyCode%5C%22%3A%20%5C%22%5C%22%5Cn%20%20%7D%2C%5Cn%20%20%5C%22position%5C%22%3A%202%2C%5Cn%20%20%5C%22xLink%5C%22%3A%20%7B%5Cn%20%20%20%20%5C%22__typename%5C%22%3A%20%5C%22Links%5C%22%2C%5Cn%20%20%20%20%5C%22primaryLinkLabel%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%20%20%5C%22primaryLinkUrl%5C%22%3A%20%5C%22%5C%22%2C%5Cn%20%20%20%20%5C%22secondaryLinks%5C%22%3A%20%5B%5D%5Cn%20%20%7D%2C%5Cn%20%20%5C%22linkedinLink%5C%22%3A%20%7B%5Cn%20%20%20%20%5C%22__typename%5C%22%3A%20%5C%22Links%5C%22%2C%5Cn%20%20%20%20%5C%22primary%22%5D%7D): _Missing field 'deletedAt' while writing result..._ What the issue is and why is it flaky? image flakines may be due to timing of when the error is thrown vs when test assertions run --- .../src/modules/companies/types/Company.ts | 4 +-- .../src/testing/mock-data/companies.ts | 29 +++++++++++++++++-- 2 files changed, 29 insertions(+), 4 deletions(-) diff --git a/packages/twenty-front/src/modules/companies/types/Company.ts b/packages/twenty-front/src/modules/companies/types/Company.ts index 1ea1df3f98..b2ede19450 100644 --- a/packages/twenty-front/src/modules/companies/types/Company.ts +++ b/packages/twenty-front/src/modules/companies/types/Company.ts @@ -15,8 +15,8 @@ export type Company = { }; address: { __typename?: 'Address'; - addressLine1: string; - addressLine2: string; + addressStreet1: string; + addressStreet2: string; addressCity: string; addressState: string; addressPostcode: string; diff --git a/packages/twenty-front/src/testing/mock-data/companies.ts b/packages/twenty-front/src/testing/mock-data/companies.ts index 5b71b6778c..fe9c50f21a 100644 --- a/packages/twenty-front/src/testing/mock-data/companies.ts +++ b/packages/twenty-front/src/testing/mock-data/companies.ts @@ -25,6 +25,7 @@ export const companiesQueryResult = { employees: 100, createdAt: '2025-01-05T09:00:20.412Z', updatedAt: '2025-01-05T10:15:30.412Z', + deletedAt: null, name: 'Linkedin', accountOwnerId: null, accountOwner: null, @@ -36,8 +37,8 @@ export const companiesQueryResult = { }, address: { __typename: 'Address', - addressLine1: '', - addressLine2: '', + addressStreet1: '', + addressStreet2: '', addressCity: '', addressState: '', addressCountry: '', @@ -139,6 +140,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-06T08:30:15.412Z', updatedAt: '2025-01-06T14:45:22.412Z', + deletedAt: null, name: 'Facebook', idealCustomerProfile: false, accountOwner: null, @@ -150,6 +152,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -189,6 +192,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-07T10:15:30.412Z', updatedAt: '2025-01-07T16:20:45.412Z', + deletedAt: null, name: 'Anthropic', idealCustomerProfile: false, accountOwner: null, @@ -200,6 +204,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -239,6 +244,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-08T11:45:10.412Z', updatedAt: '2025-01-08T17:30:25.412Z', + deletedAt: null, name: 'Microsoft', idealCustomerProfile: true, accountOwner: null, @@ -250,6 +256,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -289,6 +296,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-09T09:20:45.412Z', updatedAt: '2025-01-09T15:10:30.412Z', + deletedAt: null, name: 'Airbnb', idealCustomerProfile: true, accountOwner: null, @@ -300,6 +308,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -339,6 +348,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-10T13:30:20.412Z', updatedAt: '2025-01-10T18:45:35.412Z', + deletedAt: null, name: 'Google', idealCustomerProfile: false, accountOwner: null, @@ -350,6 +360,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -389,6 +400,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-11T07:15:50.412Z', updatedAt: '2025-01-11T12:25:15.412Z', + deletedAt: null, name: 'Netflix', idealCustomerProfile: true, accountOwner: null, @@ -400,6 +412,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -439,6 +452,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-12T14:40:25.412Z', updatedAt: '2025-01-12T19:55:40.412Z', + deletedAt: null, name: 'Libeo', idealCustomerProfile: false, accountOwner: null, @@ -450,6 +464,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -489,6 +504,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-13T08:25:35.412Z', updatedAt: '2025-01-13T13:40:50.412Z', + deletedAt: null, name: 'Claap', idealCustomerProfile: false, accountOwner: null, @@ -500,6 +516,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -539,6 +556,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-14T16:10:15.412Z', updatedAt: '2025-01-14T21:30:25.412Z', + deletedAt: null, name: 'Hasura', idealCustomerProfile: false, accountOwner: null, @@ -550,6 +568,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -589,6 +608,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-15T12:50:40.412Z', updatedAt: '2025-01-15T17:15:55.412Z', + deletedAt: null, name: 'Wework', idealCustomerProfile: false, accountOwner: null, @@ -600,6 +620,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -639,6 +660,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-16T10:35:20.412Z', updatedAt: '2025-01-16T15:50:35.412Z', + deletedAt: null, name: 'Samsung', idealCustomerProfile: false, accountOwner: null, @@ -650,6 +672,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '', @@ -689,6 +712,7 @@ export const companiesQueryResult = { employees: null, createdAt: '2025-01-17T11:20:10.412Z', updatedAt: '2025-01-17T16:45:25.412Z', + deletedAt: null, name: 'Algolia', idealCustomerProfile: false, accountOwner: null, @@ -700,6 +724,7 @@ export const companiesQueryResult = { secondaryLinks: [], }, address: { + __typename: 'Address', addressStreet1: '', addressStreet2: '', addressCity: '',