Fix fields widget flash during reset (#19726)

Summary

- Remove the evictViewMetadataForViewIds step from the page-layout reset
flow. It synchronously cleared viewFields/viewFieldGroups rows from the
metadata store, leaving a window where
useFieldsWidgetGroups saw a view with no fields and fell back to
buildDefaultFieldsWidgetGroups, briefly rendering a synthetic "General"
+ "Other" layout before the real reset defaults
arrived.
- invalidateMetadataStore() alone is sufficient: it marks the
collections stale and triggers MinimalMetadataLoadEffect to refetch,
which replaces current atomically. The UI now
transitions old-layout → new-default with no synthetic flash.
- Simplified refreshPageLayoutAfterReset to no longer take a
collectAffectedViewIds callback, and updated both tab/widget reset call
sites plus ObjectLayout.tsx accordingly.
- Deleted the now-unused evictViewMetadataForViewIds and
collectViewIdsFromWidgets utils.

packages/twenty-front/src/modules/page-layout/hooks/useRefreshPageLayoutAfterReset.ts

@@ -15,9 +15,7 @@ import { hasInitializedFieldsWidgetGroupsDraftComponentState } from '@/page-layo
 import { pageLayoutCurrentLayoutsComponentState } from '@/page-layout/states/pageLayoutCurrentLayoutsComponentState';
 import { pageLayoutDraftComponentState } from '@/page-layout/states/pageLayoutDraftComponentState';
 import { pageLayoutPersistedComponentState } from '@/page-layout/states/pageLayoutPersistedComponentState';
-import { type PageLayout } from '@/page-layout/types/PageLayout';
 import { convertPageLayoutToTabLayouts } from '@/page-layout/utils/convertPageLayoutToTabLayouts';
-import { evictViewMetadataForViewIds } from '@/page-layout/utils/evictViewMetadataForViewIds';
 import { toDraftPageLayout } from '@/page-layout/utils/toDraftPageLayout';
 import { transformPageLayout } from '@/page-layout/utils/transformPageLayout';
 import { useAvailableComponentInstanceIdOrThrow } from '@/ui/utilities/state/component-state/hooks/useAvailableComponentInstanceIdOrThrow';
@@ -76,55 +74,47 @@ export const useRefreshPageLayoutAfterReset = (
       pageLayoutId,
     );
 
-  const refreshPageLayoutAfterReset = useCallback(
-    async (collectAffectedViewIds: (layout: PageLayout) => Set<string>) => {
-      const { data } = await client.query({
-        query: FindOnePageLayoutDocument,
-        variables: { id: pageLayoutId },
-        fetchPolicy: 'network-only',
-      });
+  const refreshPageLayoutAfterReset = useCallback(async () => {
+    const { data } = await client.query({
+      query: FindOnePageLayoutDocument,
+      variables: { id: pageLayoutId },
+      fetchPolicy: 'network-only',
+    });
 
-      let affectedViewIds = new Set<string>();
+    if (isDefined(data?.getPageLayout)) {
+      const freshLayout = transformPageLayout(data.getPageLayout);
 
-      if (isDefined(data?.getPageLayout)) {
-        const freshLayout = transformPageLayout(data.getPageLayout);
+      store.set(pageLayoutPersistedState, freshLayout);
+      store.set(pageLayoutDraftState, toDraftPageLayout(freshLayout));
+      store.set(
+        pageLayoutCurrentLayoutsState,
+        convertPageLayoutToTabLayouts(freshLayout),
+      );
+    }
 
-        affectedViewIds = collectAffectedViewIds(freshLayout);
+    store.set(fieldsWidgetGroupsDraftState, {});
+    store.set(fieldsWidgetUngroupedFieldsDraftState, {});
+    store.set(fieldsWidgetEditorModeDraftState, {});
+    store.set(hasInitializedFieldsWidgetGroupsDraftState, {});
 
-        store.set(pageLayoutPersistedState, freshLayout);
-        store.set(pageLayoutDraftState, toDraftPageLayout(freshLayout));
-        store.set(
-          pageLayoutCurrentLayoutsState,
-          convertPageLayoutToTabLayouts(freshLayout),
-        );
-      }
-
-      store.set(fieldsWidgetGroupsDraftState, {});
-      store.set(fieldsWidgetUngroupedFieldsDraftState, {});
-      store.set(fieldsWidgetEditorModeDraftState, {});
-      store.set(hasInitializedFieldsWidgetGroupsDraftState, {});
-
-      setIsPageLayoutInEditMode(false);
-      exitLayoutCustomizationMode();
-      evictViewMetadataForViewIds(store, affectedViewIds);
-      invalidateMetadataStore();
-    },
-    [
-      client,
-      pageLayoutId,
-      store,
-      pageLayoutPersistedState,
-      pageLayoutDraftState,
-      pageLayoutCurrentLayoutsState,
-      fieldsWidgetGroupsDraftState,
-      fieldsWidgetUngroupedFieldsDraftState,
-      fieldsWidgetEditorModeDraftState,
-      hasInitializedFieldsWidgetGroupsDraftState,
-      setIsPageLayoutInEditMode,
-      exitLayoutCustomizationMode,
-      invalidateMetadataStore,
-    ],
-  );
+    setIsPageLayoutInEditMode(false);
+    exitLayoutCustomizationMode();
+    invalidateMetadataStore();
+  }, [
+    client,
+    pageLayoutId,
+    store,
+    pageLayoutPersistedState,
+    pageLayoutDraftState,
+    pageLayoutCurrentLayoutsState,
+    fieldsWidgetGroupsDraftState,
+    fieldsWidgetUngroupedFieldsDraftState,
+    fieldsWidgetEditorModeDraftState,
+    hasInitializedFieldsWidgetGroupsDraftState,
+    setIsPageLayoutInEditMode,
+    exitLayoutCustomizationMode,
+    invalidateMetadataStore,
+  ]);
 
   return { refreshPageLayoutAfterReset };
 };