Update unique fields on standard field - include soft deleted records (#14562)

Done : 
- migrate standard unique fields (add : -old)
- deactivate defaultWhereClause
- restore soft deleted if upserted (same for contact creation in mailing
sync)

fixes https://github.com/twentyhq/twenty/issues/14443

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-server/src/engine/api/graphql/graphql-query-runner/resolvers/graphql-query-create-many-resolver.service.ts

@@ -388,7 +388,7 @@ export class GraphqlQueryCreateManyResolverService extends GraphqlQueryBaseResol
     const savedRecords = await repository.updateMany(
       partialRecordsToUpdateWithoutCreatedByUpdate.map((record) => ({
         criteria: record.id,
-        partialEntity: record,
+        partialEntity: { ...record, deletedAt: null },
       })),
       undefined,
       columnsToReturn,

packages/twenty-server/src/engine/metadata-modules/index-metadata/index-metadata.service.ts

@@ -269,7 +269,10 @@ export class IndexMetadataService {
     queryRunner,
   }: {
     workspaceId: string;
-    objectMetadata: ObjectMetadataEntity;
+    objectMetadata: Pick<
+      ObjectMetadataEntity,
+      'nameSingular' | 'isCustom' | 'id'
+    >;
     fieldMetadataToIndex: Partial<FieldMetadataEntity>[];
     queryRunner?: QueryRunner;
   }) {

packages/twenty-server/src/engine/twenty-orm/decorators/workspace-is-unique.decorator.ts

@@ -19,7 +19,7 @@ export function WorkspaceIsUnique(): PropertyDecorator {
     const columns = [propertyKey.toString()];
 
     metadataArgsStorage.addIndexes({
-      name: `IDX_UNIQUE_${generateDeterministicIndexName([
+      name: `IDX_${generateDeterministicIndexName([
         convertClassNameToObjectMetadataName(target.constructor.name),
         ...columns,
       ])}`,

packages/twenty-server/src/engine/workspace-manager/workspace-migration-builder/factories/utils/__tests__/workspace-migration-index.factory.util.spec.ts

@@ -46,9 +46,7 @@ describe('WorkspaceMigrationIndexFactory', () => {
     expect(firstMigration.indexes[0].columns).toEqual(['simpleField']);
     expect(firstMigration.indexes[0].type).toBe('BTREE');
     expect(firstMigration.indexes[0].isUnique).toBe(true);
-    expect(firstMigration.indexes[0].where).toBe(
-      '"simpleField" != \'\' AND "deletedAt" IS NULL',
-    );
+    expect(firstMigration.indexes[0].where).toBe('"simpleField" != \'\'');
   });
 
   it('should create index migrations for relation fields', async () => {

packages/twenty-server/src/engine/workspace-manager/workspace-migration-builder/factories/utils/workspace-migration-index.factory.utils.ts

@@ -88,7 +88,7 @@ export const createIndexMigration = async (
         .filter(isDefined);
 
       const defaultWhereClause = indexMetadata.isUnique
-        ? `${columns.map((column) => `"${column}"`).join(" != '' AND ")} != '' AND "deletedAt" IS NULL`
+        ? `${columns.map((column) => `"${column}"`).join(" != '' AND ")} != ''`
         : null;
 
       return {