Fix ci + improvements (#17795)

as title

packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/utils/copy-executor.ts

@@ -1,12 +1,21 @@
 import { promises as fs } from 'fs';
+import { resolve, join } from 'path';
 
-import { getExecutorFilePath } from 'src/engine/core-modules/logic-function/logic-function-drivers/utils/get-executor-file-path';
+import { ASSET_PATH } from 'src/constants/assets-path';
+
+const EXECUTOR_FILE_PATH = resolve(
+  __dirname,
+  join(
+    ASSET_PATH,
+    `engine/core-modules/logic-function/logic-function-drivers/constants/executor`,
+  ),
+);
 
 export const copyExecutor = async (buildDirectory: string) => {
   await fs.mkdir(buildDirectory, {
     recursive: true,
   });
-  await fs.cp(getExecutorFilePath(), buildDirectory, {
+  await fs.cp(EXECUTOR_FILE_PATH, buildDirectory, {
     recursive: true,
   });
 };

packages/twenty-server/src/engine/core-modules/logic-function/logic-function-drivers/utils/get-executor-file-path.ts

@@ -1,12 +0,0 @@
-import path from 'path';
-
-import { ASSET_PATH } from 'src/constants/assets-path';
-
-export const getExecutorFilePath = (): string => {
-  const baseTypescriptProjectPath = path.join(
-    ASSET_PATH,
-    `engine/core-modules/logic-function/logic-function-drivers/constants/executor`,
-  );
-
-  return path.resolve(__dirname, baseTypescriptProjectPath);
-};

packages/twenty-server/src/engine/metadata-modules/logic-function/dtos/create-logic-function.input.ts

@@ -1,15 +1,6 @@
 import { Field, HideField, InputType } from '@nestjs/graphql';
 
-import {
-  IsBoolean,
-  IsNotEmpty,
-  IsNumber,
-  IsObject,
-  IsOptional,
-  IsString,
-  Max,
-  Min,
-} from 'class-validator';
+import { IsObject, IsOptional, IsString } from 'class-validator';
 import graphqlTypeJson from 'graphql-type-json';
 import {
   CronTriggerSettings,
@@ -18,35 +9,10 @@ import {
 } from 'twenty-shared/application';
 
 import type { JsonbProperty } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/jsonb-property.type';
+import { CreateDefaultLogicFunctionInput } from 'src/engine/metadata-modules/logic-function/dtos/create-default-logic-function.input';
 
 @InputType()
-export class CreateLogicFunctionInput {
-  @IsString()
-  @IsNotEmpty()
-  @Field()
-  name: string;
-
-  @IsString()
-  @IsOptional()
-  @Field({ nullable: true })
-  description?: string;
-
-  @IsNumber()
-  @Field({ nullable: true })
-  @Min(1)
-  @Max(900)
-  @IsOptional()
-  timeoutSeconds?: number;
-
-  @HideField()
-  applicationId: string;
-
-  @HideField()
-  universalIdentifier?: string;
-
-  @HideField()
-  id: string;
-
+export class CreateLogicFunctionInput extends CreateDefaultLogicFunctionInput {
   @HideField()
   checksum: string;
 
@@ -62,16 +28,6 @@ export class CreateLogicFunctionInput {
   @Field({ nullable: false })
   builtHandlerPath: string;
 
-  @Field(() => graphqlTypeJson, { nullable: true })
-  @IsObject()
-  @IsOptional()
-  toolInputSchema?: object;
-
-  @IsBoolean()
-  @Field({ nullable: true })
-  @IsOptional()
-  isTool?: boolean;
-
   @IsObject()
   @Field(() => graphqlTypeJson, { nullable: true })
   @IsOptional()

packages/twenty-server/src/engine/metadata-modules/logic-function/utils/from-create-logic-function-input-to-flat-logic-function.util.ts

@@ -19,7 +19,7 @@ export const fromCreateLogicFunctionInputToFlatLogicFunction = ({
   workspaceId,
   ownerFlatApplication,
 }: FromCreateLogicFunctionInputToFlatLogicFunctionArgs): FlatLogicFunction => {
-  const id = rawCreateLogicFunctionInput.id;
+  const id = rawCreateLogicFunctionInput.id ?? v4();
   const currentDate = new Date();
 
   const sourceHandlerPath = rawCreateLogicFunctionInput.sourceHandlerPath;