Refactor application module architecture for clarity and explicitness (#18432)
## Summary - **Module reorganization**: Moved `ApplicationUpgradeService` and cron jobs to `application-upgrade/`, `ApplicationSyncService` to `application-manifest/`, and `runWorkspaceMigration`/`uninstallApplication` mutations to the manifest resolver — each module now has a single clear responsibility. - **Explicit install flow**: Removed implicit `ApplicationEntity` creation from `ApplicationSyncService`. The install service and dev resolver now explicitly create the `ApplicationEntity` before syncing. npm packages are resolved at registration time to extract manifest metadata (universalIdentifier, name, description, etc.), eliminating the `reconcileUniversalIdentifier` hack. - **Better error handling**: Frontend hooks now surface actual server error messages in snackbars instead of swallowing them. Replaced the ugly `ConfirmationModal` for transfer ownership with a proper form modal. Fixed `SettingsAdminTableCard` row height overflow and corrected the `yarn-engine` asset path. ## Test plan - [ ] Register an npm package — verify manifest metadata (name, description, universalIdentifier) is extracted correctly - [ ] Install a registered npm app on a workspace — verify ApplicationEntity is created and sync succeeds - [ ] Test `app:dev` CLI flow — verify local app registration and sync work - [ ] Upload a tarball — verify registration and install flow - [ ] Transfer ownership — verify the new modal UX works - [ ] Verify error messages appear correctly in snackbars when operations fail Made with [Cursor](https://cursor.com)
This commit is contained in:
+3
@@ -16,6 +16,9 @@ export const APPLICATION_REGISTRATION_FRAGMENT = gql`
|
||||
latestAvailableVersion
|
||||
websiteUrl
|
||||
termsUrl
|
||||
isListed
|
||||
isFeatured
|
||||
ownerWorkspaceId
|
||||
createdAt
|
||||
updatedAt
|
||||
}
|
||||
|
||||
+16
@@ -0,0 +1,16 @@
|
||||
import { gql } from '@apollo/client';
|
||||
|
||||
export const TRANSFER_APPLICATION_REGISTRATION_OWNERSHIP = gql`
|
||||
mutation TransferApplicationRegistrationOwnership(
|
||||
$applicationRegistrationId: String!
|
||||
$targetWorkspaceSubdomain: String!
|
||||
) {
|
||||
transferApplicationRegistrationOwnership(
|
||||
applicationRegistrationId: $applicationRegistrationId
|
||||
targetWorkspaceSubdomain: $targetWorkspaceSubdomain
|
||||
) {
|
||||
id
|
||||
name
|
||||
}
|
||||
}
|
||||
`;
|
||||
+7
@@ -0,0 +1,7 @@
|
||||
import { gql } from '@apollo/client';
|
||||
|
||||
export const APPLICATION_REGISTRATION_TARBALL_URL = gql`
|
||||
query ApplicationRegistrationTarballUrl($id: String!) {
|
||||
applicationRegistrationTarballUrl(id: $id)
|
||||
}
|
||||
`;
|
||||
Reference in New Issue
Block a user