Refactor application module architecture for clarity and explicitness (#18432)

## Summary - **Module reorganization**: Moved `ApplicationUpgradeService` and cron jobs to `application-upgrade/`, `ApplicationSyncService` to `application-manifest/`, and `runWorkspaceMigration`/`uninstallApplication` mutations to the manifest resolver — each module now has a single clear responsibility. - **Explicit install flow**: Removed implicit `ApplicationEntity` creation from `ApplicationSyncService`. The install service and dev resolver now explicitly create the `ApplicationEntity` before syncing. npm packages are resolved at registration time to extract manifest metadata (universalIdentifier, name, description, etc.), eliminating the `reconcileUniversalIdentifier` hack. - **Better error handling**: Frontend hooks now surface actual server error messages in snackbars instead of swallowing them. Replaced the ugly `ConfirmationModal` for transfer ownership with a proper form modal. Fixed `SettingsAdminTableCard` row height overflow and corrected the `yarn-engine` asset path. ## Test plan - [ ] Register an npm package — verify manifest metadata (name, description, universalIdentifier) is extracted correctly - [ ] Install a registered npm app on a workspace — verify ApplicationEntity is created and sync succeeds - [ ] Test `app:dev` CLI flow — verify local app registration and sync work - [ ] Upload a tarball — verify registration and install flow - [ ] Transfer ownership — verify the new modal UX works - [ ] Verify error messages appear correctly in snackbars when operations fail Made with [Cursor](https://cursor.com)
2026-03-06 08:45:08 +01:00
parent 90cced0e74
commit 514d0017ea
184 changed files with 3179 additions and 1382 deletions
@@ -0,0 +1,107 @@
+import { FIND_ALL_APPLICATION_REGISTRATIONS } from '@/settings/admin-panel/apps/graphql/queries/findAllApplicationRegistrations';
+import { Table } from '@/ui/layout/table/components/Table';
+import { TableBody } from '@/ui/layout/table/components/TableBody';
+import { TableCell } from '@/ui/layout/table/components/TableCell';
+import { TableHeader } from '@/ui/layout/table/components/TableHeader';
+import { TableRow } from '@/ui/layout/table/components/TableRow';
+import { useQuery } from '@apollo/client';
+import { styled } from '@linaria/react';
+import { t } from '@lingui/core/macro';
+import { useState } from 'react';
+import { getSettingsPath } from 'twenty-shared/utils';
+import { SettingsPath } from 'twenty-shared/types';
+import { H2Title, Status } from 'twenty-ui/display';
+import { SearchInput } from 'twenty-ui/input';
+import { Section } from 'twenty-ui/layout';
+import { UndecoratedLink } from 'twenty-ui/navigation';
+import { themeCssVariables } from 'twenty-ui/theme-constants';
+import { type ApplicationRegistrationFragmentFragment } from '~/generated-metadata/graphql';
+
+const StyledTableContainer = styled.div`
+  margin-top: ${themeCssVariables.spacing[3]};
+`;
+
+const StyledTableHeaderRowContainer = styled.div`
+  margin-bottom: ${themeCssVariables.spacing[2]};
+`;
+
+const TABLE_GRID = '1fr 1fr 100px 80px';
+
+export const SettingsAdminApps = () => {
+  const [searchQuery, setSearchQuery] = useState('');
+
+  const { data } = useQuery(FIND_ALL_APPLICATION_REGISTRATIONS);
+
+  const registrations: ApplicationRegistrationFragmentFragment[] =
+    data?.findAllApplicationRegistrations ?? [];
+
+  const filtered =
+    searchQuery.trim().length === 0
+      ? registrations
+      : registrations.filter((registration) => {
+          const query = searchQuery.toLowerCase();
+
+          return (
+            registration.name.toLowerCase().includes(query) ||
+            (registration.sourcePackage ?? '').toLowerCase().includes(query) ||
+            registration.universalIdentifier.toLowerCase().includes(query)
+          );
+        });
+
+  return (
+    <Section>
+      <H2Title
+        title={t`All App Registrations`}
+        description={t`All application registrations across the platform, including orphaned marketplace apps`}
+      />
+      <SearchInput
+        placeholder={t`Search registrations...`}
+        value={searchQuery}
+        onChange={setSearchQuery}
+      />
+      <StyledTableContainer>
+        <Table>
+          <StyledTableHeaderRowContainer>
+            <TableRow gridTemplateColumns={TABLE_GRID}>
+              <TableHeader>{t`Name`}</TableHeader>
+              <TableHeader>{t`Source`}</TableHeader>
+              <TableHeader>{t`Listed`}</TableHeader>
+              <TableHeader>{t`Featured`}</TableHeader>
+            </TableRow>
+          </StyledTableHeaderRowContainer>
+          <TableBody>
+            {filtered.map((registration) => (
+              <UndecoratedLink
+                key={registration.id}
+                to={getSettingsPath(
+                  SettingsPath.ApplicationRegistrationDetail,
+                  { applicationRegistrationId: registration.id },
+                )}
+                fullWidth
+              >
+                <TableRow gridTemplateColumns={TABLE_GRID} isClickable>
+                  <TableCell>{registration.name}</TableCell>
+                  <TableCell>
+                    {registration.sourcePackage ?? registration.sourceType}
+                  </TableCell>
+                  <TableCell>
+                    <Status
+                      color={registration.isListed ? 'green' : 'gray'}
+                      text={registration.isListed ? t`Yes` : t`No`}
+                    />
+                  </TableCell>
+                  <TableCell>
+                    <Status
+                      color={registration.isFeatured ? 'yellow' : 'gray'}
+                      text={registration.isFeatured ? t`Yes` : t`No`}
+                    />
+                  </TableCell>
+                </TableRow>
+              </UndecoratedLink>
+            ))}
+          </TableBody>
+        </Table>
+      </StyledTableContainer>
+    </Section>
+  );
+};