From 50c8834e21d474c26f83c591a80afe30d35e0d9d Mon Sep 17 00:00:00 2001 From: Etienne <45695613+etiennejouan@users.noreply.github.com> Date: Mon, 25 May 2026 14:03:18 +0200 Subject: [PATCH] fix(billing) - skip redundant cap writes (#20882) fixes https://sonarly.com/issue/40207 --- .../core-modules/billing/services/billing-usage.service.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/billing-usage.service.ts b/packages/twenty-server/src/engine/core-modules/billing/services/billing-usage.service.ts index 973077da5e..6000bf8ad3 100644 --- a/packages/twenty-server/src/engine/core-modules/billing/services/billing-usage.service.ts +++ b/packages/twenty-server/src/engine/core-modules/billing/services/billing-usage.service.ts @@ -317,7 +317,10 @@ export class BillingUsageService { -usedCredits, ); - if (decrementedAvailableCredits <= 0) { + const hasJustReachedCap = + availableCredits > 0 && decrementedAvailableCredits <= 0; + + if (hasJustReachedCap) { await this.billingUsageCapService.setSubscriptionItemHasReachedCap( workspaceId, true,