Remove duplicate plus sign for phone numbers (#8871)
Fixes #8838 1. Summary It seems [this PR](https://github.com/twentyhq/twenty/pull/8614) caused the issue. We added a plus sign on front-end when the [callingCode](https://github.com/twentyhq/twenty/blob/c735026f6c4f011e82e80713f1554b5cdb4fda5b/packages/twenty-front/src/modules/ui/field/display/components/PhonesDisplay.tsx#L70) retrieved from back-end already has a plus sign. 2. Solution @guillim Please let me know if I missed a case where the plus sign is not there for the `callingCode`. If so, I think we should check whether or not `callingCode` has a leading plus sign on front-end before adding it. For now, I just removed the code that appends a plus sign on front-end. 3. Screenshots  --------- Co-authored-by: guillim <guigloo@msn.com> Co-authored-by: Guillim <guillim@users.noreply.github.com> Co-authored-by: Weiko <deniaud.corentin@gmail.com>
This commit is contained in:
+1
-1
@@ -37,7 +37,7 @@ export const SettingsDataModelFieldPhonesForm = ({
|
||||
.sort((a, b) => a.countryName.localeCompare(b.countryName))
|
||||
.map((country) => ({
|
||||
label: `${country.countryName} (+${country.callingCode})`,
|
||||
value: `${country.callingCode}`,
|
||||
value: `+${country.callingCode}`,
|
||||
}));
|
||||
countries.unshift({ label: 'No country', value: '' });
|
||||
const defaultDefaultValue = {
|
||||
|
||||
+2
-2
@@ -22,9 +22,9 @@ export const getPhonesFieldPreviewValue = ({
|
||||
const primaryPhoneCountryCode =
|
||||
fieldMetadataItem.defaultValue?.primaryPhoneCountryCode &&
|
||||
fieldMetadataItem.defaultValue.primaryPhoneCountryCode !== ''
|
||||
? `+${stripSimpleQuotesFromString(
|
||||
? stripSimpleQuotesFromString(
|
||||
fieldMetadataItem.defaultValue?.primaryPhoneCountryCode,
|
||||
)}`
|
||||
)
|
||||
: null;
|
||||
return {
|
||||
...placeholderDefaultValue,
|
||||
|
||||
Reference in New Issue
Block a user