houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Activate v2 default seed (#14660)

Browse Source 
## Introduction
After enabling flag by default got following errors:
```ts
Test Suites: 48 failed, 1 skipped, 97 passed, 145 of 146 total
Tests:       499 failed, 1 skipped, 644 passed, 1144 total
Snapshots:   61 failed, 133 passed, 194 total
Time:        363.226 s
Ran all test suites.
```

## From
<img width="2952" height="1510" alt="image"
src="https://github.com/user-attachments/assets/7e3b20c6-2552-40a7-90bb-2d7b3002c895"
/>

## To
<img width="3134" height="1510" alt="image"
src="https://github.com/user-attachments/assets/4fc9ada4-3c14-4333-a1db-11daf87db8d6"
/>

There's a huge test bundle in the latest shard that we could split up

## Notes
- Set as failing morph relation field rename as for the moment we do not
handle relation field mutation
- fixed the object update and creation validation adding label
identifier field metadata id checks
- and more

Some integrations tests are still on the v1 ( they have before and after
all disabling and re-enabling the flat ) but mainly we now have more
coverage on the v2 than the v1.
Mainly related records, uniqueness have to be migrated the v2 and so
tests too
This commit is contained in:
Paul Rastoin
2025-09-26 16:05:09 +02:00
committed by GitHub
parent ead351cb9e
commit 4fbdfb6abc
101 changed files with 3601 additions and 1649 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-server/src/engine/metadata-modules/field-metadata/services/field-metadata.service-v2.ts
+2 -2
View File
@@ -381,9 +381,9 @@ export class FieldMetadataServiceV2 {
return this.fieldMetadataRepository.find({
where: {
name: In(
id: In(
allTranspiledTranspilationInputs.map(
({ result: { flatFieldMetadatas } }) => flatFieldMetadatas[0].name,
({ result: { flatFieldMetadatas } }) => flatFieldMetadatas[0].id,
),
),
workspaceId,
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/compare-two-flat-field-metadata.util.ts
+1 -18
View File
@@ -1,16 +1,13 @@
import diff from 'microdiff';
import { type FromTo } from 'twenty-shared/types';
import { isDefined, parseJson } from 'twenty-shared/utils';
import { parseJson } from 'twenty-shared/utils';
import { FLAT_FIELD_METADATA_JSONB_PROPERTIES } from 'src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-jsonb-properties.constant';
import { FLAT_FIELD_METADATA_PROPERTIES_TO_COMPARE } from 'src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-properties-to-compare.constant';
import { FLAT_FIELD_METADATA_RELATION_PROPERTIES_TO_COMPARE } from 'src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-relation-properties-to-compare.constant';
import { type FlatFieldMetadataPropertiesToCompare } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata-properties-to-compare.type';
import { type FlatFieldMetadataRelationPropertiesToCompare } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata-relation-properties-to-compare.type';
import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
import { isFlatFieldMetadataJsonbProperty } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-flat-field-metadata-jsonb-property.util';
import { isStandardMetadata } from 'src/engine/metadata-modules/utils/is-standard-metadata.util';
import { isMorphOrRelationFieldMetadataType } from 'src/engine/utils/is-morph-or-relation-field-metadata-type.util';
import { type UpdateFieldAction } from 'src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/types/workspace-migration-field-action-v2';
import { transformMetadataForComparison } from 'src/engine/workspace-manager/workspace-sync-metadata/comparators/utils/transform-metadata-for-comparison.util';
@@ -38,20 +35,6 @@ export const compareTwoFlatFieldMetadata = ({
return true;
}
// Remove below assertion when we authorize relation edition, see https://github.com/twentyhq/twenty/commit/39f6f3c4bb101272a9014e142a842d0801a3c33b
const isMorphOrRelationFieldType =
isDefined(fieldMetadata.type) &&
isMorphOrRelationFieldMetadataType(fieldMetadata.type);
if (
isMorphOrRelationFieldType &&
!FLAT_FIELD_METADATA_RELATION_PROPERTIES_TO_COMPARE.includes(
property as FlatFieldMetadataRelationPropertiesToCompare,
)
) {
return true;
}
if (
isStandardMetadata(fieldMetadata) &&
property !== 'standardOverrides'
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/validate-relation-creation-payload.util.ts
+1 -1
View File
@@ -42,7 +42,7 @@ export const validateRelationCreationPayload = async ({
status: 'fail',
error: {
code: FieldMetadataExceptionCode.FIELD_METADATA_RELATION_MALFORMED,
message: `Relation creation payload is invalid ${JSON.stringify(relationCreationPayload)}`,
message: `Relation creation payload is invalid`,
userFriendlyMessage: t`Invalid relation creation payload`,
value: relationCreationPayload,
},
packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/services/flat-object-metadata-validator.service.ts
+61 -1
View File
@@ -1,7 +1,10 @@
import { Injectable } from '@nestjs/common';
import { t } from '@lingui/core/macro';
import { isDefined } from 'twenty-shared/utils';
import {
isDefined,
isLabelIdentifierFieldMetadataTypes,
} from 'twenty-shared/utils';
import { FlatFieldMetadataValidatorService } from 'src/engine/metadata-modules/flat-field-metadata/services/flat-field-metadata-validator.service';
import { FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
@@ -73,6 +76,12 @@ export class FlatObjectMetadataValidatorService {
...validateFlatObjectMetadataIdentifiers(existingFlatObjectMetadata),
);
validationResult.errors.push(
...this.validateFlatObjectMetadataLabelIdentifierFieldMetadataId({
flatObjectMetadata: updatedFlatObjectMetadata,
}),
);
return validationResult;
}
@@ -188,6 +197,12 @@ export class FlatObjectMetadataValidatorService {
});
}
objectValidationResult.errors.push(
...this.validateFlatObjectMetadataLabelIdentifierFieldMetadataId({
flatObjectMetadata: flatObjectMetadataToValidate,
}),
);
objectValidationResult.errors.push(
...this.validateFlatObjectMetadataNameAndLabels({
existingFlatObjectMetadataMaps,
@@ -295,4 +310,49 @@ export class FlatObjectMetadataValidatorService {
return errors;
}
private validateFlatObjectMetadataLabelIdentifierFieldMetadataId({
flatObjectMetadata,
}: {
flatObjectMetadata: FlatObjectMetadata;
}) {
const errors: FlatObjectMetadataValidationError[] = [];
if (!isDefined(flatObjectMetadata.labelIdentifierFieldMetadataId)) {
errors.push({
code: ObjectMetadataExceptionCode.MISSING_CUSTOM_OBJECT_DEFAULT_LABEL_IDENTIFIER_FIELD,
message: t`Label identifier field metadata is required`,
userFriendlyMessage: t`Label identifier field metadata is required`,
});
} else {
const relatedFlatFieldMetadata =
flatObjectMetadata.flatFieldMetadatas.find(
(flatFieldMetadata) =>
flatFieldMetadata.id ===
flatObjectMetadata.labelIdentifierFieldMetadataId,
);
if (!relatedFlatFieldMetadata) {
errors.push({
code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,
message: t`Label identifier field metadata not found in field metadata list`,
userFriendlyMessage: t`Label identifier field metadata not found in field metadata list`,
value: flatObjectMetadata.labelIdentifierFieldMetadataId,
});
} else {
if (
!isLabelIdentifierFieldMetadataTypes(relatedFlatFieldMetadata.type)
) {
errors.push({
code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,
message: t`Label identifier field metadata must be a TEXT or FULL_NAME field type`,
userFriendlyMessage: t`Label identifier field metadata must be a TEXT or FULL_NAME field type`,
value: relatedFlatFieldMetadata.type,
});
}
}
}
return errors;
}
}
packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-delete-object-input-to-flat-field-metadatas-to-delete.util.ts
+1 -1
View File
@@ -68,7 +68,7 @@ export const fromDeleteObjectInputToFlatFieldMetadatasToDelete = ({
},
);
// We should maintain a idsByObjectMetadataId maps in the index
// TODO We should maintain a idsByObjectMetadataId in the flatIndexMaps
const flatIndexMetadataToDelete = Object.values(
existingFlatIndexMaps.byId,
).filter(
packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/rename-related-morph-field-on-object-names-update.util.ts
+1 -1
View File
@@ -37,7 +37,7 @@ type RenameRelatedMorphFieldOnObjectNamesUpdateArgs = FromTo<
> & {
existingFlatObjectMetadataMaps: FlatObjectMetadataMaps;
};
// We should recompute each index here too ? YES TODO prastoin
// TODO We should recompute each index here too
export const renameRelatedMorphFieldOnObjectNamesUpdate = ({
fromFlatObjectMetadata,
existingFlatObjectMetadataMaps,
packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata-v2.service.ts
+2 -14
View File
@@ -76,18 +76,6 @@ export class ObjectMetadataServiceV2 {
flatIndexMaps: existingFlatIndexMaps,
});
const impactedObjectMetadataIds = [
...new Set([
optimisticallyUpdatedFlatObjectMetadata.id,
...otherObjectFlatFieldMetadatas.map(
(flatFieldMetadata) => flatFieldMetadata.objectMetadataId,
),
]),
];
const fromFlatObjectMetadataMaps = getSubFlatObjectMetadataMapsOrThrow({
flatObjectMetadataMaps: existingFlatObjectMetadataMaps,
objectMetadataIds: impactedObjectMetadataIds,
});
const toFlatObjectMetadataMaps = otherObjectFlatFieldMetadatas.reduce(
(flatObjectMetadataMaps, flatFieldMetadata) =>
replaceFlatFieldMetadataInFlatObjectMetadataMapsOrThrow({
@@ -96,7 +84,7 @@ export class ObjectMetadataServiceV2 {
}),
replaceFlatObjectMetadataInFlatObjectMetadataMapsOrThrow({
flatObjectMetadata: optimisticallyUpdatedFlatObjectMetadata,
flatObjectMetadataMaps: fromFlatObjectMetadataMaps,
flatObjectMetadataMaps: existingFlatObjectMetadataMaps,
}),
);
@@ -114,7 +102,7 @@ export class ObjectMetadataServiceV2 {
{
fromToAllFlatEntityMaps: {
flatObjectMetadataMaps: {
from: fromFlatObjectMetadataMaps,
from: existingFlatObjectMetadataMaps,
to: toFlatObjectMetadataMaps,
},
flatIndexMaps: {