From 4a87706d0b176d6622fd4cfa3d1f4ad46272d7e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Bosi?= <71827178+bosiraphael@users.noreply.github.com> Date: Mon, 3 Nov 2025 17:25:59 +0100 Subject: [PATCH] Fix chart filter settings back button behavior (#15573) Before: https://github.com/user-attachments/assets/23881978-3234-4a0b-95ec-15470d26026d After: https://github.com/user-attachments/assets/80d222f6-585a-4fff-8476-dae327e34699 --- .../page-layout/components/ChartFiltersSettings.tsx | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/packages/twenty-front/src/modules/command-menu/pages/page-layout/components/ChartFiltersSettings.tsx b/packages/twenty-front/src/modules/command-menu/pages/page-layout/components/ChartFiltersSettings.tsx index 9da140a03d..544cd2a064 100644 --- a/packages/twenty-front/src/modules/command-menu/pages/page-layout/components/ChartFiltersSettings.tsx +++ b/packages/twenty-front/src/modules/command-menu/pages/page-layout/components/ChartFiltersSettings.tsx @@ -1,13 +1,12 @@ import { CommandMenuSubPageNavigationHeader } from '@/command-menu/pages/common/components/CommandMenuSubPageNavigationHeader'; import { ChartFiltersSettingsInitializeStateEffect } from '@/command-menu/pages/page-layout/components/ChartFiltersSettingsInitializeStateEffect'; -import { useNavigatePageLayoutCommandMenu } from '@/command-menu/pages/page-layout/hooks/useNavigatePageLayoutCommandMenu'; +import { useCommandMenuHistory } from '@/command-menu/hooks/useCommandMenuHistory'; import { usePageLayoutIdFromContextStoreTargetedRecord } from '@/command-menu/pages/page-layout/hooks/usePageLayoutFromContextStoreTargetedRecord'; import { useUpdateCurrentWidgetConfig } from '@/command-menu/pages/page-layout/hooks/useUpdateCurrentWidgetConfig'; import { type ChartWidget } from '@/command-menu/pages/page-layout/types/ChartWidget'; import { type ChartWidgetConfiguration } from '@/command-menu/pages/page-layout/types/ChartWidgetConfiguration'; import { getChartFiltersSettingsInstanceId } from '@/command-menu/pages/page-layout/utils/getChartFiltersSettingsInstanceId'; -import { CommandMenuPages } from '@/command-menu/types/CommandMenuPages'; import { type ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem'; import { AdvancedFilterCommandMenuContainer } from '@/object-record/advanced-filter/command-menu/components/AdvancedFilterCommandMenuContainer'; import { RecordFilterGroupsComponentInstanceContext } from '@/object-record/record-filter-group/states/context/RecordFilterGroupsComponentInstanceContext'; @@ -39,13 +38,7 @@ export const ChartFiltersSettings = ({ objectMetadataItem, widget, }: ChartFiltersSettingsProps) => { - const { navigatePageLayoutCommandMenu } = useNavigatePageLayoutCommandMenu(); - - const handleBackClick = () => { - navigatePageLayoutCommandMenu({ - commandMenuPage: CommandMenuPages.PageLayoutGraphTypeSelect, - }); - }; + const { goBackFromCommandMenu } = useCommandMenuHistory(); const { instanceId } = getChartFiltersSettingsInstanceId({ widgetId: widget.id, @@ -105,7 +98,7 @@ export const ChartFiltersSettings = ({
{t`Conditions`}