Refactor flat entity maps to be universal oriented (#17665)
# Introduction
In preparation of the workspace agnostic builder, we're migrating
`FlatEntityMaps` to be universal identifier oriented and based
As in the builder context there're won't be any ids at all
Please also note that the FlatEntity is a UniversalFlatEntity superset
From
```ts
import { type SyncableFlatEntity } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-from.type';
export type FlatEntityMaps<T extends SyncableFlatEntity> = {
byId: Partial<Record<string, T>>;
idByUniversalIdentifier: Partial<Record<string, string>>;
universalIdentifiersByApplicationId: Partial<Record<string, string[]>>;
};
```
To
```ts
export type FlatEntityMaps<
T extends SyncableFlatEntity | UniversalSyncableFlatEntity,
> = {
byUniversalIdentifier: Partial<Record<string, T>>;
universalIdentifierById: Partial<Record<string, string>>;
universalIdentifiersByApplicationId: Partial<Record<string, string[]>>; // this might make more sense to be migrated to universalIdentifiersByApplicationUniversalIdentifier but it's the main topic of this PR
};
```
## Low level maps tools
Had to refactor find | create | delete | replace | find-many | get-sub
tools ( through mutations and or throw equivalent )
This commit is contained in:
+18
-7
@@ -6,6 +6,10 @@ import { isDefined } from 'twenty-shared/utils';
|
||||
import { type DataSourceEntity } from 'src/engine/metadata-modules/data-source/data-source.entity';
|
||||
import { FieldMetadataService } from 'src/engine/metadata-modules/field-metadata/services/field-metadata.service';
|
||||
import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
|
||||
import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
|
||||
import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps.util';
|
||||
import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
|
||||
import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
|
||||
import { buildObjectIdByNameMaps } from 'src/engine/metadata-modules/flat-object-metadata/utils/build-object-id-by-name-maps.util';
|
||||
import { ObjectMetadataService } from 'src/engine/metadata-modules/object-metadata/object-metadata.service';
|
||||
import {
|
||||
@@ -47,10 +51,9 @@ type JunctionConfigSeed = {
|
||||
label?: string;
|
||||
};
|
||||
|
||||
// Helper type for flat entity maps
|
||||
type FlatMaps = {
|
||||
fieldMaps: { byId: Record<string, { name: string; morphId?: string }> };
|
||||
objectMaps: { byId: Record<string, { fieldIds: string[] }> };
|
||||
flatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata>;
|
||||
flatObjectMetadataMaps: FlatEntityMaps<FlatObjectMetadata>;
|
||||
objectIdByName: Record<string, string>;
|
||||
};
|
||||
|
||||
@@ -324,8 +327,8 @@ export class DevSeederMetadataService {
|
||||
);
|
||||
|
||||
return {
|
||||
fieldMaps: flatFieldMetadataMaps as FlatMaps['fieldMaps'],
|
||||
objectMaps: flatObjectMetadataMaps as FlatMaps['objectMaps'],
|
||||
flatFieldMetadataMaps,
|
||||
flatObjectMetadataMaps,
|
||||
objectIdByName: idByNameSingular,
|
||||
};
|
||||
}
|
||||
@@ -476,14 +479,22 @@ export class DevSeederMetadataService {
|
||||
throw new Error(`Object not found: ${objectName}`);
|
||||
}
|
||||
|
||||
const objectMetadata = flatMaps.objectMaps.byId[objectId];
|
||||
const objectMetadata = findFlatEntityByIdInFlatEntityMaps({
|
||||
flatEntityId: objectId,
|
||||
flatEntityMaps: flatMaps.flatObjectMetadataMaps,
|
||||
});
|
||||
|
||||
if (!isDefined(objectMetadata)) {
|
||||
throw new Error(`Object metadata not found: ${objectName}`);
|
||||
}
|
||||
|
||||
for (const fieldId of objectMetadata.fieldIds) {
|
||||
if (flatMaps.fieldMaps.byId[fieldId]?.name === fieldName) {
|
||||
const field = findFlatEntityByIdInFlatEntityMaps({
|
||||
flatEntityId: fieldId,
|
||||
flatEntityMaps: flatMaps.flatFieldMetadataMaps,
|
||||
});
|
||||
|
||||
if (field?.name === fieldName) {
|
||||
return fieldId;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user