Refactor flat entity maps to be universal oriented (#17665)

# Introduction
In preparation of the workspace agnostic builder, we're migrating
`FlatEntityMaps` to be universal identifier oriented and based
As in the builder context there're won't be any ids at all
Please also note that the FlatEntity is a UniversalFlatEntity superset

From
```ts
import { type SyncableFlatEntity } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-from.type';

export type FlatEntityMaps<T extends SyncableFlatEntity> = {
  byId: Partial<Record<string, T>>;
  idByUniversalIdentifier: Partial<Record<string, string>>;
  universalIdentifiersByApplicationId: Partial<Record<string, string[]>>;
};
```

To
```ts
export type FlatEntityMaps<
  T extends SyncableFlatEntity | UniversalSyncableFlatEntity,
> = {
  byUniversalIdentifier: Partial<Record<string, T>>;
  universalIdentifierById: Partial<Record<string, string>>;
  universalIdentifiersByApplicationId: Partial<Record<string, string[]>>; // this might make more sense to be migrated to universalIdentifiersByApplicationUniversalIdentifier but it's the main topic of this PR
};
```

## Low level maps tools
Had to refactor find | create | delete | replace | find-many | get-sub
tools ( through mutations and or throw equivalent )
This commit is contained in:
Paul Rastoin
2026-02-03 17:16:02 +01:00
committed by GitHub
parent 43042d55b2
commit 476bdf764c
202 changed files with 1853 additions and 909 deletions
@@ -110,7 +110,7 @@ describe('ObjectPermissionService', () => {
workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
{
flatObjectMetadataMaps: {
byId: {
byUniversalIdentifier: {
[systemObjectMetadataId]: {
id: systemObjectMetadataId,
isSystem: true,
@@ -122,7 +122,9 @@ describe('ObjectPermissionService', () => {
applicationId: null,
} as any,
},
idByUniversalIdentifier: {},
universalIdentifierById: {
[systemObjectMetadataId]: systemObjectMetadataId,
},
universalIdentifiersByApplicationId: {},
},
} as any,
@@ -167,7 +169,7 @@ describe('ObjectPermissionService', () => {
workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
{
flatObjectMetadataMaps: {
byId: {
byUniversalIdentifier: {
[customObjectMetadataId]: {
id: customObjectMetadataId,
isSystem: false,
@@ -179,7 +181,9 @@ describe('ObjectPermissionService', () => {
applicationId: null,
} as any,
},
idByUniversalIdentifier: {},
universalIdentifierById: {
[customObjectMetadataId]: customObjectMetadataId,
},
universalIdentifiersByApplicationId: {},
},
} as any,
@@ -254,8 +258,8 @@ describe('ObjectPermissionService', () => {
workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
{
flatObjectMetadataMaps: {
byId: {},
idByUniversalIdentifier: {},
byUniversalIdentifier: {},
universalIdentifierById: {},
universalIdentifiersByApplicationId: {},
},
} as any,
@@ -150,7 +150,7 @@ describe('FieldPermissionService', () => {
workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
{
flatObjectMetadataMaps: {
byId: {
byUniversalIdentifier: {
[testObjectMetadataId]: {
...objectMetadataItemMock,
id: testObjectMetadataId,
@@ -170,15 +170,22 @@ describe('FieldPermissionService', () => {
applicationId: null,
} as any,
},
idByUniversalIdentifier: {},
universalIdentifierById: {
[testObjectMetadataId]: testObjectMetadataId,
[fieldRelationMock.objectMetadataId]:
fieldRelationMock.objectMetadataId,
},
universalIdentifiersByApplicationId: {},
},
flatFieldMetadataMaps: {
byId: {
[testFieldMetadataId]: testFieldMetadata as any,
[fieldRelationMock.id]: fieldRelationMock as any,
byUniversalIdentifier: {
[testFieldMetadata.universalIdentifier]: testFieldMetadata as any,
[fieldRelationMock.universalIdentifier]: fieldRelationMock as any,
},
universalIdentifierById: {
[testFieldMetadataId]: testFieldMetadata.universalIdentifier,
[fieldRelationMock.id]: fieldRelationMock.universalIdentifier,
},
idByUniversalIdentifier: {},
universalIdentifiersByApplicationId: {},
},
} as any,
@@ -398,13 +405,13 @@ describe('FieldPermissionService', () => {
workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
{
flatObjectMetadataMaps: {
byId: {},
idByUniversalIdentifier: {},
byUniversalIdentifier: {},
universalIdentifierById: {},
universalIdentifiersByApplicationId: {},
},
flatFieldMetadataMaps: {
byId: {},
idByUniversalIdentifier: {},
byUniversalIdentifier: {},
universalIdentifierById: {},
universalIdentifiersByApplicationId: {},
},
} as any,
@@ -440,7 +447,7 @@ describe('FieldPermissionService', () => {
workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
{
flatObjectMetadataMaps: {
byId: {
byUniversalIdentifier: {
[testObjectMetadataId]: {
...systemObjectMetadata,
id: testObjectMetadataId,
@@ -451,12 +458,14 @@ describe('FieldPermissionService', () => {
applicationId: null,
} as any,
},
idByUniversalIdentifier: {},
universalIdentifierById: {
[testObjectMetadataId]: testObjectMetadataId,
},
universalIdentifiersByApplicationId: {},
},
flatFieldMetadataMaps: {
byId: {},
idByUniversalIdentifier: {},
byUniversalIdentifier: {},
universalIdentifierById: {},
universalIdentifiersByApplicationId: {},
},
} as any,
@@ -486,7 +495,7 @@ describe('FieldPermissionService', () => {
workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
{
flatObjectMetadataMaps: {
byId: {
byUniversalIdentifier: {
[testObjectMetadataId]: {
...objectMetadataItemMock,
id: testObjectMetadataId,
@@ -497,12 +506,14 @@ describe('FieldPermissionService', () => {
applicationId: null,
} as any,
},
idByUniversalIdentifier: {},
universalIdentifierById: {
[testObjectMetadataId]: testObjectMetadataId,
},
universalIdentifiersByApplicationId: {},
},
flatFieldMetadataMaps: {
byId: {},
idByUniversalIdentifier: {},
byUniversalIdentifier: {},
universalIdentifierById: {},
universalIdentifiersByApplicationId: {},
},
} as any,
@@ -15,6 +15,7 @@ import {
import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
import { isFieldMetadataTypeRelation } from 'src/engine/metadata-modules/field-metadata/utils/is-field-metadata-type-relation.util';
import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps.util';
import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
@@ -220,8 +221,10 @@ export class FieldPermissionService {
);
}
const flatObjectMetadata =
flatObjectMetadataMaps.byId[fieldPermission.objectMetadataId];
const flatObjectMetadata = findFlatEntityByIdInFlatEntityMaps({
flatEntityId: fieldPermission.objectMetadataId,
flatEntityMaps: flatObjectMetadataMaps,
});
if (!isDefined(flatObjectMetadata)) {
throw new PermissionsException(
@@ -243,8 +246,10 @@ export class FieldPermissionService {
);
}
const flatFieldMetadata =
flatFieldMetadataMaps.byId[fieldPermission.fieldMetadataId];
const flatFieldMetadata = findFlatEntityByIdInFlatEntityMaps({
flatEntityId: fieldPermission.fieldMetadataId,
flatEntityMaps: flatFieldMetadataMaps,
});
if (!isDefined(flatFieldMetadata)) {
throw new PermissionsException(
@@ -5,6 +5,7 @@ import { isDefined } from 'twenty-shared/utils';
import { In, Repository } from 'typeorm';
import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps.util';
import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
import {
type ObjectPermissionInput,
@@ -63,7 +64,10 @@ export class ObjectPermissionService {
input.objectPermissions.forEach((objectPermission) => {
const objectMetadataForObjectPermission =
flatObjectMetadataMaps.byId[objectPermission.objectMetadataId];
findFlatEntityByIdInFlatEntityMaps({
flatEntityId: objectPermission.objectMetadataId,
flatEntityMaps: flatObjectMetadataMaps,
});
if (!isDefined(objectMetadataForObjectPermission)) {
throw new PermissionsException(