Refactor flat entity maps to be universal oriented (#17665)
# Introduction
In preparation of the workspace agnostic builder, we're migrating
`FlatEntityMaps` to be universal identifier oriented and based
As in the builder context there're won't be any ids at all
Please also note that the FlatEntity is a UniversalFlatEntity superset
From
```ts
import { type SyncableFlatEntity } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-from.type';
export type FlatEntityMaps<T extends SyncableFlatEntity> = {
byId: Partial<Record<string, T>>;
idByUniversalIdentifier: Partial<Record<string, string>>;
universalIdentifiersByApplicationId: Partial<Record<string, string[]>>;
};
```
To
```ts
export type FlatEntityMaps<
T extends SyncableFlatEntity | UniversalSyncableFlatEntity,
> = {
byUniversalIdentifier: Partial<Record<string, T>>;
universalIdentifierById: Partial<Record<string, string>>;
universalIdentifiersByApplicationId: Partial<Record<string, string[]>>; // this might make more sense to be migrated to universalIdentifiersByApplicationUniversalIdentifier but it's the main topic of this PR
};
```
## Low level maps tools
Had to refactor find | create | delete | replace | find-many | get-sub
tools ( through mutations and or throw equivalent )
This commit is contained in:
+14
-7
@@ -12,6 +12,7 @@ import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadat
|
||||
import { AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';
|
||||
import { MetadataFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/metadata-flat-entity-maps.type';
|
||||
import { addFlatEntityToFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/add-flat-entity-to-flat-entity-maps-or-throw.util';
|
||||
import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps.util';
|
||||
import { findManyFlatEntityByIdInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-many-flat-entity-by-id-in-flat-entity-maps-or-throw.util';
|
||||
import { FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
|
||||
import { FlatIndexMetadata } from 'src/engine/metadata-modules/flat-index-metadata/types/flat-index-metadata.type';
|
||||
@@ -156,8 +157,10 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
|
||||
},
|
||||
);
|
||||
|
||||
const updatedFlatObjectMetadata =
|
||||
recomputedFlatObjectMetadataMaps.byId[flatObjectMetadataToUpdate.id];
|
||||
const updatedFlatObjectMetadata = findFlatEntityByIdInFlatEntityMaps({
|
||||
flatEntityId: flatObjectMetadataToUpdate.id,
|
||||
flatEntityMaps: recomputedFlatObjectMetadataMaps,
|
||||
});
|
||||
|
||||
if (!isDefined(updatedFlatObjectMetadata)) {
|
||||
throw new ObjectMetadataException(
|
||||
@@ -461,8 +464,10 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
|
||||
},
|
||||
);
|
||||
|
||||
const createdFlatObjectMetadata =
|
||||
recomputedFlatObjectMetadataMaps.byId[flatObjectMetadataToCreate.id];
|
||||
const createdFlatObjectMetadata = findFlatEntityByIdInFlatEntityMaps({
|
||||
flatEntityId: flatObjectMetadataToCreate.id,
|
||||
flatEntityMaps: recomputedFlatObjectMetadataMaps,
|
||||
});
|
||||
|
||||
if (!isDefined(createdFlatObjectMetadata)) {
|
||||
throw new ObjectMetadataException(
|
||||
@@ -584,10 +589,12 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
|
||||
},
|
||||
);
|
||||
|
||||
const deleteObjectInputs = Object.values(flatObjectMetadataMaps.byId)
|
||||
const deleteObjectInputs = Object.keys(
|
||||
flatObjectMetadataMaps.universalIdentifierById,
|
||||
)
|
||||
.filter(isDefined)
|
||||
.map<DeleteOneObjectInput>((flatObjectMetadata) => ({
|
||||
id: flatObjectMetadata.id,
|
||||
.map<DeleteOneObjectInput>((id) => ({
|
||||
id,
|
||||
}));
|
||||
|
||||
await this.deleteManyObjectMetadatas({
|
||||
|
||||
+1
-1
@@ -71,7 +71,7 @@ export const buildDefaultRelationFlatFieldMetadatasForCustomObject = ({
|
||||
flatApplication,
|
||||
}: BuildDefaultRelationFieldsForCustomObjectArgs): SourceAndTargetFlatFieldMetadatasRecord => {
|
||||
const objectIdByNameSingular = Object.values(
|
||||
existingFlatObjectMetadataMaps.byId,
|
||||
existingFlatObjectMetadataMaps.byUniversalIdentifier,
|
||||
).reduce<Record<string, string>>((acc, flatObject) => {
|
||||
if (!isDefined(flatObject)) {
|
||||
return acc;
|
||||
|
||||
Reference in New Issue
Block a user