Remove old relations (#11993)

This is a first PR to remove old relation logic

Next steps:
- remove relationMetadata from cache
- remove relationMetadata table content and structure
- refactor relationDefinition to leverage field.settings instead

packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/services/workspace-metadata-updater.service.ts

@@ -17,7 +17,6 @@ import { PartialFieldMetadata } from 'src/engine/workspace-manager/workspace-syn
 import { PartialIndexMetadata } from 'src/engine/workspace-manager/workspace-sync-metadata/interfaces/partial-index-metadata.interface';
 import { UpdaterOptions } from 'src/engine/workspace-manager/workspace-sync-metadata/interfaces/updater-options.interface';
 
-import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
 import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
 import { compositeTypeDefinitions } from 'src/engine/metadata-modules/field-metadata/composite-types';
 import { FieldMetadataComplexOption } from 'src/engine/metadata-modules/field-metadata/dtos/options.input';
@@ -369,15 +368,6 @@ export class WorkspaceMetadataUpdaterService {
     createdIndexMetadataCollection: IndexMetadataEntity[];
   }> {
     const indexMetadataRepository = manager.getRepository(IndexMetadataEntity);
-    const workspaceId = originalObjectMetadataCollection?.[0]?.workspaceId;
-    let isNewRelationEnabled = false;
-
-    if (workspaceId) {
-      isNewRelationEnabled = await this.featureFlagService.isFeatureEnabled(
-        FeatureFlagKey.IsNewRelationEnabled,
-        workspaceId,
-      );
-    }
 
     const convertIndexMetadataForSaving = (
       indexMetadata: PartialIndexMetadata,
@@ -391,7 +381,6 @@ export class WorkspaceMetadataUpdaterService {
           .find((object) => object.id === indexMetadata.objectMetadataId)
           ?.fields.find((field) => {
             if (
-              isNewRelationEnabled &&
               isFieldMetadataEntityOfType(field, FieldMetadataType.RELATION)
             ) {
               if (field.settings?.joinColumnName === column) {