PR comment followups (isNonEmptyString and rename WorkflowExecutionResult) (#13706)
Addressing two comments from Thomas and Charles
This commit is contained in:
+3
-1
@@ -1,5 +1,7 @@
|
||||
import { Injectable } from '@nestjs/common';
|
||||
|
||||
import { isNonEmptyString } from '@sniptt/guards';
|
||||
|
||||
import { ConnectedAccountWorkspaceEntity } from 'src/modules/connected-account/standard-objects/connected-account.workspace-entity';
|
||||
import {
|
||||
MessageImportDriverException,
|
||||
@@ -47,7 +49,7 @@ export class MicrosoftEmailAliasManagerService {
|
||||
})
|
||||
// @ts-expect-error legacy noImplicitAny
|
||||
.filter((address) => {
|
||||
return address !== '';
|
||||
return isNonEmptyString(address);
|
||||
}) || [];
|
||||
|
||||
return handleAliases;
|
||||
|
||||
+3
-4
@@ -150,10 +150,9 @@ export class CreateCompanyAndContactService {
|
||||
filteredContactsToCreateWithCompanyDomainNames.map((contact) => ({
|
||||
handle: contact.handle,
|
||||
displayName: contact.displayName,
|
||||
companyId:
|
||||
contact.companyDomainName && contact.companyDomainName !== ''
|
||||
? companiesObject[contact.companyDomainName]
|
||||
: undefined,
|
||||
companyId: isNonEmptyString(contact.companyDomainName)
|
||||
? companiesObject[contact.companyDomainName]
|
||||
: undefined,
|
||||
createdBySource: source,
|
||||
createdByWorkspaceMember: connectedAccount.accountOwner,
|
||||
createdByContext: {
|
||||
|
||||
Reference in New Issue
Block a user