PR comment followups (isNonEmptyString and rename WorkflowExecutionResult) (#13706)
Addressing two comments from Thomas and Charles
This commit is contained in:
+3
-3
@@ -57,7 +57,7 @@ export type ExecutionStatus = {
|
||||
additionalInfo?: string;
|
||||
};
|
||||
|
||||
type WorkflowExecutionResultProps = {
|
||||
type WorkflowStepExecutionResultProps = {
|
||||
result: string;
|
||||
language: 'plaintext' | 'json';
|
||||
height?: string | number;
|
||||
@@ -67,7 +67,7 @@ type WorkflowExecutionResultProps = {
|
||||
idleMessage?: string;
|
||||
};
|
||||
|
||||
export const WorkflowExecutionResult = ({
|
||||
export const WorkflowStepExecutionResult = ({
|
||||
result,
|
||||
language,
|
||||
height = '100%',
|
||||
@@ -75,7 +75,7 @@ export const WorkflowExecutionResult = ({
|
||||
isTesting = false,
|
||||
loadingMessage = 'Processing...',
|
||||
idleMessage = 'Output',
|
||||
}: WorkflowExecutionResultProps) => {
|
||||
}: WorkflowStepExecutionResultProps) => {
|
||||
const theme = useTheme();
|
||||
|
||||
const SuccessLeftNode = (
|
||||
+5
-5
@@ -4,11 +4,11 @@ import { ComponentDecorator } from 'twenty-ui/testing';
|
||||
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
|
||||
import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
|
||||
|
||||
import { WorkflowExecutionResult } from '@/workflow/components/WorkflowExecutionResult';
|
||||
import { WorkflowStepExecutionResult } from '@/workflow/components/WorkflowStepExecutionResult';
|
||||
|
||||
const meta: Meta<typeof WorkflowExecutionResult> = {
|
||||
title: 'Modules/Workflow/Components/ExecutionResult',
|
||||
component: WorkflowExecutionResult,
|
||||
const meta: Meta<typeof WorkflowStepExecutionResult> = {
|
||||
title: 'Modules/Workflow/Components/StepExecutionResult',
|
||||
component: WorkflowStepExecutionResult,
|
||||
decorators: [ComponentDecorator, SnackBarDecorator, I18nFrontDecorator],
|
||||
args: {
|
||||
result: JSON.stringify(
|
||||
@@ -29,7 +29,7 @@ const meta: Meta<typeof WorkflowExecutionResult> = {
|
||||
};
|
||||
|
||||
export default meta;
|
||||
type Story = StoryObj<typeof WorkflowExecutionResult>;
|
||||
type Story = StoryObj<typeof WorkflowStepExecutionResult>;
|
||||
|
||||
export const Idle: Story = {
|
||||
args: {
|
||||
Reference in New Issue
Block a user