Add uninstall button to application setting (#15988)

As title

<img width="878" height="668" alt="image"
src="https://github.com/user-attachments/assets/b0c9ae1e-036f-4bdd-9bd2-a2a37c2e3b99"
/>
This commit is contained in:
martmull
2025-11-21 15:45:07 +01:00
committed by GitHub
parent 1fa9c45879
commit 445b76fa26
25 changed files with 352 additions and 59 deletions
@@ -6,7 +6,10 @@ import {
ApplicationException,
ApplicationExceptionCode,
} from 'src/engine/core-modules/application/application.exception';
import { NotFoundError } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import {
NotFoundError,
UserInputError,
} from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
@Catch(ApplicationException)
export class ApplicationExceptionFilter implements ExceptionFilter {
@@ -18,6 +21,8 @@ export class ApplicationExceptionFilter implements ExceptionFilter {
case ApplicationExceptionCode.APPLICATION_NOT_FOUND:
case ApplicationExceptionCode.SERVERLESS_FUNCTION_NOT_FOUND:
throw new NotFoundError(exception);
case ApplicationExceptionCode.FORBIDDEN:
throw new UserInputError(exception);
default: {
assertUnreachable(exception.code);
}
@@ -926,7 +926,7 @@ export class ApplicationSyncService {
}
}
public async deleteApplication({
public async uninstallApplication({
workspaceId,
applicationUniversalIdentifier,
}: {
@@ -959,6 +959,13 @@ export class ApplicationSyncService {
);
}
if (!application.canBeUninstalled) {
throw new ApplicationException(
'This application cannot be uninstalled.',
ApplicationExceptionCode.FORBIDDEN,
);
}
const flatObjectMetadataMapsByApplicationId =
getFlatEntitiesByApplicationId(
existingFlatObjectMetadataMaps,
@@ -59,6 +59,9 @@ export class ApplicationEntity {
@Column({ nullable: true, type: 'uuid' })
serverlessFunctionLayerId: string | null;
@Column({ nullable: false, type: 'boolean', default: true })
canBeUninstalled: boolean;
@ManyToOne(() => WorkspaceEntity, {
onDelete: 'CASCADE',
})
@@ -8,4 +8,5 @@ export enum ApplicationExceptionCode {
SERVERLESS_FUNCTION_NOT_FOUND = 'SERVERLESS_FUNCTION_NOT_FOUND',
ENTITY_NOT_FOUND = 'ENTITY_NOT_FOUND',
APPLICATION_NOT_FOUND = 'APPLICATION_NOT_FOUND',
FORBIDDEN = 'FORBIDDEN',
}
@@ -7,7 +7,7 @@ import { ApplicationSyncService } from 'src/engine/core-modules/application/appl
import { ApplicationService } from 'src/engine/core-modules/application/application.service';
import { ApplicationDTO } from 'src/engine/core-modules/application/dtos/application.dto';
import { ApplicationInput } from 'src/engine/core-modules/application/dtos/application.input';
import { DeleteApplicationInput } from 'src/engine/core-modules/application/dtos/deleteApplication.input';
import { UninstallApplicationInput } from 'src/engine/core-modules/application/dtos/uninstallApplicationInput';
import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
@@ -61,11 +61,11 @@ export class ApplicationResolver {
}
@Mutation(() => Boolean)
async deleteApplication(
@Args() { universalIdentifier }: DeleteApplicationInput,
async uninstallApplication(
@Args() { universalIdentifier }: UninstallApplicationInput,
@AuthWorkspace() { id: workspaceId }: WorkspaceEntity,
) {
await this.applicationSyncService.deleteApplication({
await this.applicationSyncService.uninstallApplication({
applicationUniversalIdentifier: universalIdentifier,
workspaceId,
});
@@ -1,6 +1,6 @@
import { Field, ObjectType } from '@nestjs/graphql';
import { IsNotEmpty, IsString, IsUUID } from 'class-validator';
import { IsBoolean, IsNotEmpty, IsString, IsUUID } from 'class-validator';
import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
import { ApplicationVariableEntityDTO } from 'src/engine/core-modules/applicationVariable/dtos/application-variable.dto';
@@ -27,6 +27,14 @@ export class ApplicationDTO {
@Field()
version: string;
@IsString()
@Field()
universalIdentifier: string;
@Field(() => Boolean)
@IsBoolean()
canBeUninstalled: boolean;
@Field(() => [AgentDTO])
agents: AgentDTO[];
@@ -38,8 +46,4 @@ export class ApplicationDTO {
@Field(() => [ApplicationVariableEntityDTO])
applicationVariables: ApplicationVariableEntityDTO[];
@IsString()
@Field()
universalIdentifier: string;
}
@@ -1,7 +1,7 @@
import { ArgsType, Field } from '@nestjs/graphql';
@ArgsType()
export class DeleteApplicationInput {
export class UninstallApplicationInput {
@Field(() => String)
universalIdentifier: string;
}
@@ -8,6 +8,7 @@ export const TWENTY_STANDARD_APPLICATION = {
version: '1.0.0',
sourcePath: 'cli-sync',
sourceType: 'local',
canBeUninstalled: false,
} as const satisfies CreateApplicationInput;
export type CreateApplicationInput = Omit<
@@ -24,5 +25,3 @@ export type CreateApplicationInput = Omit<
| 'objects'
| 'serverlessFunctions'
>;
export type TwentyStandardApplicationUniversalIdentifiers =
(typeof TWENTY_STANDARD_APPLICATION)['universalIdentifier'];
@@ -20,6 +20,7 @@ export const computeWorkspaceCustomCreateApplicationInput = ({
universalIdentifier: applicationId,
workspaceId: workspace.id,
id: applicationId,
canBeUninstalled: false,
}) as const satisfies CreateApplicationInput & {
workspaceId: string;
id: string;