Fix chart limits for two-dimensional group by (#16056)
The limit wasn't working properly for two dimensional stacked charts. This PR fixes this.
This commit is contained in:
+65
@@ -0,0 +1,65 @@
|
||||
import {
|
||||
type BarChartConfiguration,
|
||||
type LineChartConfiguration,
|
||||
} from '~/generated-metadata/graphql';
|
||||
import { isChartConfigurationTwoDimensional } from '../isChartConfigurationTwoDimensional';
|
||||
|
||||
describe('isChartConfigurationTwoDimensional', () => {
|
||||
describe('BarChartConfiguration', () => {
|
||||
it('should return true for bar chart with secondary axis', () => {
|
||||
const result = isChartConfigurationTwoDimensional({
|
||||
__typename: 'BarChartConfiguration',
|
||||
secondaryAxisGroupByFieldMetadataId: 'some-field-id',
|
||||
} as BarChartConfiguration);
|
||||
|
||||
expect(result).toBe(true);
|
||||
});
|
||||
|
||||
it('should return false for bar chart without secondary axis', () => {
|
||||
const result = isChartConfigurationTwoDimensional({
|
||||
__typename: 'BarChartConfiguration',
|
||||
secondaryAxisGroupByFieldMetadataId: null,
|
||||
} as BarChartConfiguration);
|
||||
|
||||
expect(result).toBe(false);
|
||||
});
|
||||
|
||||
it('should return false for bar chart with undefined secondary axis', () => {
|
||||
const result = isChartConfigurationTwoDimensional({
|
||||
__typename: 'BarChartConfiguration',
|
||||
secondaryAxisGroupByFieldMetadataId: undefined,
|
||||
} as BarChartConfiguration);
|
||||
|
||||
expect(result).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('LineChartConfiguration', () => {
|
||||
it('should return true for line chart with secondary axis', () => {
|
||||
const result = isChartConfigurationTwoDimensional({
|
||||
__typename: 'LineChartConfiguration',
|
||||
secondaryAxisGroupByFieldMetadataId: 'some-field-id',
|
||||
} as LineChartConfiguration);
|
||||
|
||||
expect(result).toBe(true);
|
||||
});
|
||||
|
||||
it('should return false for line chart without secondary axis', () => {
|
||||
const result = isChartConfigurationTwoDimensional({
|
||||
__typename: 'LineChartConfiguration',
|
||||
secondaryAxisGroupByFieldMetadataId: null,
|
||||
} as LineChartConfiguration);
|
||||
|
||||
expect(result).toBe(false);
|
||||
});
|
||||
|
||||
it('should return false for line chart with undefined secondary axis', () => {
|
||||
const result = isChartConfigurationTwoDimensional({
|
||||
__typename: 'LineChartConfiguration',
|
||||
secondaryAxisGroupByFieldMetadataId: undefined,
|
||||
} as LineChartConfiguration);
|
||||
|
||||
expect(result).toBe(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
+11
@@ -0,0 +1,11 @@
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import {
|
||||
type BarChartConfiguration,
|
||||
type LineChartConfiguration,
|
||||
} from '~/generated/graphql';
|
||||
|
||||
export const isChartConfigurationTwoDimensional = (
|
||||
configuration: BarChartConfiguration | LineChartConfiguration,
|
||||
): boolean => {
|
||||
return isDefined(configuration.secondaryAxisGroupByFieldMetadataId);
|
||||
};
|
||||
Reference in New Issue
Block a user