Remove logic function layer (#17697)

## Remove logic function layer Package.json and yarn.lock are now on the application entity, so the logic function layer is no longer used except as a legacy source for the 1.17 backfill. This PR removes all layer usage outside of that migration and keeps only the entity for backfill. ### Summary - **Kept:** `LogicFunctionLayerEntity` and its table, only used by the 1.17 backfill command to read legacy layer data and backfill application package files. - **Removed:** All other layer logic: CRUD, cache, resolvers, services, DTOs, and frontend types. Logic functions now depend only on the application for package/dependency context. ### Why Dependencies instead of Source for package files Package.json and yarn.lock are the application’s dependency set and are stored under the application in **FileFolder.Dependencies**. The build service and drivers now read them only from Dependencies; nothing is written to Source for these files.
2026-02-04 10:17:27 +01:00
parent e10e0b337e
commit 402d149ee1
36 changed files with 171 additions and 643 deletions
@@ -1,17 +0,0 @@
-import { ArgsType, Field } from '@nestjs/graphql';
-
-import { IsString } from 'class-validator';
-import GraphQLJSON from 'graphql-type-json';
-
-@ArgsType()
-export class CreateLogicFunctionLayerInput {
-  @Field(() => GraphQLJSON, { nullable: false })
-  packageJsonChecksum: string;
-
-  @IsString()
-  @Field(() => String, { nullable: false })
-  yarnLockChecksum: string;
-
-  @Field(() => String)
-  applicationUniversalIdentifier: string;
-}
@@ -1,23 +0,0 @@
-import { Field, ObjectType } from '@nestjs/graphql';
-
-import { IsDateString } from 'class-validator';
-import { IDField } from '@ptc-org/nestjs-query-graphql';
-
-import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
-
-@ObjectType('LogicFunctionLayer')
-export class LogicFunctionLayerDTO {
-  @IDField(() => UUIDScalarType)
-  id: string;
-
-  @IDField(() => UUIDScalarType, { nullable: true })
-  applicationId?: string;
-
-  @IsDateString()
-  @Field()
-  createdAt: Date;
-
-  @IsDateString()
-  @Field()
-  updatedAt: Date;
-}
@@ -3,13 +3,10 @@ import {
  Column,
  CreateDateColumn,
  Entity,
-  OneToMany,
  PrimaryGeneratedColumn,
-  Relation,
  UpdateDateColumn,
 } from 'typeorm';

-import { LogicFunctionEntity } from 'src/engine/metadata-modules/logic-function/logic-function.entity';
 import { WorkspaceRelatedEntity } from 'src/engine/workspace-manager/types/workspace-related-entity';

@Entity('logicFunctionLayer')
@@ -32,15 +29,6 @@ export class LogicFunctionLayerEntity extends WorkspaceRelatedEntity {
  @Column({ type: 'jsonb', nullable: false, default: {} })
  availablePackages: Record<string, string>;

-  @OneToMany(
-    () => LogicFunctionEntity,
-    (logicFunction) => logicFunction.logicFunctionLayer,
-    {
-      onDelete: 'RESTRICT',
-    },
-  )
-  logicFunctions: Relation<LogicFunctionEntity[]>;
-
  @CreateDateColumn({ type: 'timestamptz' })
  createdAt: Date;

@@ -1,20 +1,10 @@
 import { Module } from '@nestjs/common';
 import { TypeOrmModule } from '@nestjs/typeorm';

-import { PermissionsModule } from 'src/engine/metadata-modules/permissions/permissions.module';
 import { LogicFunctionLayerEntity } from 'src/engine/metadata-modules/logic-function-layer/logic-function-layer.entity';
-import { LogicFunctionLayerResolver } from 'src/engine/metadata-modules/logic-function-layer/logic-function-layer.resolver';
-import { WorkspaceLogicFunctionLayerMapCacheService } from 'src/engine/metadata-modules/logic-function-layer/services/workspace-logic-function-layer-map-cache.service';

@Module({
-  imports: [
-    TypeOrmModule.forFeature([LogicFunctionLayerEntity]),
-    PermissionsModule,
-  ],
-  providers: [
-    LogicFunctionLayerResolver,
-    WorkspaceLogicFunctionLayerMapCacheService,
-  ],
-  exports: [WorkspaceLogicFunctionLayerMapCacheService],
+  imports: [TypeOrmModule.forFeature([LogicFunctionLayerEntity])],
+  exports: [TypeOrmModule],
 })
 export class LogicFunctionLayerModule {}
@@ -1,33 +0,0 @@
-import { UseGuards } from '@nestjs/common';
-import { Args, Mutation, Resolver } from '@nestjs/graphql';
-
-import { PermissionFlagType } from 'twenty-shared/constants';
-
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { AuthWorkspace } from 'src/engine/decorators/auth/auth-workspace.decorator';
-import { SettingsPermissionGuard } from 'src/engine/guards/settings-permission.guard';
-import { WorkspaceAuthGuard } from 'src/engine/guards/workspace-auth.guard';
-import { CreateLogicFunctionLayerInput } from 'src/engine/metadata-modules/logic-function-layer/dtos/create-logic-function-layer.input';
-import { LogicFunctionLayerDTO } from 'src/engine/metadata-modules/logic-function-layer/dtos/logic-function-layer.dto';
-import { LogicFunctionLayerService } from 'src/engine/core-modules/logic-function/logic-function-layer/services/logic-function-layer.service';
-
-@UseGuards(WorkspaceAuthGuard)
-@Resolver()
-export class LogicFunctionLayerResolver {
-  constructor(
-    private readonly logicFunctionLayerService: LogicFunctionLayerService,
-  ) {}
-
-  @Mutation(() => LogicFunctionLayerDTO)
-  @UseGuards(SettingsPermissionGuard(PermissionFlagType.WORKFLOWS))
-  async createOneLogicFunctionLayer(
-    @Args()
-    createLogicFunctionLayerInput: CreateLogicFunctionLayerInput,
-    @AuthWorkspace() { id: workspaceId }: WorkspaceEntity,
-  ) {
-    return this.logicFunctionLayerService.create(
-      createLogicFunctionLayerInput,
-      workspaceId,
-    );
-  }
-}
@@ -1,47 +0,0 @@
-import { Injectable } from '@nestjs/common';
-import { InjectRepository } from '@nestjs/typeorm';
-
-import { Repository } from 'typeorm';
-
-import { WorkspaceCacheProvider } from 'src/engine/workspace-cache/interfaces/workspace-cache-provider.service';
-
-import { LogicFunctionLayerEntity } from 'src/engine/metadata-modules/logic-function-layer/logic-function-layer.entity';
-import { type LogicFunctionLayerCacheMaps } from 'src/engine/metadata-modules/logic-function-layer/types/logic-function-layer-cache-maps.type';
-import { fromLogicFunctionLayerEntityToFlatLogicFunctionLayer } from 'src/engine/metadata-modules/logic-function-layer/utils/from-logic-function-layer-entity-to-flat-logic-function-layer.util';
-import { WorkspaceCache } from 'src/engine/workspace-cache/decorators/workspace-cache.decorator';
-
-@Injectable()
-@WorkspaceCache('logicFunctionLayerMaps')
-export class WorkspaceLogicFunctionLayerMapCacheService extends WorkspaceCacheProvider<LogicFunctionLayerCacheMaps> {
-  constructor(
-    @InjectRepository(LogicFunctionLayerEntity)
-    private readonly logicFunctionLayerRepository: Repository<LogicFunctionLayerEntity>,
-  ) {
-    super();
-  }
-
-  async computeForCache(
-    workspaceId: string,
-  ): Promise<LogicFunctionLayerCacheMaps> {
-    const logicFunctionLayerEntities =
-      await this.logicFunctionLayerRepository.find({
-        where: {
-          workspaceId,
-        },
-      });
-
-    const logicFunctionLayerMaps: LogicFunctionLayerCacheMaps = {
-      byId: {},
-    };
-
-    for (const entity of logicFunctionLayerEntities) {
-      const flatLogicFunctionLayer =
-        fromLogicFunctionLayerEntityToFlatLogicFunctionLayer(entity);
-
-      logicFunctionLayerMaps.byId[flatLogicFunctionLayer.id] =
-        flatLogicFunctionLayer;
-    }
-
-    return logicFunctionLayerMaps;
-  }
-}
@@ -1,4 +0,0 @@
-import { type FlatEntityFrom } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-from.type';
-import { type LogicFunctionLayerEntity } from 'src/engine/metadata-modules/logic-function-layer/logic-function-layer.entity';
-
-export type FlatLogicFunctionLayer = FlatEntityFrom<LogicFunctionLayerEntity>;
@@ -1,5 +0,0 @@
-import { type FlatLogicFunctionLayer } from 'src/engine/metadata-modules/logic-function-layer/types/flat-logic-function-layer.type';
-
-export type LogicFunctionLayerCacheMaps = {
-  byId: Partial<Record<string, FlatLogicFunctionLayer>>;
-};
@@ -1,17 +0,0 @@
-import { type LogicFunctionLayerEntity } from 'src/engine/metadata-modules/logic-function-layer/logic-function-layer.entity';
-import { type FlatLogicFunctionLayer } from 'src/engine/metadata-modules/logic-function-layer/types/flat-logic-function-layer.type';
-
-export const fromLogicFunctionLayerEntityToFlatLogicFunctionLayer = (
-  entity: LogicFunctionLayerEntity,
-): FlatLogicFunctionLayer => ({
-  id: entity.id,
-  packageJson: entity.packageJson,
-  packageJsonChecksum: entity.packageJsonChecksum,
-  yarnLock: entity.yarnLock,
-  yarnLockChecksum: entity.yarnLockChecksum,
-  workspaceId: entity.workspaceId,
-  createdAt: entity.createdAt.toISOString(),
-  updatedAt: entity.updatedAt.toISOString(),
-  logicFunctionIds: entity.logicFunctions?.map((lf) => lf.id) ?? [],
-  availablePackages: entity.availablePackages ?? {},
-});