From 2a4db1697077edf686bccd2ba8ae4f22e607ca93 Mon Sep 17 00:00:00 2001 From: Charles Bochet Date: Tue, 5 May 2026 15:30:56 +0200 Subject: [PATCH] fix(website-new): inherit test target so twenty-shared builds in CI (#20285) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary The new `CI Website` workflow added in #20281 fails on the `test` matrix job because tests cannot resolve `twenty-shared/translations` — a subpath that requires `twenty-shared` to be built first. Root cause: `packages/twenty-website-new/project.json` fully overrides the `test` target, duplicating the executor/options/configurations from `nx.json` `targetDefaults` but **losing `dependsOn: ["^build"]`** (and `inputs` / `cache`). As a result, `nx affected -t test` for `twenty-website-new` does not build `twenty-shared` first. `twenty-front` works because its `project.json` declares `"test": {}` and inherits the full default. This PR does the same for `twenty-website-new`. Verified the diagnosis from the failing run — `front-task (test)` logs show `nx run twenty-shared:build` is invoked transitively, while `website-task (test)` logs do not, leading to the missing-module error. --- packages/twenty-website-new/project.json | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/packages/twenty-website-new/project.json b/packages/twenty-website-new/project.json index d34b1d7665..ee08ca36ab 100644 --- a/packages/twenty-website-new/project.json +++ b/packages/twenty-website-new/project.json @@ -87,29 +87,7 @@ ] }, "typecheck": {}, - "test": { - "executor": "@nx/jest:jest", - "outputs": ["{projectRoot}/coverage"], - "options": { - "jestConfig": "{projectRoot}/jest.config.mjs", - "silent": true, - "coverage": true, - "coverageReporters": ["text-summary"], - "cacheDirectory": "../../.cache/jest/{projectRoot}" - }, - "configurations": { - "ci": { - "ci": true, - "maxWorkers": 1 - }, - "coverage": { - "coverageReporters": ["lcov", "text"] - }, - "watch": { - "watch": true - } - } - }, + "test": {}, "fmt": { "options": { "files": "."